From: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com> To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com> Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kevin Hilman <khilman@ti.com>, Rajendra Nayak <rnayak@ti.com>, "Cousson, Benoit" <b-cousson@ti.com>, Paul Walmsley <paul@pwsan.com> Subject: Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver Date: Wed, 8 Aug 2012 19:38:07 +0530 [thread overview] Message-ID: <CAC83ZvK9KVpH=7K9eAHQY3WDtEbw_W_Drxqhk=6v+wZzcOYHDw@mail.gmail.com> (raw) In-Reply-To: <CAMQu2gzi0_NS_W_DN=D=+3n6sNw_NTfkaNzaqV3QPG4mL+RoRg@mail.gmail.com> On Wed, Aug 8, 2012 at 7:33 PM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Wed, Aug 8, 2012 at 7:28 PM, Tarun Kanti DebBarma <tarun.kanti@ti.com> wrote: >> Add *remove* callback so that necessary cleanup operations are >> performed when device is unregistered. The device is deleted >> from the list and associated clock handle is released by >> calling clk_put() and irq descriptor is released using the >> irq_free_desc() api. >> >> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com> >> Reported-by: Paul Walmsley <paul@pwsan.com> >> Reviewed-by: Jon Hunter <jon-hunter@ti.com> >> Cc: Kevin Hilman <khilman@ti.com> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> >> Cc: Cousson, Benoit <b-cousson@ti.com> >> Cc: Paul Walmsley <paul@pwsan.com> >> --- >> v2: >> Baseline: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git >> Commit: 0d7614f09c1ebdbaa1599a5aba7593f147bf96ee (Linux 3.6-rc1) >> >> (1) Use irq_free_descs() instead of irq_free_desc(). >> Besides, irq_free_desc() was using wrong parameter, >> irq_base, instead of bank->irq. >> (2) irq_free_descs() moved outside spin_lock/unlock_*() >> in order to avoid exception warnings. >> >> (3) pm_runtime_disable() added so that bind can happen successfully >> >> Test Detail: >> Step 1: Unbind gpio.5 device in order to invoke the *remove* callback. >> #echo "omap_gpio.5" > sys/bus/platform/drivers/omap_gpio/unbind >> >> Step 2: Bind gpio.5 device and confirm probe() for the device succeeds. >> #echo "omap_gpio.5" > sys/bus/platform/drivers/omap_gpio/bind >> >> Step 3: Execute read/write GPIO test case. >> > Thanks details about test. Whe you to "Unbind->bind", do > you see that PM is not broken. > > In other words, can you also test and ensure that the OMAP3 suspend and > CPUIDLE are not broken because of this patch. > PER and CORE domains should transition to low power states. Sure, I will do the PM test on OMAP3 and confirm this. --- Tarun > > Regards > Santosh
WARNING: multiple messages have this Message-ID (diff)
From: tarun.kanti@ti.com (DebBarma, Tarun Kanti) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] gpio/omap: add *remove* callback in platform_driver Date: Wed, 8 Aug 2012 19:38:07 +0530 [thread overview] Message-ID: <CAC83ZvK9KVpH=7K9eAHQY3WDtEbw_W_Drxqhk=6v+wZzcOYHDw@mail.gmail.com> (raw) In-Reply-To: <CAMQu2gzi0_NS_W_DN=D=+3n6sNw_NTfkaNzaqV3QPG4mL+RoRg@mail.gmail.com> On Wed, Aug 8, 2012 at 7:33 PM, Shilimkar, Santosh <santosh.shilimkar@ti.com> wrote: > On Wed, Aug 8, 2012 at 7:28 PM, Tarun Kanti DebBarma <tarun.kanti@ti.com> wrote: >> Add *remove* callback so that necessary cleanup operations are >> performed when device is unregistered. The device is deleted >> from the list and associated clock handle is released by >> calling clk_put() and irq descriptor is released using the >> irq_free_desc() api. >> >> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com> >> Reported-by: Paul Walmsley <paul@pwsan.com> >> Reviewed-by: Jon Hunter <jon-hunter@ti.com> >> Cc: Kevin Hilman <khilman@ti.com> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> >> Cc: Cousson, Benoit <b-cousson@ti.com> >> Cc: Paul Walmsley <paul@pwsan.com> >> --- >> v2: >> Baseline: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git >> Commit: 0d7614f09c1ebdbaa1599a5aba7593f147bf96ee (Linux 3.6-rc1) >> >> (1) Use irq_free_descs() instead of irq_free_desc(). >> Besides, irq_free_desc() was using wrong parameter, >> irq_base, instead of bank->irq. >> (2) irq_free_descs() moved outside spin_lock/unlock_*() >> in order to avoid exception warnings. >> >> (3) pm_runtime_disable() added so that bind can happen successfully >> >> Test Detail: >> Step 1: Unbind gpio.5 device in order to invoke the *remove* callback. >> #echo "omap_gpio.5" > sys/bus/platform/drivers/omap_gpio/unbind >> >> Step 2: Bind gpio.5 device and confirm probe() for the device succeeds. >> #echo "omap_gpio.5" > sys/bus/platform/drivers/omap_gpio/bind >> >> Step 3: Execute read/write GPIO test case. >> > Thanks details about test. Whe you to "Unbind->bind", do > you see that PM is not broken. > > In other words, can you also test and ensure that the OMAP3 suspend and > CPUIDLE are not broken because of this patch. > PER and CORE domains should transition to low power states. Sure, I will do the PM test on OMAP3 and confirm this. --- Tarun > > Regards > Santosh
next prev parent reply other threads:[~2012-08-08 14:08 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-08 13:58 [PATCH v2] gpio/omap: add *remove* callback in platform_driver Tarun Kanti DebBarma 2012-08-08 13:58 ` Tarun Kanti DebBarma 2012-08-08 13:58 ` Tarun Kanti DebBarma 2012-08-08 14:03 ` Shilimkar, Santosh 2012-08-08 14:03 ` Shilimkar, Santosh 2012-08-08 14:08 ` DebBarma, Tarun Kanti [this message] 2012-08-08 14:08 ` DebBarma, Tarun Kanti 2012-08-08 17:10 ` Kevin Hilman 2012-08-08 17:10 ` Kevin Hilman 2012-08-08 17:10 ` Kevin Hilman 2012-08-09 4:06 ` DebBarma, Tarun Kanti 2012-08-09 4:06 ` DebBarma, Tarun Kanti 2012-08-09 14:58 ` Kevin Hilman 2012-08-09 14:58 ` Kevin Hilman 2012-08-09 14:58 ` Kevin Hilman 2012-08-10 6:08 ` DebBarma, Tarun Kanti 2012-08-10 6:08 ` DebBarma, Tarun Kanti 2012-08-10 6:57 ` Shilimkar, Santosh 2012-08-10 6:57 ` Shilimkar, Santosh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAC83ZvK9KVpH=7K9eAHQY3WDtEbw_W_Drxqhk=6v+wZzcOYHDw@mail.gmail.com' \ --to=tarun.kanti@ti.com \ --cc=b-cousson@ti.com \ --cc=khilman@ti.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=rnayak@ti.com \ --cc=santosh.shilimkar@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.