* [PATCH] leds: pwm: Fix an error code
@ 2023-07-11 8:30 Fei Shao
2023-07-11 9:09 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Fei Shao @ 2023-07-11 8:30 UTC (permalink / raw)
To: Lee Jones, Andy Shevchenko
Cc: Fei Shao, Pavel Machek, linux-kernel, linux-leds
Use the negated -EINVAL as the error code.
Fixes: 95138e01275e ("leds: pwm: Make error handling more robust")
Signed-off-by: Fei Shao <fshao@chromium.org>
---
drivers/leds/leds-pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 29194cc382af..87c199242f3c 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -146,7 +146,7 @@ static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
led.name = to_of_node(fwnode)->name;
if (!led.name) {
- ret = EINVAL;
+ ret = -EINVAL;
goto err_child_out;
}
--
2.41.0.390.g38632f3daf-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] leds: pwm: Fix an error code
2023-07-11 8:30 [PATCH] leds: pwm: Fix an error code Fei Shao
@ 2023-07-11 9:09 ` Andy Shevchenko
2023-07-11 9:20 ` Fei Shao
2023-07-12 12:00 ` Lee Jones
0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2023-07-11 9:09 UTC (permalink / raw)
To: Fei Shao; +Cc: Lee Jones, Pavel Machek, linux-kernel, linux-leds
On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <fshao@chromium.org> wrote:
>
> Use the negated -EINVAL as the error code.
Thank you, it seems Dan had been the first one.
Message ID <a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] leds: pwm: Fix an error code
2023-07-11 9:09 ` Andy Shevchenko
@ 2023-07-11 9:20 ` Fei Shao
2023-07-12 12:00 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Fei Shao @ 2023-07-11 9:20 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, Pavel Machek, linux-kernel, linux-leds
Hi Andy,
On Tue, Jul 11, 2023 at 5:10 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <fshao@chromium.org> wrote:
> >
> > Use the negated -EINVAL as the error code.
>
> Thank you, it seems Dan had been the first one.
>
> Message ID <a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain>
Thanks for the pointer. Please disregard this patch.
Regards,
Fei
>
> --
> With Best Regards,
> Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] leds: pwm: Fix an error code
2023-07-11 9:09 ` Andy Shevchenko
2023-07-11 9:20 ` Fei Shao
@ 2023-07-12 12:00 ` Lee Jones
2023-07-12 12:49 ` Andy Shevchenko
1 sibling, 1 reply; 6+ messages in thread
From: Lee Jones @ 2023-07-12 12:00 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Fei Shao, Pavel Machek, linux-kernel, linux-leds
On Tue, 11 Jul 2023, Andy Shevchenko wrote:
> On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <fshao@chromium.org> wrote:
> >
> > Use the negated -EINVAL as the error code.
>
> Thank you, it seems Dan had been the first one.
>
> Message ID <a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain>
I don't know much about how other people operate, but I have no way to
trivially navigate to this. Would you be kind enough to use URLs
please?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] leds: pwm: Fix an error code
2023-07-12 12:00 ` Lee Jones
@ 2023-07-12 12:49 ` Andy Shevchenko
2023-07-12 13:07 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2023-07-12 12:49 UTC (permalink / raw)
To: Lee Jones; +Cc: Fei Shao, Pavel Machek, linux-kernel, linux-leds
On Wed, Jul 12, 2023 at 3:00 PM Lee Jones <lee@kernel.org> wrote:
> On Tue, 11 Jul 2023, Andy Shevchenko wrote:
>
> > On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <fshao@chromium.org> wrote:
> > >
> > > Use the negated -EINVAL as the error code.
> >
> > Thank you, it seems Dan had been the first one.
> >
> > Message ID <a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain>
>
> I don't know much about how other people operate, but I have no way to
> trivially navigate to this. Would you be kind enough to use URLs
> please?
Use this pattern:
https://lore.kernel.org/r/$MSG_ID
where $MSG_ID is a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain
in this case.
Hence, the URL:
https://lore.kernel.org/r/a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain
Easier way is simply run `b4 mbox $MSG_ID` and open the loaded mbox
with your preferred MUA.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] leds: pwm: Fix an error code
2023-07-12 12:49 ` Andy Shevchenko
@ 2023-07-12 13:07 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2023-07-12 13:07 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Fei Shao, Pavel Machek, linux-kernel, linux-leds
On Wed, 12 Jul 2023, Andy Shevchenko wrote:
> On Wed, Jul 12, 2023 at 3:00 PM Lee Jones <lee@kernel.org> wrote:
> > On Tue, 11 Jul 2023, Andy Shevchenko wrote:
> >
> > > On Tue, Jul 11, 2023 at 11:31 AM Fei Shao <fshao@chromium.org> wrote:
> > > >
> > > > Use the negated -EINVAL as the error code.
> > >
> > > Thank you, it seems Dan had been the first one.
> > >
> > > Message ID <a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain>
> >
> > I don't know much about how other people operate, but I have no way to
> > trivially navigate to this. Would you be kind enough to use URLs
> > please?
>
> Use this pattern:
> https://lore.kernel.org/r/$MSG_ID
> where $MSG_ID is a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain
> in this case.
>
> Hence, the URL:
> https://lore.kernel.org/r/a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain
>
> Easier way is simply run `b4 mbox $MSG_ID` and open the loaded mbox
> with your preferred MUA.
Right, I'm aware that I can manually manipulate the lore URL in this way.
However I, like many, do not have a way to do this easily from my mailer.
This is why directly navigatable / clickable URLs were invented. :)
Please could you use full / clickable URLs to messages?
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-12 13:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-11 8:30 [PATCH] leds: pwm: Fix an error code Fei Shao
2023-07-11 9:09 ` Andy Shevchenko
2023-07-11 9:20 ` Fei Shao
2023-07-12 12:00 ` Lee Jones
2023-07-12 12:49 ` Andy Shevchenko
2023-07-12 13:07 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.