From: Ben Skeggs <skeggsb@gmail.com>
To: Lyude Paul <lyude@redhat.com>
Cc: ML nouveau <nouveau@lists.freedesktop.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>, Ben Skeggs <bskeggs@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 01/20] drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()
Date: Wed, 12 Aug 2020 10:10:13 +1000 [thread overview]
Message-ID: <CACAvsv5FnVom3Od=EfZO3Y1WhCXDhBvCSNwFx8bc_BNg75iL4g@mail.gmail.com> (raw)
In-Reply-To: <20200811200457.134743-2-lyude@redhat.com>
On Wed, 12 Aug 2020 at 06:05, Lyude Paul <lyude@redhat.com> wrote:
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_dp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c
> index 8a0f7994e1aeb..ee778ddc95fae 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_dp.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_dp.c
> @@ -76,10 +76,10 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
> nv_encoder->dp.link_nr = dpcd[2] & DP_MAX_LANE_COUNT_MASK;
>
> NV_DEBUG(drm, "display: %dx%d dpcd 0x%02x\n",
> - nv_encoder->dp.link_nr, nv_encoder->dp.link_bw, dpcd[0]);
> + nv_encoder->dp.link_nr, nv_encoder->dp.link_bw, dpcd[0]);
> NV_DEBUG(drm, "encoder: %dx%d\n",
> - nv_encoder->dcb->dpconf.link_nr,
> - nv_encoder->dcb->dpconf.link_bw);
> + nv_encoder->dcb->dpconf.link_nr,
> + nv_encoder->dcb->dpconf.link_bw);
>
> if (nv_encoder->dcb->dpconf.link_nr < nv_encoder->dp.link_nr)
> nv_encoder->dp.link_nr = nv_encoder->dcb->dpconf.link_nr;
> @@ -87,7 +87,7 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
> nv_encoder->dp.link_bw = nv_encoder->dcb->dpconf.link_bw;
>
> NV_DEBUG(drm, "maximum: %dx%d\n",
> - nv_encoder->dp.link_nr, nv_encoder->dp.link_bw);
> + nv_encoder->dp.link_nr, nv_encoder->dp.link_bw);
>
> nouveau_dp_probe_oui(dev, aux, dpcd);
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ben Skeggs <skeggsb@gmail.com>
To: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
ML nouveau <nouveau@lists.freedesktop.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [RFC 01/20] drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()
Date: Wed, 12 Aug 2020 10:10:13 +1000 [thread overview]
Message-ID: <CACAvsv5FnVom3Od=EfZO3Y1WhCXDhBvCSNwFx8bc_BNg75iL4g@mail.gmail.com> (raw)
In-Reply-To: <20200811200457.134743-2-lyude@redhat.com>
On Wed, 12 Aug 2020 at 06:05, Lyude Paul <lyude@redhat.com> wrote:
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_dp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c
> index 8a0f7994e1aeb..ee778ddc95fae 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_dp.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_dp.c
> @@ -76,10 +76,10 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
> nv_encoder->dp.link_nr = dpcd[2] & DP_MAX_LANE_COUNT_MASK;
>
> NV_DEBUG(drm, "display: %dx%d dpcd 0x%02x\n",
> - nv_encoder->dp.link_nr, nv_encoder->dp.link_bw, dpcd[0]);
> + nv_encoder->dp.link_nr, nv_encoder->dp.link_bw, dpcd[0]);
> NV_DEBUG(drm, "encoder: %dx%d\n",
> - nv_encoder->dcb->dpconf.link_nr,
> - nv_encoder->dcb->dpconf.link_bw);
> + nv_encoder->dcb->dpconf.link_nr,
> + nv_encoder->dcb->dpconf.link_bw);
>
> if (nv_encoder->dcb->dpconf.link_nr < nv_encoder->dp.link_nr)
> nv_encoder->dp.link_nr = nv_encoder->dcb->dpconf.link_nr;
> @@ -87,7 +87,7 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
> nv_encoder->dp.link_bw = nv_encoder->dcb->dpconf.link_bw;
>
> NV_DEBUG(drm, "maximum: %dx%d\n",
> - nv_encoder->dp.link_nr, nv_encoder->dp.link_bw);
> + nv_encoder->dp.link_nr, nv_encoder->dp.link_bw);
>
> nouveau_dp_probe_oui(dev, aux, dpcd);
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ben Skeggs <skeggsb@gmail.com>
To: Lyude Paul <lyude@redhat.com>
Cc: David Airlie <airlied@linux.ie>,
ML nouveau <nouveau@lists.freedesktop.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [Intel-gfx] [RFC 01/20] drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()
Date: Wed, 12 Aug 2020 10:10:13 +1000 [thread overview]
Message-ID: <CACAvsv5FnVom3Od=EfZO3Y1WhCXDhBvCSNwFx8bc_BNg75iL4g@mail.gmail.com> (raw)
In-Reply-To: <20200811200457.134743-2-lyude@redhat.com>
On Wed, 12 Aug 2020 at 06:05, Lyude Paul <lyude@redhat.com> wrote:
>
> Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_dp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c
> index 8a0f7994e1aeb..ee778ddc95fae 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_dp.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_dp.c
> @@ -76,10 +76,10 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
> nv_encoder->dp.link_nr = dpcd[2] & DP_MAX_LANE_COUNT_MASK;
>
> NV_DEBUG(drm, "display: %dx%d dpcd 0x%02x\n",
> - nv_encoder->dp.link_nr, nv_encoder->dp.link_bw, dpcd[0]);
> + nv_encoder->dp.link_nr, nv_encoder->dp.link_bw, dpcd[0]);
> NV_DEBUG(drm, "encoder: %dx%d\n",
> - nv_encoder->dcb->dpconf.link_nr,
> - nv_encoder->dcb->dpconf.link_bw);
> + nv_encoder->dcb->dpconf.link_nr,
> + nv_encoder->dcb->dpconf.link_bw);
>
> if (nv_encoder->dcb->dpconf.link_nr < nv_encoder->dp.link_nr)
> nv_encoder->dp.link_nr = nv_encoder->dcb->dpconf.link_nr;
> @@ -87,7 +87,7 @@ nouveau_dp_detect(struct nouveau_encoder *nv_encoder)
> nv_encoder->dp.link_bw = nv_encoder->dcb->dpconf.link_bw;
>
> NV_DEBUG(drm, "maximum: %dx%d\n",
> - nv_encoder->dp.link_nr, nv_encoder->dp.link_bw);
> + nv_encoder->dp.link_nr, nv_encoder->dp.link_bw);
>
> nouveau_dp_probe_oui(dev, aux, dpcd);
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-12 0:10 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 20:04 [RFC 00/20] drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 01/20] drm/nouveau/kms: Fix some indenting in nouveau_dp_detect() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-12 0:10 ` Ben Skeggs [this message]
2020-08-12 0:10 ` [Intel-gfx] " Ben Skeggs
2020-08-12 0:10 ` Ben Skeggs
2020-08-11 20:04 ` [RFC 02/20] drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 03/20] drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 04/20] drm/nouveau/kms/nv50-: Use macros for DP registers " Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 05/20] drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 06/20] drm/nouveau/kms: Search for encoders' connectors properly Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 07/20] drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in nv50_sor_disable() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 08/20] drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 09/20] drm/i915/dp: Extract drm_dp_has_mst() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-19 15:03 ` Sean Paul
2020-08-19 15:03 ` [Intel-gfx] " Sean Paul
2020-08-19 15:03 ` Sean Paul
2020-08-19 15:03 ` Sean Paul
2020-08-11 20:04 ` [RFC 10/20] drm/nouveau/kms: Use new drm_dp_has_mst() helper for checking MST caps Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-12 0:11 ` Ben Skeggs
2020-08-12 0:11 ` [Intel-gfx] " Ben Skeggs
2020-08-12 0:11 ` Ben Skeggs
2020-08-11 20:04 ` [RFC 11/20] drm/nouveau/kms: Move drm_dp_cec_unset_edid() into nouveau_connector_detect() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 12/20] drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 13/20] drm/i915/dp: Extract drm_dp_downstream_read_info() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-19 15:15 ` Sean Paul
2020-08-19 15:15 ` [Intel-gfx] " Sean Paul
2020-08-19 15:15 ` Sean Paul
2020-08-19 15:15 ` Sean Paul
2020-08-19 17:28 ` Lyude Paul
2020-08-19 17:28 ` [Intel-gfx] " Lyude Paul
2020-08-19 17:28 ` Lyude Paul
2020-08-19 17:28 ` Lyude Paul
2020-08-19 21:34 ` Lyude Paul
2020-08-19 21:34 ` [Intel-gfx] " Lyude Paul
2020-08-19 21:34 ` Lyude Paul
2020-08-20 22:37 ` Imre Deak
2020-08-20 22:37 ` [Intel-gfx] " Imre Deak
2020-08-20 22:37 ` Imre Deak
2020-08-21 17:43 ` Lyude Paul
2020-08-21 17:43 ` [Intel-gfx] " Lyude Paul
2020-08-21 17:43 ` Lyude Paul
2020-08-21 17:43 ` Lyude Paul
2020-08-24 15:46 ` Imre Deak
2020-08-24 15:46 ` [Intel-gfx] " Imre Deak
2020-08-24 15:46 ` Imre Deak
2020-08-24 15:46 ` Imre Deak
2020-08-11 20:04 ` [RFC 14/20] drm/nouveau/kms/nv50-: Use downstream DP clock limits for mode validation Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 15/20] drm/i915/dp: Extract drm_dp_has_sink_count() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-19 15:20 ` Sean Paul
2020-08-19 15:20 ` [Intel-gfx] " Sean Paul
2020-08-19 15:20 ` Sean Paul
2020-08-19 15:20 ` Sean Paul
2020-08-11 20:04 ` [RFC 16/20] drm/i915/dp: Extract drm_dp_get_sink_count() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-19 15:25 ` Sean Paul
2020-08-19 15:25 ` [Intel-gfx] " Sean Paul
2020-08-19 15:25 ` Sean Paul
2020-08-19 15:25 ` Sean Paul
2020-08-11 20:04 ` [RFC 17/20] drm/nouveau/kms/nv50-: Add support for DP_SINK_COUNT Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-12 0:13 ` Ben Skeggs
2020-08-12 0:13 ` [Intel-gfx] " Ben Skeggs
2020-08-12 0:13 ` Ben Skeggs
2020-08-11 20:04 ` [RFC 18/20] drm/nouveau/kms: Don't change EDID when it hasn't actually changed Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` [RFC 19/20] drm/i915/dp: Extract drm_dp_read_dpcd_caps() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-19 15:29 ` Sean Paul
2020-08-19 15:29 ` [Intel-gfx] " Sean Paul
2020-08-19 15:29 ` Sean Paul
2020-08-19 15:29 ` Sean Paul
2020-08-20 16:07 ` Lyude Paul
2020-08-20 16:07 ` [Intel-gfx] " Lyude Paul
2020-08-20 16:07 ` Lyude Paul
2020-08-20 16:07 ` Lyude Paul
2020-08-20 16:49 ` Lyude Paul
2020-08-20 16:49 ` [Intel-gfx] " Lyude Paul
2020-08-20 16:49 ` Lyude Paul
2020-08-20 16:49 ` Lyude Paul
2020-08-11 20:04 ` [RFC 20/20] drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() Lyude Paul
2020-08-11 20:04 ` [Intel-gfx] " Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-11 20:04 ` Lyude Paul
2020-08-12 0:14 ` [Nouveau] " Ben Skeggs
2020-08-12 0:14 ` [Intel-gfx] " Ben Skeggs
2020-08-12 0:14 ` Ben Skeggs
2020-08-12 0:14 ` Ben Skeggs
2020-08-11 21:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 Patchwork
2020-08-11 21:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-08-11 21:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-08-11 21:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 (rev2) Patchwork
2020-08-11 21:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-08-11 22:13 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-08-11 22:17 ` Lyude Paul
2020-08-11 22:44 ` Lyude Paul
2020-08-11 23:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 (rev3) Patchwork
2020-08-11 23:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-08-11 23:28 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACAvsv5FnVom3Od=EfZO3Y1WhCXDhBvCSNwFx8bc_BNg75iL4g@mail.gmail.com' \
--to=skeggsb@gmail.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.