* [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h
@ 2020-01-21 16:17 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-01-21 16:17 UTC (permalink / raw)
To: qemu-devel, Stefano Stabellini, Anthony Perard, Paul Durrant
Cc: qemu-trivial, xen-devel
The define is only used in one other place. Move the code there
instead of keeping this xen-specific define in sysemu.h.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/xenpv/xen_machine_pv.c | 2 +-
include/sysemu/sysemu.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c
index 3a8af1a1e0..8df575a457 100644
--- a/hw/xenpv/xen_machine_pv.c
+++ b/hw/xenpv/xen_machine_pv.c
@@ -60,7 +60,7 @@ static void xen_init_pv(MachineState *machine)
xen_be_register("qnic", &xen_netdev_ops);
/* configure framebuffer */
- if (xenfb_enabled) {
+ if (vga_interface_type == VGA_XENFB) {
xen_config_dev_vfb(0, "vnc");
xen_config_dev_vkbd(0);
}
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 80c57fdc4e..2ccf216158 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -32,7 +32,6 @@ typedef enum {
} VGAInterfaceType;
extern int vga_interface_type;
-#define xenfb_enabled (vga_interface_type == VGA_XENFB)
extern int graphic_width;
extern int graphic_height;
--
2.18.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Xen-devel] [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h
@ 2020-01-21 16:17 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-01-21 16:17 UTC (permalink / raw)
To: qemu-devel, Stefano Stabellini, Anthony Perard, Paul Durrant
Cc: qemu-trivial, xen-devel
The define is only used in one other place. Move the code there
instead of keeping this xen-specific define in sysemu.h.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/xenpv/xen_machine_pv.c | 2 +-
include/sysemu/sysemu.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c
index 3a8af1a1e0..8df575a457 100644
--- a/hw/xenpv/xen_machine_pv.c
+++ b/hw/xenpv/xen_machine_pv.c
@@ -60,7 +60,7 @@ static void xen_init_pv(MachineState *machine)
xen_be_register("qnic", &xen_netdev_ops);
/* configure framebuffer */
- if (xenfb_enabled) {
+ if (vga_interface_type == VGA_XENFB) {
xen_config_dev_vfb(0, "vnc");
xen_config_dev_vkbd(0);
}
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index 80c57fdc4e..2ccf216158 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -32,7 +32,6 @@ typedef enum {
} VGAInterfaceType;
extern int vga_interface_type;
-#define xenfb_enabled (vga_interface_type == VGA_XENFB)
extern int graphic_width;
extern int graphic_height;
--
2.18.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h
2020-01-21 16:17 ` [Xen-devel] " Thomas Huth
@ 2020-01-21 16:41 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-21 16:41 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Stefano Stabellini, Anthony Perard,
Paul Durrant
Cc: qemu-trivial, xen-devel
On 1/21/20 5:17 PM, Thomas Huth wrote:
> The define is only used in one other place. Move the code there
> instead of keeping this xen-specific define in sysemu.h.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/xenpv/xen_machine_pv.c | 2 +-
> include/sysemu/sysemu.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c
> index 3a8af1a1e0..8df575a457 100644
> --- a/hw/xenpv/xen_machine_pv.c
> +++ b/hw/xenpv/xen_machine_pv.c
> @@ -60,7 +60,7 @@ static void xen_init_pv(MachineState *machine)
> xen_be_register("qnic", &xen_netdev_ops);
>
> /* configure framebuffer */
> - if (xenfb_enabled) {
> + if (vga_interface_type == VGA_XENFB) {
> xen_config_dev_vfb(0, "vnc");
> xen_config_dev_vkbd(0);
> }
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 80c57fdc4e..2ccf216158 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -32,7 +32,6 @@ typedef enum {
> } VGAInterfaceType;
>
> extern int vga_interface_type;
> -#define xenfb_enabled (vga_interface_type == VGA_XENFB)
>
> extern int graphic_width;
> extern int graphic_height;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h
@ 2020-01-21 16:41 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-01-21 16:41 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Stefano Stabellini, Anthony Perard,
Paul Durrant
Cc: qemu-trivial, xen-devel
On 1/21/20 5:17 PM, Thomas Huth wrote:
> The define is only used in one other place. Move the code there
> instead of keeping this xen-specific define in sysemu.h.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/xenpv/xen_machine_pv.c | 2 +-
> include/sysemu/sysemu.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/xenpv/xen_machine_pv.c b/hw/xenpv/xen_machine_pv.c
> index 3a8af1a1e0..8df575a457 100644
> --- a/hw/xenpv/xen_machine_pv.c
> +++ b/hw/xenpv/xen_machine_pv.c
> @@ -60,7 +60,7 @@ static void xen_init_pv(MachineState *machine)
> xen_be_register("qnic", &xen_netdev_ops);
>
> /* configure framebuffer */
> - if (xenfb_enabled) {
> + if (vga_interface_type == VGA_XENFB) {
> xen_config_dev_vfb(0, "vnc");
> xen_config_dev_vkbd(0);
> }
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 80c57fdc4e..2ccf216158 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -32,7 +32,6 @@ typedef enum {
> } VGAInterfaceType;
>
> extern int vga_interface_type;
> -#define xenfb_enabled (vga_interface_type == VGA_XENFB)
>
> extern int graphic_width;
> extern int graphic_height;
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h
2020-01-21 16:17 ` [Xen-devel] " Thomas Huth
@ 2020-01-21 16:59 ` Paul Durrant
-1 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2020-01-21 16:59 UTC (permalink / raw)
To: Thomas Huth
Cc: Anthony Perard, qemu-trivial, Stefano Stabellini,
open list:All patches CC here, xen-devel
On Tue, 21 Jan 2020 at 16:18, Thomas Huth <thuth@redhat.com> wrote:
>
> The define is only used in one other place. Move the code there
> instead of keeping this xen-specific define in sysemu.h.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Paul Durrant <paul@xen.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Xen-devel] [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h
@ 2020-01-21 16:59 ` Paul Durrant
0 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2020-01-21 16:59 UTC (permalink / raw)
To: Thomas Huth
Cc: Anthony Perard, qemu-trivial, Stefano Stabellini,
open list:All patches CC here, xen-devel
On Tue, 21 Jan 2020 at 16:18, Thomas Huth <thuth@redhat.com> wrote:
>
> The define is only used in one other place. Move the code there
> instead of keeping this xen-specific define in sysemu.h.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Paul Durrant <paul@xen.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-21 17:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 16:17 [Qemu-devel] [PATCH] trivial: Remove xenfb_enabled from sysemu.h Thomas Huth
2020-01-21 16:17 ` [Xen-devel] " Thomas Huth
2020-01-21 16:41 ` Philippe Mathieu-Daudé
2020-01-21 16:41 ` [Xen-devel] " Philippe Mathieu-Daudé
2020-01-21 16:59 ` Paul Durrant
2020-01-21 16:59 ` [Xen-devel] " Paul Durrant
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.