* [PATCH] counter: 104-quad-8: Return error when invalid mode during ceiling_write
@ 2021-06-10 1:29 William Breathitt Gray
2021-06-20 15:38 ` Syed Nayyar Waris
0 siblings, 1 reply; 2+ messages in thread
From: William Breathitt Gray @ 2021-06-10 1:29 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, linux-kernel, William Breathitt Gray, Syed Nayyar Waris
The 104-QUAD-8 only has two count modes where a ceiling value makes
sense: Range Limit and Modulo-N. Outside of these two modes, setting a
ceiling value is an invalid operation -- so let's report it as such by
returning -EINVAL.
Fixes: fc069262261c ("counter: 104-quad-8: Add lock guards - generic interface")
Cc: Syed Nayyar Waris <syednwaris@gmail.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/counter/104-quad-8.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index 09a9a77cce06..81f9642777fb 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -715,12 +715,13 @@ static ssize_t quad8_count_ceiling_write(struct counter_device *counter,
case 1:
case 3:
quad8_preset_register_set(priv, count->id, ceiling);
- break;
+ mutex_unlock(&priv->lock);
+ return len;
}
mutex_unlock(&priv->lock);
- return len;
+ return -EINVAL;
}
static ssize_t quad8_count_preset_enable_read(struct counter_device *counter,
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] counter: 104-quad-8: Return error when invalid mode during ceiling_write
2021-06-10 1:29 [PATCH] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray
@ 2021-06-20 15:38 ` Syed Nayyar Waris
0 siblings, 0 replies; 2+ messages in thread
From: Syed Nayyar Waris @ 2021-06-20 15:38 UTC (permalink / raw)
To: William Breathitt Gray
Cc: Jonathan Cameron, linux-iio, Linux Kernel Mailing List
On Thu, Jun 10, 2021 at 6:59 AM William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
>
> The 104-QUAD-8 only has two count modes where a ceiling value makes
> sense: Range Limit and Modulo-N. Outside of these two modes, setting a
> ceiling value is an invalid operation -- so let's report it as such by
> returning -EINVAL.
>
> Fixes: fc069262261c ("counter: 104-quad-8: Add lock guards - generic interface")
> Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
> drivers/counter/104-quad-8.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 09a9a77cce06..81f9642777fb 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -715,12 +715,13 @@ static ssize_t quad8_count_ceiling_write(struct counter_device *counter,
> case 1:
> case 3:
> quad8_preset_register_set(priv, count->id, ceiling);
> - break;
> + mutex_unlock(&priv->lock);
> + return len;
> }
>
> mutex_unlock(&priv->lock);
>
> - return len;
> + return -EINVAL;
> }
>
> static ssize_t quad8_count_preset_enable_read(struct counter_device *counter,
> --
> 2.32.0
>
Acked-by: Syed Nayyar Waris <syednwaris@gmail.com>
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-20 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 1:29 [PATCH] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray
2021-06-20 15:38 ` Syed Nayyar Waris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.