All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khazhy Kumykov <khazhy@google.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RESEND][RFC PATCH] blkcg: rewind seq_file if no stats
Date: Mon, 16 May 2022 23:27:09 -0700	[thread overview]
Message-ID: <CACGdZYLJjLyKHSSuTJH3_++NufsjDGjdz4vZwj0GKSiYQEvWpA@mail.gmail.com> (raw)
In-Reply-To: <20220517061238.GB4789@lst.de>

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

On Mon, May 16, 2022 at 11:12 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Fri, May 13, 2022 at 10:40:30AM -0700, Khazhismel Kumykov wrote:
> > Restores the previous behavior of only displaying devices for which we
> > have statistics (and removes the current, broken, behavior of printing
> > devname with no newline if no statistics)
> >
> > In lieu of get_seq_buf + seq_commit, provide a way to "undo" writes if
> > we use seq_printf
>
> I have to say I much prefer the simpler fix from Wolfgang.  But
Wolfgang's fix still results in a change in behavior, and in my
opinion a worse behavior - we don't need to print out the device names
if there are no stats.

> if we want to go down this route it needs to split into a patch
> for the seq_file infrastruture and a separate one for the blk-cgroup
> code.
Of course - I can spin this into a series if we think it's worthwhile

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3999 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Khazhy Kumykov <khazhy-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	Alexander Viro
	<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RESEND][RFC PATCH] blkcg: rewind seq_file if no stats
Date: Mon, 16 May 2022 23:27:09 -0700	[thread overview]
Message-ID: <CACGdZYLJjLyKHSSuTJH3_++NufsjDGjdz4vZwj0GKSiYQEvWpA@mail.gmail.com> (raw)
In-Reply-To: <20220517061238.GB4789-jcswGhMUV9g@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On Mon, May 16, 2022 at 11:12 PM Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
>
> On Fri, May 13, 2022 at 10:40:30AM -0700, Khazhismel Kumykov wrote:
> > Restores the previous behavior of only displaying devices for which we
> > have statistics (and removes the current, broken, behavior of printing
> > devname with no newline if no statistics)
> >
> > In lieu of get_seq_buf + seq_commit, provide a way to "undo" writes if
> > we use seq_printf
>
> I have to say I much prefer the simpler fix from Wolfgang.  But
Wolfgang's fix still results in a change in behavior, and in my
opinion a worse behavior - we don't need to print out the device names
if there are no stats.

> if we want to go down this route it needs to split into a patch
> for the seq_file infrastruture and a separate one for the blk-cgroup
> code.
Of course - I can spin this into a series if we think it's worthwhile

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3999 bytes --]

  reply	other threads:[~2022-05-17  6:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12 22:42 Issue with 252c651a4c85 ("blk-cgroup: stop using seq_get_buf") Khazhy Kumykov
2022-05-12 22:42 ` Khazhy Kumykov
2022-05-12 23:25 ` Khazhy Kumykov
2022-05-12 23:29   ` [RFC PATCH] blkcg: rewind seq_file if no stats Khazhismel Kumykov
2022-05-13 16:30     ` Tejun Heo
2022-05-13 17:40   ` [RESEND][RFC " Khazhismel Kumykov
2022-05-13 18:06     ` Khazhy Kumykov
2022-05-13 18:06       ` Khazhy Kumykov
2022-05-17  6:12     ` Christoph Hellwig
2022-05-17  6:27       ` Khazhy Kumykov [this message]
2022-05-17  6:27         ` Khazhy Kumykov
2022-05-17  6:11 ` Issue with 252c651a4c85 ("blk-cgroup: stop using seq_get_buf") Christoph Hellwig
2022-05-17  6:11   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACGdZYLJjLyKHSSuTJH3_++NufsjDGjdz4vZwj0GKSiYQEvWpA@mail.gmail.com \
    --to=khazhy@google.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.