From: Jason Wang <jasowang@redhat.com> To: "Eugenio Pérez" <eperezma@redhat.com> Cc: Parav Pandit <parav@mellanox.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, virtualization <virtualization@lists.linux-foundation.org>, Stefan Hajnoczi <stefanha@redhat.com>, Eli Cohen <eli@mellanox.com> Subject: Re: [PATCH v2 2/3] vdpa: Add vhost_vdpa_section_end Date: Tue, 12 Oct 2021 11:46:21 +0800 [thread overview] Message-ID: <CACGkMEt3CtrOpbGMpoJ-OcgXM84UzwpugC3EAj_oGxukvNgk8A@mail.gmail.com> (raw) In-Reply-To: <20211005134843.439050-3-eperezma@redhat.com> On Tue, Oct 5, 2021 at 9:49 PM Eugenio Pérez <eperezma@redhat.com> wrote: > > Abstract this operation, that will be reused when validating the region > against the iova range that the device supports. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > hw/virtio/vhost-vdpa.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c > index ea1aa71ad8..be7c63b4ba 100644 > --- a/hw/virtio/vhost-vdpa.c > +++ b/hw/virtio/vhost-vdpa.c > @@ -24,6 +24,19 @@ > #include "trace.h" > #include "qemu-common.h" > > +/* > + * Return one past the end of the end of section. Be careful with uint64_t > + * conversions! > + */ > +static Int128 vhost_vdpa_section_end(const MemoryRegionSection *section) > +{ > + Int128 llend = int128_make64(section->offset_within_address_space); > + llend = int128_add(llend, section->size); > + llend = int128_and(llend, int128_exts64(TARGET_PAGE_MASK)); > + > + return llend; > +} > + > static bool vhost_vdpa_listener_skipped_section(MemoryRegionSection *section) > { > return (!memory_region_is_ram(section->mr) && > @@ -160,10 +173,7 @@ static void vhost_vdpa_listener_region_add(MemoryListener *listener, > } > > iova = TARGET_PAGE_ALIGN(section->offset_within_address_space); > - llend = int128_make64(section->offset_within_address_space); > - llend = int128_add(llend, section->size); > - llend = int128_and(llend, int128_exts64(TARGET_PAGE_MASK)); > - > + llend = vhost_vdpa_section_end(section); > if (int128_ge(int128_make64(iova), llend)) { > return; > } > @@ -221,9 +231,7 @@ static void vhost_vdpa_listener_region_del(MemoryListener *listener, > } > > iova = TARGET_PAGE_ALIGN(section->offset_within_address_space); > - llend = int128_make64(section->offset_within_address_space); > - llend = int128_add(llend, section->size); > - llend = int128_and(llend, int128_exts64(TARGET_PAGE_MASK)); > + llend = vhost_vdpa_section_end(section); > > trace_vhost_vdpa_listener_region_del(v, iova, int128_get64(llend)); > > -- > 2.27.0 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: "Eugenio Pérez" <eperezma@redhat.com> Cc: Parav Pandit <parav@mellanox.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, virtualization <virtualization@lists.linux-foundation.org>, Stefan Hajnoczi <stefanha@redhat.com>, Eli Cohen <eli@mellanox.com>, Stefano Garzarella <sgarzare@redhat.com> Subject: Re: [PATCH v2 2/3] vdpa: Add vhost_vdpa_section_end Date: Tue, 12 Oct 2021 11:46:21 +0800 [thread overview] Message-ID: <CACGkMEt3CtrOpbGMpoJ-OcgXM84UzwpugC3EAj_oGxukvNgk8A@mail.gmail.com> (raw) In-Reply-To: <20211005134843.439050-3-eperezma@redhat.com> On Tue, Oct 5, 2021 at 9:49 PM Eugenio Pérez <eperezma@redhat.com> wrote: > > Abstract this operation, that will be reused when validating the region > against the iova range that the device supports. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> > --- > hw/virtio/vhost-vdpa.c | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c > index ea1aa71ad8..be7c63b4ba 100644 > --- a/hw/virtio/vhost-vdpa.c > +++ b/hw/virtio/vhost-vdpa.c > @@ -24,6 +24,19 @@ > #include "trace.h" > #include "qemu-common.h" > > +/* > + * Return one past the end of the end of section. Be careful with uint64_t > + * conversions! > + */ > +static Int128 vhost_vdpa_section_end(const MemoryRegionSection *section) > +{ > + Int128 llend = int128_make64(section->offset_within_address_space); > + llend = int128_add(llend, section->size); > + llend = int128_and(llend, int128_exts64(TARGET_PAGE_MASK)); > + > + return llend; > +} > + > static bool vhost_vdpa_listener_skipped_section(MemoryRegionSection *section) > { > return (!memory_region_is_ram(section->mr) && > @@ -160,10 +173,7 @@ static void vhost_vdpa_listener_region_add(MemoryListener *listener, > } > > iova = TARGET_PAGE_ALIGN(section->offset_within_address_space); > - llend = int128_make64(section->offset_within_address_space); > - llend = int128_add(llend, section->size); > - llend = int128_and(llend, int128_exts64(TARGET_PAGE_MASK)); > - > + llend = vhost_vdpa_section_end(section); > if (int128_ge(int128_make64(iova), llend)) { > return; > } > @@ -221,9 +231,7 @@ static void vhost_vdpa_listener_region_del(MemoryListener *listener, > } > > iova = TARGET_PAGE_ALIGN(section->offset_within_address_space); > - llend = int128_make64(section->offset_within_address_space); > - llend = int128_add(llend, section->size); > - llend = int128_and(llend, int128_exts64(TARGET_PAGE_MASK)); > + llend = vhost_vdpa_section_end(section); > > trace_vhost_vdpa_listener_region_del(v, iova, int128_get64(llend)); > > -- > 2.27.0 >
next prev parent reply other threads:[~2021-10-12 3:46 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 13:48 [PATCH v2 0/3] vdpa: Check iova range on memory regions ops Eugenio Pérez 2021-10-05 13:48 ` [PATCH v2 1/3] vdpa: Skip protected ram IOMMU mappings Eugenio Pérez 2021-10-12 3:45 ` Jason Wang 2021-10-12 3:45 ` Jason Wang 2021-10-05 13:48 ` [PATCH v2 2/3] vdpa: Add vhost_vdpa_section_end Eugenio Pérez 2021-10-12 3:46 ` Jason Wang [this message] 2021-10-12 3:46 ` Jason Wang 2021-10-05 13:48 ` [PATCH v2 3/3] vdpa: Check for iova range at mappings changes Eugenio Pérez 2021-10-12 3:50 ` Jason Wang 2021-10-12 3:50 ` Jason Wang 2021-10-12 6:27 ` Eugenio Perez Martin 2021-10-12 6:44 ` Jason Wang 2021-10-12 6:44 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACGkMEt3CtrOpbGMpoJ-OcgXM84UzwpugC3EAj_oGxukvNgk8A@mail.gmail.com \ --to=jasowang@redhat.com \ --cc=eli@mellanox.com \ --cc=eperezma@redhat.com \ --cc=mst@redhat.com \ --cc=parav@mellanox.com \ --cc=qemu-devel@nongnu.org \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.