From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com> Cc: virtualization <virtualization@lists.linux-foundation.org>, "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, "Eugenio Pérez" <eperezma@redhat.com> Subject: Re: [RFC PATCH 0/6] virtio_test: add support for vhost-vdpa Date: Tue, 12 Jul 2022 16:47:10 +0800 [thread overview] Message-ID: <CACGkMEtHg_EVYcS=Qxsmwq3t+96E8LNqa5Ck1Gi4hJs2AJ0F+Q@mail.gmail.com> (raw) In-Reply-To: <20220712084544.lgtggj44ihlkfsb3@sgarzare-redhat> On Tue, Jul 12, 2022 at 4:46 PM Stefano Garzarella <sgarzare@redhat.com> wrote: > > On Tue, Jul 12, 2022 at 04:34:11PM +0800, Jason Wang wrote: > > > >在 2022/7/5 01:16, Stefano Garzarella 写道: > >>The first 3 patches fix various problems I have encountered with > >>virtio_test (they may go without this series, but I included to allow you > >>to test the series). > >> > >>Patch 4 is in preparation of patch 5, moving the feature negotiation when > >>we initialize the device. > >> > >>Patch 5 add the support of vhost-vdpa in virtio_test > >> > >>Patch 6 add vdpa_test.ko based on vdpa_sim_test.c, so we can reuse most of > >>the code coming from the vdpa_sim framework. > >> > >>I tested in this way: > >> > >> $ modprobe vdpa_sim > >> $ modprobe vhost-vdpa > >> > >> # load the vdpasim_test device > >> $ insmod vdpa_test.ko > >> > >> # create a new vdpasim_test device > >> $ vdpa dev add mgmtdev vdpasim_test name dev0 > > > > > >I wonder what's the benefit of using a dedicated test device other > >than networking? (already a loopback device anyhow). > > > > The main advantage I was thinking is that we can extend it at will to > try to cover as much as possible all the paths that maybe with net we > can't (indirect, reset, etc.). > > Plus it should be easier to test vhost-vdpa this way without using QEMU. > > Do you think this is redundant? It's probably fine and it might be better to describe the reason in the changelog. THanks > > Thanks, > Stefano >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com> Cc: "Eugenio Pérez" <eperezma@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org> Subject: Re: [RFC PATCH 0/6] virtio_test: add support for vhost-vdpa Date: Tue, 12 Jul 2022 16:47:10 +0800 [thread overview] Message-ID: <CACGkMEtHg_EVYcS=Qxsmwq3t+96E8LNqa5Ck1Gi4hJs2AJ0F+Q@mail.gmail.com> (raw) In-Reply-To: <20220712084544.lgtggj44ihlkfsb3@sgarzare-redhat> On Tue, Jul 12, 2022 at 4:46 PM Stefano Garzarella <sgarzare@redhat.com> wrote: > > On Tue, Jul 12, 2022 at 04:34:11PM +0800, Jason Wang wrote: > > > >在 2022/7/5 01:16, Stefano Garzarella 写道: > >>The first 3 patches fix various problems I have encountered with > >>virtio_test (they may go without this series, but I included to allow you > >>to test the series). > >> > >>Patch 4 is in preparation of patch 5, moving the feature negotiation when > >>we initialize the device. > >> > >>Patch 5 add the support of vhost-vdpa in virtio_test > >> > >>Patch 6 add vdpa_test.ko based on vdpa_sim_test.c, so we can reuse most of > >>the code coming from the vdpa_sim framework. > >> > >>I tested in this way: > >> > >> $ modprobe vdpa_sim > >> $ modprobe vhost-vdpa > >> > >> # load the vdpasim_test device > >> $ insmod vdpa_test.ko > >> > >> # create a new vdpasim_test device > >> $ vdpa dev add mgmtdev vdpasim_test name dev0 > > > > > >I wonder what's the benefit of using a dedicated test device other > >than networking? (already a loopback device anyhow). > > > > The main advantage I was thinking is that we can extend it at will to > try to cover as much as possible all the paths that maybe with net we > can't (indirect, reset, etc.). > > Plus it should be easier to test vhost-vdpa this way without using QEMU. > > Do you think this is redundant? It's probably fine and it might be better to describe the reason in the changelog. THanks > > Thanks, > Stefano > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-07-12 8:47 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-04 17:16 [RFC PATCH 0/6] virtio_test: add support for vhost-vdpa Stefano Garzarella 2022-07-04 17:16 ` Stefano Garzarella 2022-07-04 17:16 ` [RFC PATCH 1/6] tools/virtio: fix build Stefano Garzarella 2022-07-04 17:16 ` Stefano Garzarella 2022-07-04 19:07 ` Michael S. Tsirkin 2022-07-04 19:07 ` Michael S. Tsirkin 2022-07-05 7:14 ` Stefano Garzarella 2022-07-05 7:14 ` Stefano Garzarella 2022-07-04 17:16 ` [RFC PATCH 2/6] vhost_test: add $(srctree) on the included path Stefano Garzarella 2022-07-04 17:16 ` Stefano Garzarella 2022-07-04 17:16 ` [RFC PATCH 3/6] virtio_test: call __virtio_unbreak_device Stefano Garzarella 2022-07-04 17:16 ` Stefano Garzarella 2022-07-04 19:06 ` Michael S. Tsirkin 2022-07-04 19:06 ` Michael S. Tsirkin 2022-07-05 7:11 ` Stefano Garzarella 2022-07-05 7:11 ` Stefano Garzarella 2022-07-04 17:16 ` [RFC PATCH 4/6] tools/virtio: move feature negotiation in vdev_info_init() Stefano Garzarella 2022-07-04 17:16 ` Stefano Garzarella 2022-07-04 17:17 ` [RFC PATCH 5/6] virtio_test: support vhost-vdpa device Stefano Garzarella 2022-07-04 17:17 ` Stefano Garzarella 2022-07-04 17:17 ` [RFC PATCH 6/6] vdpasim: add vdpa_sim_test module Stefano Garzarella 2022-07-04 17:17 ` Stefano Garzarella 2022-07-12 8:34 ` [RFC PATCH 0/6] virtio_test: add support for vhost-vdpa Jason Wang 2022-07-12 8:34 ` Jason Wang 2022-07-12 8:45 ` Stefano Garzarella 2022-07-12 8:45 ` Stefano Garzarella 2022-07-12 8:47 ` Jason Wang [this message] 2022-07-12 8:47 ` Jason Wang 2022-07-12 9:20 ` Stefano Garzarella 2022-07-12 9:20 ` Stefano Garzarella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACGkMEtHg_EVYcS=Qxsmwq3t+96E8LNqa5Ck1Gi4hJs2AJ0F+Q@mail.gmail.com' \ --to=jasowang@redhat.com \ --cc=eperezma@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=sgarzare@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.