From: Jason Wang <jasowang@redhat.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: xieyongji@bytedance.com, mst@redhat.com, david.marchand@redhat.com, lulu@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, xuanzhuo@linux.alibaba.com, eperezma@redhat.com Subject: Re: [PATCH v1 2/2] vduse: enable Virtio-net device type Date: Wed, 28 Jun 2023 10:34:55 +0800 [thread overview] Message-ID: <CACGkMEuKyeFoaAfVfBKMv43sdX7GQDQyDLO-+eukg29t+0Ef0g@mail.gmail.com> (raw) In-Reply-To: <20230627113652.65283-3-maxime.coquelin@redhat.com> On Tue, Jun 27, 2023 at 7:37 PM Maxime Coquelin <maxime.coquelin@redhat.com> wrote: > > This patch adds Virtio-net device type to the supported > devices types. Initialization fails if the device does > not support VIRTIO_F_VERSION_1 feature, in order to > guarantee the configuration space is read-only. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Thanks > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index c1c2f4c711ae..89088fa27026 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -142,6 +142,7 @@ static struct workqueue_struct *vduse_irq_bound_wq; > > static u32 allowed_device_id[] = { > VIRTIO_ID_BLOCK, > + VIRTIO_ID_NET, > }; > > static inline struct vduse_dev *vdpa_to_vduse(struct vdpa_device *vdpa) > @@ -1668,6 +1669,10 @@ static bool features_is_valid(struct vduse_dev_config *config) > (config->features & (1ULL << VIRTIO_BLK_F_CONFIG_WCE))) > return false; > > + if ((config->device_id == VIRTIO_ID_NET) && > + !(config->features & (1ULL << VIRTIO_F_VERSION_1))) > + return false; > + > return true; > } > > @@ -2023,6 +2028,7 @@ static const struct vdpa_mgmtdev_ops vdpa_dev_mgmtdev_ops = { > > static struct virtio_device_id id_table[] = { > { VIRTIO_ID_BLOCK, VIRTIO_DEV_ANY_ID }, > + { VIRTIO_ID_NET, VIRTIO_DEV_ANY_ID }, > { 0 }, > }; > > -- > 2.41.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: xuanzhuo@linux.alibaba.com, lulu@redhat.com, mst@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, xieyongji@bytedance.com, eperezma@redhat.com, david.marchand@redhat.com Subject: Re: [PATCH v1 2/2] vduse: enable Virtio-net device type Date: Wed, 28 Jun 2023 10:34:55 +0800 [thread overview] Message-ID: <CACGkMEuKyeFoaAfVfBKMv43sdX7GQDQyDLO-+eukg29t+0Ef0g@mail.gmail.com> (raw) In-Reply-To: <20230627113652.65283-3-maxime.coquelin@redhat.com> On Tue, Jun 27, 2023 at 7:37 PM Maxime Coquelin <maxime.coquelin@redhat.com> wrote: > > This patch adds Virtio-net device type to the supported > devices types. Initialization fails if the device does > not support VIRTIO_F_VERSION_1 feature, in order to > guarantee the configuration space is read-only. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Thanks > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index c1c2f4c711ae..89088fa27026 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -142,6 +142,7 @@ static struct workqueue_struct *vduse_irq_bound_wq; > > static u32 allowed_device_id[] = { > VIRTIO_ID_BLOCK, > + VIRTIO_ID_NET, > }; > > static inline struct vduse_dev *vdpa_to_vduse(struct vdpa_device *vdpa) > @@ -1668,6 +1669,10 @@ static bool features_is_valid(struct vduse_dev_config *config) > (config->features & (1ULL << VIRTIO_BLK_F_CONFIG_WCE))) > return false; > > + if ((config->device_id == VIRTIO_ID_NET) && > + !(config->features & (1ULL << VIRTIO_F_VERSION_1))) > + return false; > + > return true; > } > > @@ -2023,6 +2028,7 @@ static const struct vdpa_mgmtdev_ops vdpa_dev_mgmtdev_ops = { > > static struct virtio_device_id id_table[] = { > { VIRTIO_ID_BLOCK, VIRTIO_DEV_ANY_ID }, > + { VIRTIO_ID_NET, VIRTIO_DEV_ANY_ID }, > { 0 }, > }; > > -- > 2.41.0 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-06-28 2:36 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-27 11:36 [PATCH v1 0/2] vduse: add support for networking devices Maxime Coquelin 2023-06-27 11:36 ` Maxime Coquelin 2023-06-27 11:36 ` [PATCH v1 1/2] vduse: validate block features only with block devices Maxime Coquelin 2023-06-27 11:36 ` Maxime Coquelin 2023-06-28 2:34 ` Jason Wang 2023-06-28 2:34 ` Jason Wang 2023-07-02 7:49 ` Yongji Xie 2023-06-27 11:36 ` [PATCH v1 2/2] vduse: enable Virtio-net device type Maxime Coquelin 2023-06-27 11:36 ` Maxime Coquelin 2023-06-28 2:34 ` Jason Wang [this message] 2023-06-28 2:34 ` Jason Wang 2023-07-02 7:50 ` Yongji Xie 2023-07-02 13:37 ` [PATCH v1 0/2] vduse: add support for networking devices Michael S. Tsirkin 2023-07-02 13:37 ` Michael S. Tsirkin 2023-07-03 6:44 ` Jason Wang 2023-07-03 6:44 ` Jason Wang 2023-07-03 7:43 ` Maxime Coquelin 2023-07-03 7:43 ` Maxime Coquelin 2023-07-03 7:44 ` Jason Wang 2023-07-03 7:44 ` Jason Wang 2023-07-03 21:45 ` Michael S. Tsirkin 2023-07-03 21:45 ` Michael S. Tsirkin 2023-07-04 8:43 ` Maxime Coquelin 2023-07-04 8:43 ` Maxime Coquelin 2023-07-04 9:59 ` Michael S. Tsirkin 2023-07-04 9:59 ` Michael S. Tsirkin 2023-07-04 13:17 ` Maxime Coquelin 2023-07-04 13:17 ` Maxime Coquelin 2023-08-10 19:02 ` Michael S. Tsirkin 2023-08-10 19:02 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACGkMEuKyeFoaAfVfBKMv43sdX7GQDQyDLO-+eukg29t+0Ef0g@mail.gmail.com \ --to=jasowang@redhat.com \ --cc=david.marchand@redhat.com \ --cc=eperezma@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=xieyongji@bytedance.com \ --cc=xuanzhuo@linux.alibaba.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.