From: Jason Wang <jasowang@redhat.com> To: Paolo Abeni <pabeni@redhat.com> Cc: netdev <netdev@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, kvm <kvm@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org> Subject: Re: [PATCH] vhost_net: fix OoB on sendmsg() failure. Date: Thu, 9 Sep 2021 10:52:59 +0800 [thread overview] Message-ID: <CACGkMEvTBt3WSJnxvGN0-gsZNXE1eRqx4ZV7X+d9gar1VfwArA@mail.gmail.com> (raw) In-Reply-To: <463c1b02ca6f65fc1183431d8d85ec8154a2c28e.1631090797.git.pabeni@redhat.com> On Wed, Sep 8, 2021 at 7:42 PM Paolo Abeni <pabeni@redhat.com> wrote: > > If the sendmsg() call in vhost_tx_batch() fails, both the 'batched_xdp' > and 'done_idx' indexes are left unchanged. If such failure happens > when batched_xdp == VHOST_NET_BATCH, the next call to > vhost_net_build_xdp() will access and write memory outside the xdp > buffers area. > > Since sendmsg() can only error with EBADFD, this change addresses the > issue explicitly freeing the XDP buffers batch on error. > > Fixes: 0a0be13b8fe2 ("vhost_net: batch submitting XDP buffers to underlayer sockets") > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- > Note: my understanding is that this should go through MST's tree, please > educate me otherwise, thanks! > --- Acked-by: Jason Wang <jasowang@redhat.com> Thanks! > drivers/vhost/net.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 3a249ee7e144..28ef323882fb 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -467,7 +467,7 @@ static void vhost_tx_batch(struct vhost_net *net, > .num = nvq->batched_xdp, > .ptr = nvq->xdp, > }; > - int err; > + int i, err; > > if (nvq->batched_xdp == 0) > goto signal_used; > @@ -476,6 +476,15 @@ static void vhost_tx_batch(struct vhost_net *net, > err = sock->ops->sendmsg(sock, msghdr, 0); > if (unlikely(err < 0)) { > vq_err(&nvq->vq, "Fail to batch sending packets\n"); > + > + /* free pages owned by XDP; since this is an unlikely error path, > + * keep it simple and avoid more complex bulk update for the > + * used pages > + */ > + for (i = 0; i < nvq->batched_xdp; ++i) > + put_page(virt_to_head_page(nvq->xdp[i].data)); > + nvq->batched_xdp = 0; > + nvq->done_idx = 0; > return; > } > > -- > 2.26.3 >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Paolo Abeni <pabeni@redhat.com> Cc: netdev <netdev@vger.kernel.org>, virtualization <virtualization@lists.linux-foundation.org>, kvm <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com> Subject: Re: [PATCH] vhost_net: fix OoB on sendmsg() failure. Date: Thu, 9 Sep 2021 10:52:59 +0800 [thread overview] Message-ID: <CACGkMEvTBt3WSJnxvGN0-gsZNXE1eRqx4ZV7X+d9gar1VfwArA@mail.gmail.com> (raw) In-Reply-To: <463c1b02ca6f65fc1183431d8d85ec8154a2c28e.1631090797.git.pabeni@redhat.com> On Wed, Sep 8, 2021 at 7:42 PM Paolo Abeni <pabeni@redhat.com> wrote: > > If the sendmsg() call in vhost_tx_batch() fails, both the 'batched_xdp' > and 'done_idx' indexes are left unchanged. If such failure happens > when batched_xdp == VHOST_NET_BATCH, the next call to > vhost_net_build_xdp() will access and write memory outside the xdp > buffers area. > > Since sendmsg() can only error with EBADFD, this change addresses the > issue explicitly freeing the XDP buffers batch on error. > > Fixes: 0a0be13b8fe2 ("vhost_net: batch submitting XDP buffers to underlayer sockets") > Suggested-by: Jason Wang <jasowang@redhat.com> > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- > Note: my understanding is that this should go through MST's tree, please > educate me otherwise, thanks! > --- Acked-by: Jason Wang <jasowang@redhat.com> Thanks! > drivers/vhost/net.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 3a249ee7e144..28ef323882fb 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -467,7 +467,7 @@ static void vhost_tx_batch(struct vhost_net *net, > .num = nvq->batched_xdp, > .ptr = nvq->xdp, > }; > - int err; > + int i, err; > > if (nvq->batched_xdp == 0) > goto signal_used; > @@ -476,6 +476,15 @@ static void vhost_tx_batch(struct vhost_net *net, > err = sock->ops->sendmsg(sock, msghdr, 0); > if (unlikely(err < 0)) { > vq_err(&nvq->vq, "Fail to batch sending packets\n"); > + > + /* free pages owned by XDP; since this is an unlikely error path, > + * keep it simple and avoid more complex bulk update for the > + * used pages > + */ > + for (i = 0; i < nvq->batched_xdp; ++i) > + put_page(virt_to_head_page(nvq->xdp[i].data)); > + nvq->batched_xdp = 0; > + nvq->done_idx = 0; > return; > } > > -- > 2.26.3 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-09-09 2:53 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-08 11:42 [PATCH] vhost_net: fix OoB on sendmsg() failure Paolo Abeni 2021-09-08 11:42 ` Paolo Abeni 2021-09-09 2:52 ` Jason Wang [this message] 2021-09-09 2:52 ` Jason Wang 2021-09-09 10:00 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACGkMEvTBt3WSJnxvGN0-gsZNXE1eRqx4ZV7X+d9gar1VfwArA@mail.gmail.com \ --to=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.