[PATCH net-next] bnxt: lower log priority of hwrm message to info

[PATCH net-next] bnxt: lower log priority of hwrm message to info

[Jonathan Toppins]

  bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm
req_type 0x190 seq id 0x6 error 0xffff

The message above is commonly seen when a newer driver is used on
hardware with older firmware. The issue is this message means nothing to
anyone except Broadcom. Reduce the message priority to info to not
confuse users as this message is really informative in nature.

Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 5d21c14853ac..796cb0b139dc 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -3880,9 +3880,9 @@ static int bnxt_hwrm_do_send_msg(struct bnxt *bp, void *msg, u32 msg_len,
 	*valid = 0;
 	rc = le16_to_cpu(resp->error_code);
 	if (rc && !silent)
-		netdev_err(bp->dev, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n",
-			   le16_to_cpu(resp->req_type),
-			   le16_to_cpu(resp->seq_id), rc);
+		netdev_info(bp->dev, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n",
+			    le16_to_cpu(resp->req_type),
+			    le16_to_cpu(resp->seq_id), rc);
 	return rc;
 }
 
-- 
2.16.4

Re: [PATCH net-next] bnxt: lower log priority of hwrm message to info

[Michael Chan]

On Tue, Dec 11, 2018 at 11:23 AM Jonathan Toppins <jtoppins@redhat.com> wrote:
>
>   bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm
> req_type 0x190 seq id 0x6 error 0xffff
>
> The message above is commonly seen when a newer driver is used on
> hardware with older firmware. The issue is this message means nothing to
> anyone except Broadcom. Reduce the message priority to info to not
> confuse users as this message is really informative in nature.
>
> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 5d21c14853ac..796cb0b139dc 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -3880,9 +3880,9 @@ static int bnxt_hwrm_do_send_msg(struct bnxt *bp, void *msg, u32 msg_len,
>         *valid = 0;
>         rc = le16_to_cpu(resp->error_code);
>         if (rc && !silent)
> -               netdev_err(bp->dev, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n",
> -                          le16_to_cpu(resp->req_type),
> -                          le16_to_cpu(resp->seq_id), rc);
> +               netdev_info(bp->dev, "hwrm req_type 0x%x seq id 0x%x error 0x%x\n",
> +                           le16_to_cpu(resp->req_type),
> +                           le16_to_cpu(resp->seq_id), rc);
>         return rc;
>  }
>

I prefer to fix it by calling _hwrm_send_message_silent() for that
particular message, which is known to be rejected harmlessly by some
older firmware.  Please let me know if you want to send the patch or
you want me to send the patch.  Thanks.

[PATCH net-next] bnxt: remove printing of hwrm message

[Jonathan Toppins]

  bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm
req_type 0x190 seq id 0x6 error 0xffff

The message above is commonly seen when a newer driver is used on
hardware with older firmware. The issue is this message means nothing to
anyone except Broadcom. Remove the message to not confuse users as this
message is really not very informative.

Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
---

Notes:
    v2:
      include changes recommended by Michael Chan

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 5d21c14853ac..f4f29939ba72 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -6190,7 +6190,8 @@ int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp, bool all)
 	req.fid = cpu_to_le16(0xffff);
 
 	mutex_lock(&bp->hwrm_cmd_lock);
-	rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT);
+	rc = _hwrm_send_message_silent(bp, &req, sizeof(req),
+				       HWRM_CMD_TIMEOUT);
 	if (rc) {
 		rc = -EIO;
 		goto hwrm_func_resc_qcaps_exit;
-- 
2.16.4

Re: [PATCH net-next] bnxt: remove printing of hwrm message

[Michael Chan]

On Wed, Dec 12, 2018 at 8:59 AM Jonathan Toppins <jtoppins@redhat.com> wrote:
>
>   bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm
> req_type 0x190 seq id 0x6 error 0xffff
>
> The message above is commonly seen when a newer driver is used on
> hardware with older firmware. The issue is this message means nothing to
> anyone except Broadcom. Remove the message to not confuse users as this
> message is really not very informative.
>
> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
> ---
>
> Notes:
>     v2:
>       include changes recommended by Michael Chan
>

Acked-by: Michael Chan <michael.chan@broadcom.com>

Re: [PATCH net-next] bnxt: remove printing of hwrm message

[David Miller]

From: Jonathan Toppins <jtoppins@redhat.com>
Date: Wed, 12 Dec 2018 11:58:51 -0500

>   bnxt_en 0000:19:00.0 (unregistered net_device) (uninitialized): hwrm
> req_type 0x190 seq id 0x6 error 0xffff
> 
> The message above is commonly seen when a newer driver is used on
> hardware with older firmware. The issue is this message means nothing to
> anyone except Broadcom. Remove the message to not confuse users as this
> message is really not very informative.
> 
> Signed-off-by: Jonathan Toppins <jtoppins@redhat.com>
> ---
> 
> Notes:
>     v2:
>       include changes recommended by Michael Chan

Applied, thank you.