All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Chan <michael.chan@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sathya Perla <sathya.perla@broadcom.com>,
	Netdev <netdev@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
Date: Wed, 6 Dec 2017 11:16:55 -0800	[thread overview]
Message-ID: <CACKFLinE9vWuooML4RhZHN0Xo2yr4cB90hEwizdEP3U6DLaoFA@mail.gmail.com> (raw)
In-Reply-To: <20171205143752.cymsw7fzlqn6ejeq@mwanda>

On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Smatch warns that:
>
>     drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
>     error: uninitialized symbol 'rc'.
>
> "rc" is either uninitialized or set to zero here so we can just remove
> the check.
>
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks.

Acked-by: Michael Chan <michael.chan@broadcom.com>

WARNING: multiple messages have this Message-ID (diff)
From: Michael Chan <michael.chan@broadcom.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sathya Perla <sathya.perla@broadcom.com>,
	Netdev <netdev@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions()
Date: Wed, 06 Dec 2017 19:16:55 +0000	[thread overview]
Message-ID: <CACKFLinE9vWuooML4RhZHN0Xo2yr4cB90hEwizdEP3U6DLaoFA@mail.gmail.com> (raw)
In-Reply-To: <20171205143752.cymsw7fzlqn6ejeq@mwanda>

On Tue, Dec 5, 2017 at 6:37 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Smatch warns that:
>
>     drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:160 bnxt_tc_parse_actions()
>     error: uninitialized symbol 'rc'.
>
> "rc" is either uninitialized or set to zero here so we can just remove
> the check.
>
> Fixes: 8c95f773b4a3 ("bnxt_en: add support for Flower based vxlan encap/decap offload")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks.

Acked-by: Michael Chan <michael.chan@broadcom.com>

  parent reply	other threads:[~2017-12-06 19:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 14:37 [PATCH] bnxt_en: Uninitialized variable in bnxt_tc_parse_actions() Dan Carpenter
2017-12-05 14:37 ` Dan Carpenter
2017-12-05 14:43 ` Dan Carpenter
2017-12-05 14:43   ` Dan Carpenter
2017-12-06 19:00 ` David Miller
2017-12-06 19:00   ` David Miller
2017-12-06 19:16 ` Michael Chan [this message]
2017-12-06 19:16   ` Michael Chan
2017-12-06 19:25   ` David Miller
2017-12-06 19:25     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACKFLinE9vWuooML4RhZHN0Xo2yr4cB90hEwizdEP3U6DLaoFA@mail.gmail.com \
    --to=michael.chan@broadcom.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.