* [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
@ 2016-06-26 19:45 Vidya Sagar Ravipati
2016-06-27 16:51 ` David Decotigny
2016-07-24 5:57 ` Yuval Mintz
0 siblings, 2 replies; 8+ messages in thread
From: Vidya Sagar Ravipati @ 2016-06-26 19:45 UTC (permalink / raw)
To: ben, netdev, bwh, davem, decot
Cc: bkenward, daniel, galp, roopa, gospo, dustin
From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
Enhancing link mode bits to support 25G/50G/100G
for supported and advertised speed mode bits
Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
---
ethtool.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/ethtool.c b/ethtool.c
index 1d6564e..5c3c765 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -512,6 +512,15 @@ static void init_global_link_mode_masks(void)
ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT,
ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT,
ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
+ ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
+ ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
+ ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
+ ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
};
static const enum ethtool_link_mode_bit_indices
additional_advertised_flags_bits[] = {
@@ -632,6 +641,24 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
"56000baseSR4/Full" },
{ 0, ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
"56000baseLR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
+ "25000baseCR/Full" },
+ { 0, ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
+ "25000baseKR/Full" },
+ { 0, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
+ "25000baseSR/Full" },
+ { 0, ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
+ "50000baseCR2/Full" },
+ { 0, ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
+ "50000baseKR2/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
+ "100000baseKR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
+ "100000baseSR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
+ "100000baseCR4/Full" },
+ { 0, ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
+ "100000baseLR4_ER4/Full" },
};
int indent;
int did1, new_line_pend, i;
--
2.1.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
2016-06-26 19:45 [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G Vidya Sagar Ravipati
@ 2016-06-27 16:51 ` David Decotigny
2016-07-24 5:57 ` Yuval Mintz
1 sibling, 0 replies; 8+ messages in thread
From: David Decotigny @ 2016-06-27 16:51 UTC (permalink / raw)
To: Vidya Sagar Ravipati
Cc: Ben Hutchings, netdev, Ben Hutchings, David S. Miller, bkenward,
daniel, Gal Pressman, roopa, gospo, dustin
On Sun, Jun 26, 2016 at 12:45 PM, Vidya Sagar Ravipati
<vidya@cumulusnetworks.com> wrote:
> From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
>
> Enhancing link mode bits to support 25G/50G/100G
> for supported and advertised speed mode bits
>
> Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
> ---
> ethtool.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/ethtool.c b/ethtool.c
> index 1d6564e..5c3c765 100644
> --- a/ethtool.c
> +++ b/ethtool.c
> @@ -512,6 +512,15 @@ static void init_global_link_mode_masks(void)
> ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT,
> ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT,
> ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
> + ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
> + ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
> + ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
> + ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
> + ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
> + ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
> };
> static const enum ethtool_link_mode_bit_indices
> additional_advertised_flags_bits[] = {
> @@ -632,6 +641,24 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
> "56000baseSR4/Full" },
> { 0, ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT,
> "56000baseLR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_25000baseCR_Full_BIT,
> + "25000baseCR/Full" },
> + { 0, ETHTOOL_LINK_MODE_25000baseKR_Full_BIT,
> + "25000baseKR/Full" },
> + { 0, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT,
> + "25000baseSR/Full" },
> + { 0, ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT,
> + "50000baseCR2/Full" },
> + { 0, ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT,
> + "50000baseKR2/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT,
> + "100000baseKR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT,
> + "100000baseSR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT,
> + "100000baseCR4/Full" },
> + { 0, ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT,
> + "100000baseLR4_ER4/Full" },
> };
> int indent;
> int did1, new_line_pend, i;
> --
> 2.1.4
>
Acked-By: David Decotigny <decot@googlers.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
2016-06-26 19:45 [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G Vidya Sagar Ravipati
2016-06-27 16:51 ` David Decotigny
@ 2016-07-24 5:57 ` Yuval Mintz
2016-07-24 9:12 ` Vidya Sagar Ravipati
[not found] ` <CAKWE-XqpkNprFcQj7wZEthmTTtDuU7657kjFP37EvrgCChncHw@mail.gmail.com>
1 sibling, 2 replies; 8+ messages in thread
From: Yuval Mintz @ 2016-07-24 5:57 UTC (permalink / raw)
To: Vidya Sagar Ravipati, ben, netdev, bwh, David Miller, decot, linville
Cc: bkenward, daniel, galp, roopa, gospo, dustin
> Enhancing link mode bits to support 25G/50G/100G for supported and
> advertised speed mode bits
>
> Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
> ---
> ethtool.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
Hi Vidya,
Are you re-trying your series one anytime soon?
If not, can we simply push this [and ethtool-copy.h], as those are needed
for querying/setting the recently added new speeds.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
2016-07-24 5:57 ` Yuval Mintz
@ 2016-07-24 9:12 ` Vidya Sagar Ravipati
[not found] ` <CAKWE-XqpkNprFcQj7wZEthmTTtDuU7657kjFP37EvrgCChncHw@mail.gmail.com>
1 sibling, 0 replies; 8+ messages in thread
From: Vidya Sagar Ravipati @ 2016-07-24 9:12 UTC (permalink / raw)
To: Yuval Mintz
Cc: ben, netdev, bwh, David Miller, decot, linville, bkenward,
daniel, galp, roopa, gospo, dustin
Yuval,
I will try to resubmit the patches this week with updated comments
Thanks
Vidya Sagar
On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz <Yuval.Mintz@qlogic.com> wrote:
>> Enhancing link mode bits to support 25G/50G/100G for supported and
>> advertised speed mode bits
>>
>> Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
>> ---
>> ethtool.c | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>
> Hi Vidya,
>
> Are you re-trying your series one anytime soon?
>
> If not, can we simply push this [and ethtool-copy.h], as those are needed
> for querying/setting the recently added new speeds.
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
[not found] ` <CAKWE-XqpkNprFcQj7wZEthmTTtDuU7657kjFP37EvrgCChncHw@mail.gmail.com>
@ 2016-08-02 19:49 ` John W. Linville
2016-08-18 18:21 ` John W. Linville
0 siblings, 1 reply; 8+ messages in thread
From: John W. Linville @ 2016-08-02 19:49 UTC (permalink / raw)
To: Vidya Sagar Ravipati
Cc: Yuval Mintz, ben, netdev, bwh, David Miller, decot, bkenward,
daniel, galp, roopa, gospo, dustin
Are these revised patches still on their way?
John
On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote:
> Yuval,
> I will try to resubmit the patches this week with updated comments
>
> Thanks
> Vidya Sagar
>
> On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz <Yuval.Mintz@qlogic.com>
> wrote:
>
> > > Enhancing link mode bits to support 25G/50G/100G for supported and
> > > advertised speed mode bits
> > >
> > > Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
> > > ---
> > > ethtool.c | 27 +++++++++++++++++++++++++++
> > > 1 file changed, 27 insertions(+)
> >
> > Hi Vidya,
> >
> > Are you re-trying your series one anytime soon?
> >
> > If not, can we simply push this [and ethtool-copy.h], as those are needed
> > for querying/setting the recently added new speeds.
> >
> >
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
2016-08-02 19:49 ` John W. Linville
@ 2016-08-18 18:21 ` John W. Linville
2016-08-21 14:44 ` Yuval Mintz
0 siblings, 1 reply; 8+ messages in thread
From: John W. Linville @ 2016-08-18 18:21 UTC (permalink / raw)
To: Vidya Sagar Ravipati
Cc: Yuval Mintz, ben, netdev, bwh, David Miller, decot, bkenward,
daniel, galp, roopa, gospo, dustin
Ping?
On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote:
> Are these revised patches still on their way?
>
> John
>
> On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote:
> > Yuval,
> > I will try to resubmit the patches this week with updated comments
> >
> > Thanks
> > Vidya Sagar
> >
> > On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz <Yuval.Mintz@qlogic.com>
> > wrote:
> >
> > > > Enhancing link mode bits to support 25G/50G/100G for supported and
> > > > advertised speed mode bits
> > > >
> > > > Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
> > > > ---
> > > > ethtool.c | 27 +++++++++++++++++++++++++++
> > > > 1 file changed, 27 insertions(+)
> > >
> > > Hi Vidya,
> > >
> > > Are you re-trying your series one anytime soon?
> > >
> > > If not, can we simply push this [and ethtool-copy.h], as those are needed
> > > for querying/setting the recently added new speeds.
> > >
> > >
>
> --
> John W. Linville Someday the world will need a hero, and you
> linville@tuxdriver.com might be all we have. Be ready.
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
2016-08-18 18:21 ` John W. Linville
@ 2016-08-21 14:44 ` Yuval Mintz
2016-08-21 15:39 ` Michael Chan
0 siblings, 1 reply; 8+ messages in thread
From: Yuval Mintz @ 2016-08-21 14:44 UTC (permalink / raw)
To: John W. Linville, Vidya Sagar Ravipati
Cc: ben, netdev, bwh, David Miller, decot, bkenward, daniel, galp,
roopa, gospo, dustin
> Ping?
>
> On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote:
> > Are these revised patches still on their way?
> >
> > John
> >
> > On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote:
> > > Yuval,
> > > I will try to resubmit the patches this week with updated
> > > comments
> > >
> > > Thanks
> > > Vidya Sagar
I can pick this up; But I'd need someone to fill me on which of the newer
speeds could support autoneg [if any].
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G
2016-08-21 14:44 ` Yuval Mintz
@ 2016-08-21 15:39 ` Michael Chan
0 siblings, 0 replies; 8+ messages in thread
From: Michael Chan @ 2016-08-21 15:39 UTC (permalink / raw)
To: Yuval Mintz
Cc: John W. Linville, Vidya Sagar Ravipati, ben, netdev, bwh,
David Miller, decot, bkenward, daniel, galp, roopa, gospo,
dustin
On Sun, Aug 21, 2016 at 7:44 AM, Yuval Mintz <Yuval.Mintz@qlogic.com> wrote:
>> Ping?
>>
>> On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote:
>> > Are these revised patches still on their way?
>> >
>> > John
>> >
>> > On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote:
>> > > Yuval,
>> > > I will try to resubmit the patches this week with updated
>> > > comments
>> > >
>> > > Thanks
>> > > Vidya Sagar
>
> I can pick this up; But I'd need someone to fill me on which of the newer
> speeds could support autoneg [if any].
All of the new speeds support autoneg as far as I know.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-08-21 15:39 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-26 19:45 [ethtool PATCH v2 4/4] ethtool: Enhancing link mode bits to support 25G/50G/100G Vidya Sagar Ravipati
2016-06-27 16:51 ` David Decotigny
2016-07-24 5:57 ` Yuval Mintz
2016-07-24 9:12 ` Vidya Sagar Ravipati
[not found] ` <CAKWE-XqpkNprFcQj7wZEthmTTtDuU7657kjFP37EvrgCChncHw@mail.gmail.com>
2016-08-02 19:49 ` John W. Linville
2016-08-18 18:21 ` John W. Linville
2016-08-21 14:44 ` Yuval Mintz
2016-08-21 15:39 ` Michael Chan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.