All of lore.kernel.org
 help / color / mirror / Atom feed
From: javier Martin <javier.martin@vista-silicon.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-media@vger.kernel.org, linux@arm.linux.org.uk,
	mchehab@infradead.org, kernel@pengutronix.de,
	u.kleine-koenig@pengutronix.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.
Date: Mon, 26 Mar 2012 14:56:19 +0200	[thread overview]
Message-ID: <CACKLOr0abquyZ2bZMnq8pXTL8BXqzN_izK92hdA=gPJ6dBsTdA@mail.gmail.com> (raw)
In-Reply-To: <20120326121023.GD18420@sapphire.tkos.co.il>

On 26 March 2012 14:10, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Javier,
>
> On Mon, Mar 26, 2012 at 01:20:04PM +0200, Javier Martin wrote:
>>
>> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
>> ---
>>  arch/arm/mach-imx/mach-imx27_visstrim_m10.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
>> index 3128cfe..4db00c6 100644
>> --- a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
>> +++ b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
>> @@ -164,7 +164,7 @@ static struct platform_device visstrim_tvp5150 = {
>>
>>
>>  static struct mx2_camera_platform_data visstrim_camera = {
>> -     .flags = MX2_CAMERA_CCIR | MX2_CAMERA_CCIR_INTERLACE | MX2_CAMERA_SWAP16 | MX2_CAMERA_PCLK_SAMPLE_RISING,
>> +     .flags = MX2_CAMERA_CCIR | MX2_CAMERA_CCIR_INTERLACE | MX2_CAMERA_PCLK_SAMPLE_RISING,
>>       .clk = 100000,
>>  };
>
> The order of the last two patches in this series should be switched to
> preserve bisectability.
>
> baruch

You are right.
Thanks.

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com

WARNING: multiple messages have this Message-ID (diff)
From: javier.martin@vista-silicon.com (javier Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16.
Date: Mon, 26 Mar 2012 14:56:19 +0200	[thread overview]
Message-ID: <CACKLOr0abquyZ2bZMnq8pXTL8BXqzN_izK92hdA=gPJ6dBsTdA@mail.gmail.com> (raw)
In-Reply-To: <20120326121023.GD18420@sapphire.tkos.co.il>

On 26 March 2012 14:10, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Javier,
>
> On Mon, Mar 26, 2012 at 01:20:04PM +0200, Javier Martin wrote:
>>
>> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
>> ---
>> ?arch/arm/mach-imx/mach-imx27_visstrim_m10.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
>> index 3128cfe..4db00c6 100644
>> --- a/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
>> +++ b/arch/arm/mach-imx/mach-imx27_visstrim_m10.c
>> @@ -164,7 +164,7 @@ static struct platform_device visstrim_tvp5150 = {
>>
>>
>> ?static struct mx2_camera_platform_data visstrim_camera = {
>> - ? ? .flags = MX2_CAMERA_CCIR | MX2_CAMERA_CCIR_INTERLACE | MX2_CAMERA_SWAP16 | MX2_CAMERA_PCLK_SAMPLE_RISING,
>> + ? ? .flags = MX2_CAMERA_CCIR | MX2_CAMERA_CCIR_INTERLACE | MX2_CAMERA_PCLK_SAMPLE_RISING,
>> ? ? ? .clk = 100000,
>> ?};
>
> The order of the last two patches in this series should be switched to
> preserve bisectability.
>
> baruch

You are right.
Thanks.

-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com

  reply	other threads:[~2012-03-26 12:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-26 11:20 [PATCH 0/3] media: tvp5150: Fix mbus format to UYUV instead of YUYV Javier Martin
2012-03-26 11:20 ` Javier Martin
2012-03-26 11:20 ` [PATCH 1/3] media: tvp5150: Fix mbus format Javier Martin
2012-03-26 11:20   ` Javier Martin
2012-03-26 11:20 ` [PATCH 2/3] media: mx2_camera: Fix mbus format handling Javier Martin
2012-03-26 11:20   ` Javier Martin
2012-03-26 11:20 ` [PATCH 3/3] i.MX27: visstrim_m10: Remove use of MX2_CAMERA_SWAP16 Javier Martin
2012-03-26 11:20   ` Javier Martin
2012-03-26 12:10   ` Baruch Siach
2012-03-26 12:10     ` Baruch Siach
2012-03-26 12:56     ` javier Martin [this message]
2012-03-26 12:56       ` javier Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACKLOr0abquyZ2bZMnq8pXTL8BXqzN_izK92hdA=gPJ6dBsTdA@mail.gmail.com' \
    --to=javier.martin@vista-silicon.com \
    --cc=baruch@tkos.co.il \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mchehab@infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.