[PATCH] tzset.3: ffix

[PATCH] tzset.3: ffix

[Jakub Wilk]

Use \- for minus sign

Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
---
 man3/tzset.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/tzset.3 b/man3/tzset.3
index c80da53f8..694cd0ea9 100644
--- a/man3/tzset.3
+++ b/man3/tzset.3
@@ -111,7 +111,7 @@ There are no spaces in the specification.
 The \fIstd\fP string specifies an abbreviation for the timezone and must be
 three or more alphabetic characters.
 When enclosed between the less-than (<) and greater-than (>) signs, the
-characters set is expanded to include the plus (+) sign, the minus (-)
+characters set is expanded to include the plus (+) sign, the minus (\-)
 sign, and digits.
 The \fIoffset\fP string immediately
 follows \fIstd\fP and specifies the time value to be added to the local
-- 
2.33.0

Re: [PATCH] tzset.3: ffix

[Alejandro Colomar (man-pages)]

Hello Jakub!

On 10/7/21 11:09 AM, Jakub Wilk wrote:
> Use \- for minus sign
> 
> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>

Patch applied!

Thanks,

Alex

> ---
>   man3/tzset.3 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man3/tzset.3 b/man3/tzset.3
> index c80da53f8..694cd0ea9 100644
> --- a/man3/tzset.3
> +++ b/man3/tzset.3
> @@ -111,7 +111,7 @@ There are no spaces in the specification.
>   The \fIstd\fP string specifies an abbreviation for the timezone and must be
>   three or more alphabetic characters.
>   When enclosed between the less-than (<) and greater-than (>) signs, the
> -characters set is expanded to include the plus (+) sign, the minus (-)
> +characters set is expanded to include the plus (+) sign, the minus (\-)
>   sign, and digits.
>   The \fIoffset\fP string immediately
>   follows \fIstd\fP and specifies the time value to be added to the local
> 


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

Re: [PATCH] tzset.3: ffix

[Stefan Puiu]

Hi Jakub and Alex,

One quick question:

On Thu, Oct 7, 2021 at 12:16 PM Jakub Wilk <jwilk@jwilk.net> wrote:
>
> Use \- for minus sign
>
> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
> ---
>  man3/tzset.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/tzset.3 b/man3/tzset.3
> index c80da53f8..694cd0ea9 100644
> --- a/man3/tzset.3
> +++ b/man3/tzset.3
> @@ -111,7 +111,7 @@ There are no spaces in the specification.
>  The \fIstd\fP string specifies an abbreviation for the timezone and must be
>  three or more alphabetic characters.
>  When enclosed between the less-than (<) and greater-than (>) signs, the
> -characters set is expanded to include the plus (+) sign, the minus (-)
> +characters set is expanded to include the plus (+) sign, the minus (\-)

Shouldn't this be 'character set'?

Thanks,
Stefan.

>  sign, and digits.
>  The \fIoffset\fP string immediately
>  follows \fIstd\fP and specifies the time value to be added to the local
> --
> 2.33.0
>

Re: [PATCH] tzset.3: ffix

[Alejandro Colomar (man-pages)]

Hi Stefan,

On 10/7/21 9:46 PM, Stefan Puiu wrote:
> Hi Jakub and Alex,
> 
> One quick question:
> 
> On Thu, Oct 7, 2021 at 12:16 PM Jakub Wilk <jwilk@jwilk.net> wrote:
>>
>> Use \- for minus sign
>>
>> Signed-off-by: Jakub Wilk <jwilk@jwilk.net>
>> ---
>>   man3/tzset.3 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/man3/tzset.3 b/man3/tzset.3
>> index c80da53f8..694cd0ea9 100644
>> --- a/man3/tzset.3
>> +++ b/man3/tzset.3
>> @@ -111,7 +111,7 @@ There are no spaces in the specification.
>>   The \fIstd\fP string specifies an abbreviation for the timezone and must be
>>   three or more alphabetic characters.
>>   When enclosed between the less-than (<) and greater-than (>) signs, the
>> -characters set is expanded to include the plus (+) sign, the minus (-)
>> +characters set is expanded to include the plus (+) sign, the minus (\-)
> 
> Shouldn't this be 'character set'?

Yes, 'character' is acting as an adjective there, and should be singular.

Fixed.

Thanks,

Alex

---
     tzset.3: tfix

     Reported-by: Stefan Puiu <stefan.puiu@gmail.com>
     Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

diff --git a/man3/tzset.3 b/man3/tzset.3
index 694cd0ea9..4fea98628 100644
--- a/man3/tzset.3
+++ b/man3/tzset.3
@@ -111,7 +111,7 @@ There are no spaces in the specification.
  The \fIstd\fP string specifies an abbreviation for the timezone and 
must be
  three or more alphabetic characters.
  When enclosed between the less-than (<) and greater-than (>) signs, the
-characters set is expanded to include the plus (+) sign, the minus (\-)
+character set is expanded to include the plus (+) sign, the minus (\-)
  sign, and digits.
  The \fIoffset\fP string immediately
  follows \fIstd\fP and specifies the time value to be added to the local


-- 
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/

Re: [PATCH] tzset.3: ffix

[Michael Kerrisk (man-pages)]

Hi Alex,

On 5/10/21 9:39 AM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

Applied.

Thanks,

Michael


> ---
>  man3/tzset.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/man3/tzset.3 b/man3/tzset.3
> index e4660be8b..c80da53f8 100644
> --- a/man3/tzset.3
> +++ b/man3/tzset.3
> @@ -37,7 +37,7 @@ tzset, tzname, timezone, daylight \- initialize time conversion information
>  .nf
>  .B #include <time.h>
>  .PP
> -.B void tzset (void);
> +.B void tzset(void);
>  .PP
>  .BI "extern char *" tzname [2];
>  .BI "extern long " timezone ;
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/

[PATCH] tzset.3: ffix

[Alejandro Colomar]

Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
 man3/tzset.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/tzset.3 b/man3/tzset.3
index e4660be8b..c80da53f8 100644
--- a/man3/tzset.3
+++ b/man3/tzset.3
@@ -37,7 +37,7 @@ tzset, tzname, timezone, daylight \- initialize time conversion information
 .nf
 .B #include <time.h>
 .PP
-.B void tzset (void);
+.B void tzset(void);
 .PP
 .BI "extern char *" tzname [2];
 .BI "extern long " timezone ;
-- 
2.31.1

Re: [PATCH] tzset.3: ffix

[Michael Kerrisk (man-pages)]

On 02/16/2015 06:12 PM, J William Piggott wrote:
> Signed-off-by: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>

Thanks, James. Applied.

Cheers,

Michael


> ---
>  man3/tzset.3 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/man3/tzset.3 b/man3/tzset.3
> index cfb2d4c..a1e11ce 100644
> --- a/man3/tzset.3
> +++ b/man3/tzset.3
> @@ -188,13 +188,13 @@ If this variable is set its value takes precedence over the system
>  configured timezone database directory path.
>  .SH FILES
>  .TP
> -.B /etc/localtime
> +.I /etc/localtime
>  The system timezone file.
>  .TP
> -.B /usr/share/zoneinfo/
> +.I /usr/share/zoneinfo/
>  The system timezone database directory.
>  .TP
> -.B /usr/share/zoneinfo/posixrules
> +.I /usr/share/zoneinfo/posixrules
>  When a TZ string includes a dst timezone without anything following it,
>  then this file is used for the start/end rules.
>  It is in the
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] tzset.3: ffix

[J William Piggott]

Signed-off-by: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>
---
 man3/tzset.3 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/man3/tzset.3 b/man3/tzset.3
index cfb2d4c..a1e11ce 100644
--- a/man3/tzset.3
+++ b/man3/tzset.3
@@ -188,13 +188,13 @@ If this variable is set its value takes precedence over the system
 configured timezone database directory path.
 .SH FILES
 .TP
-.B /etc/localtime
+.I /etc/localtime
 The system timezone file.
 .TP
-.B /usr/share/zoneinfo/
+.I /usr/share/zoneinfo/
 The system timezone database directory.
 .TP
-.B /usr/share/zoneinfo/posixrules
+.I /usr/share/zoneinfo/posixrules
 When a TZ string includes a dst timezone without anything following it,
 then this file is used for the start/end rules.
 It is in the
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tzset.3: ffix

[Michael Kerrisk (man-pages)]

Hi Willliam,

On 02/02/2015 10:16 PM, J William Piggott wrote:
> Hello Michael,
> 
> On 02/02/2015 01:39 AM, Michael Kerrisk (man-pages) wrote:
>> Hi William,
>>
>> On 1 February 2015 at 21:25, J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org> wrote:
>>>
>>> Fix tzset.3 regression, dst is optional.
>>>
>>> $ date
>>> Sun Feb  1 15:14:33 EST 2015
>>> $ TZ=NZST-12 date
>>> Mon Feb  2 08:14:38 NZST 2015
>>> $ TZ=EST5 date
>>> Sun Feb  1 15:15:02 EST 2015
>>>
>>> Signed-off-by: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>
>>> ---
>>>  man3/tzset.3 | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/man3/tzset.3 b/man3/tzset.3
>>> index 1253241..7a4dd6a 100644
>>> --- a/man3/tzset.3
>>> +++ b/man3/tzset.3
>>> @@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
>>>  timezone to be used:
>>>  .sp
>>>  .RS
>>> -.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
>>> +.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
>>>  .RE
>>>  .sp
>>>  There are no spaces in the specification.
>>
>> Thanks, I've applied this, and then also made some more changes to
>> bring make that line a bit more consistent with formatting norm in man
>> pages.
> 
> My thinking regarding the format, was that because so much of the string 
> is optional, contrasting the compulsory part makes it easier to parse. 
> Did you look at how it rendered before changing it? It also highlights
> that portion as unique, as it is illustrated with a space that does not 
> exist when put into use; that is not true for the rest of the string. I 
> think it is good to have it standout. I would have made it bold, but that
> is for commands and might have been confusing.
> 
> Well, it is better now either-way compared to the whole thing being italic
> as it was before.

I made the format this way mainly for overall consistency. The '[]' should
be enough for folk to work out what's optional.

Thanks,

Michael



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tzset.3: ffix

[J William Piggott]

Hello Michael,

On 02/02/2015 01:39 AM, Michael Kerrisk (man-pages) wrote:
> Hi William,
> 
> On 1 February 2015 at 21:25, J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org> wrote:
>>
>> Fix tzset.3 regression, dst is optional.
>>
>> $ date
>> Sun Feb  1 15:14:33 EST 2015
>> $ TZ=NZST-12 date
>> Mon Feb  2 08:14:38 NZST 2015
>> $ TZ=EST5 date
>> Sun Feb  1 15:15:02 EST 2015
>>
>> Signed-off-by: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>
>> ---
>>  man3/tzset.3 | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/man3/tzset.3 b/man3/tzset.3
>> index 1253241..7a4dd6a 100644
>> --- a/man3/tzset.3
>> +++ b/man3/tzset.3
>> @@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
>>  timezone to be used:
>>  .sp
>>  .RS
>> -.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
>> +.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
>>  .RE
>>  .sp
>>  There are no spaces in the specification.
> 
> Thanks, I've applied this, and then also made some more changes to
> bring make that line a bit more consistent with formatting norm in man
> pages.

My thinking regarding the format, was that because so much of the string 
is optional, contrasting the compulsory part makes it easier to parse. 
Did you look at how it rendered before changing it? It also highlights
that portion as unique, as it is illustrated with a space that does not 
exist when put into use; that is not true for the rest of the string. I 
think it is good to have it standout. I would have made it bold, but that
is for commands and might have been confusing.

Well, it is better now either-way compared to the whole thing being italic
as it was before.

Have a great day everyone.
 

> 
> Cheers,
> 
> Michael
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tzset.3: ffix

[Michael Kerrisk (man-pages)]

Hi William,

On 1 February 2015 at 21:25, J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org> wrote:
>
> Fix tzset.3 regression, dst is optional.
>
> $ date
> Sun Feb  1 15:14:33 EST 2015
> $ TZ=NZST-12 date
> Mon Feb  2 08:14:38 NZST 2015
> $ TZ=EST5 date
> Sun Feb  1 15:15:02 EST 2015
>
> Signed-off-by: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>
> ---
>  man3/tzset.3 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man3/tzset.3 b/man3/tzset.3
> index 1253241..7a4dd6a 100644
> --- a/man3/tzset.3
> +++ b/man3/tzset.3
> @@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
>  timezone to be used:
>  .sp
>  .RS
> -.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
> +.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
>  .RE
>  .sp
>  There are no spaces in the specification.

Thanks, I've applied this, and then also made some more changes to
bring make that line a bit more consistent with formatting norm in man
pages.

Cheers,

Michael

-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] tzset.3: ffix

[J William Piggott]

Fix tzset.3 regression, dst is optional.

$ date
Sun Feb  1 15:14:33 EST 2015
$ TZ=NZST-12 date
Mon Feb  2 08:14:38 NZST 2015
$ TZ=EST5 date
Sun Feb  1 15:15:02 EST 2015

Signed-off-by: J William Piggott <elseifthen-KK0ffGbhmjU@public.gmane.org>
---
 man3/tzset.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man3/tzset.3 b/man3/tzset.3
index 1253241..7a4dd6a 100644
--- a/man3/tzset.3
+++ b/man3/tzset.3
@@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
 timezone to be used:
 .sp
 .RS
-.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
+.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
 .RE
 .sp
 There are no spaces in the specification.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html