From: Kyle Evans <kevans91@ksu.edu>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
Russell King <linux@armlinux.org.uk>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t
Date: Thu, 21 Dec 2017 09:19:24 -0600 [thread overview]
Message-ID: <CACNAnaE9GiVTXD-TV1xXyBJKtTGKpdA6n0REk6a=qm218EgHbg@mail.gmail.com> (raw)
In-Reply-To: <20171221145512.llxvzkcrjpquhczi@flea.lan>
On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Kyle,
>
> On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote:
>> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and
>> thermal calibration data, add node to describe it.
>>
>> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is
>> supported in an external driver for FreeBSD.
>>
>> Signed-off-by: Kyle Evans <kevans91@ksu.edu>
>
> The patch looks fine in itself, but we've had a number of issues with
> the register layout (and access patterns) in the past, so I'd rather
> have something that works in Linux too if possible.
Hello!
I have a patch that I think should make it work fine on Linux [1], but
I'm afraid I have little to no capability to test it myself and so I
did not add it as well.
I do know that the rootkey is offset 0x200 into the given space [2],
as is the case with the H3, and that the readout quirk is not needed.
I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the
H3, but I do know that thermal data can be found at 0x34 and 0x38 in
this space.
[1] https://people.freebsd.org/~kevans/sunxi-sid.diff
[2] https://svnweb.freebsd.org/base/head/sys/arm/allwinner/aw_sid.c?view=markup#l56
WARNING: multiple messages have this Message-ID (diff)
From: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Srinivas Kandagatla
<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t
Date: Thu, 21 Dec 2017 09:19:24 -0600 [thread overview]
Message-ID: <CACNAnaE9GiVTXD-TV1xXyBJKtTGKpdA6n0REk6a=qm218EgHbg@mail.gmail.com> (raw)
In-Reply-To: <20171221145512.llxvzkcrjpquhczi-ZC1Zs529Oq4@public.gmane.org>
On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> Hi Kyle,
>
> On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91-OYTqUY/oFF8@public.gmane.org wrote:
>> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and
>> thermal calibration data, add node to describe it.
>>
>> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is
>> supported in an external driver for FreeBSD.
>>
>> Signed-off-by: Kyle Evans <kevans91-OYTqUY/oFF8@public.gmane.org>
>
> The patch looks fine in itself, but we've had a number of issues with
> the register layout (and access patterns) in the past, so I'd rather
> have something that works in Linux too if possible.
Hello!
I have a patch that I think should make it work fine on Linux [1], but
I'm afraid I have little to no capability to test it myself and so I
did not add it as well.
I do know that the rootkey is offset 0x200 into the given space [2],
as is the case with the H3, and that the readout quirk is not needed.
I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the
H3, but I do know that thermal data can be found at 0x34 and 0x38 in
this space.
[1] https://people.freebsd.org/~kevans/sunxi-sid.diff
[2] https://svnweb.freebsd.org/base/head/sys/arm/allwinner/aw_sid.c?view=markup#l56
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: kevans91@ksu.edu (Kyle Evans)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: sunxi: Add sid for a83t
Date: Thu, 21 Dec 2017 09:19:24 -0600 [thread overview]
Message-ID: <CACNAnaE9GiVTXD-TV1xXyBJKtTGKpdA6n0REk6a=qm218EgHbg@mail.gmail.com> (raw)
In-Reply-To: <20171221145512.llxvzkcrjpquhczi@flea.lan>
On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Kyle,
>
> On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91 at ksu.edu wrote:
>> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and
>> thermal calibration data, add node to describe it.
>>
>> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is
>> supported in an external driver for FreeBSD.
>>
>> Signed-off-by: Kyle Evans <kevans91@ksu.edu>
>
> The patch looks fine in itself, but we've had a number of issues with
> the register layout (and access patterns) in the past, so I'd rather
> have something that works in Linux too if possible.
Hello!
I have a patch that I think should make it work fine on Linux [1], but
I'm afraid I have little to no capability to test it myself and so I
did not add it as well.
I do know that the rootkey is offset 0x200 into the given space [2],
as is the case with the H3, and that the readout quirk is not needed.
I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the
H3, but I do know that thermal data can be found at 0x34 and 0x38 in
this space.
[1] https://people.freebsd.org/~kevans/sunxi-sid.diff
[2] https://svnweb.freebsd.org/base/head/sys/arm/allwinner/aw_sid.c?view=markup#l56
next prev parent reply other threads:[~2017-12-21 15:19 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 21:05 [PATCH v2] ARM: dts: sunxi: Add sid for a83t kevans91
2017-12-19 21:05 ` kevans91 at ksu.edu
2017-12-19 21:05 ` kevans91-OYTqUY/oFF8
2017-12-20 21:45 ` Rob Herring
2017-12-20 21:45 ` Rob Herring
2017-12-20 21:45 ` Rob Herring
2017-12-21 14:55 ` Maxime Ripard
2017-12-21 14:55 ` Maxime Ripard
2017-12-21 14:55 ` Maxime Ripard
2017-12-21 15:07 ` Icenowy Zheng
2017-12-21 15:19 ` Kyle Evans [this message]
2017-12-21 15:19 ` Kyle Evans
2017-12-21 15:19 ` Kyle Evans
2017-12-21 15:26 ` Maxime Ripard
2017-12-21 15:26 ` Maxime Ripard
2017-12-21 15:26 ` Maxime Ripard
2017-12-21 15:30 ` Kyle Evans
2017-12-21 15:30 ` Kyle Evans
2017-12-21 15:30 ` Kyle Evans
2017-12-21 15:39 ` Chen-Yu Tsai
2017-12-21 15:39 ` Chen-Yu Tsai
2017-12-21 18:09 ` Emmanuel Vadot
2017-12-21 18:09 ` Emmanuel Vadot
2017-12-21 18:09 ` Emmanuel Vadot
2017-12-22 8:35 ` Maxime Ripard
2017-12-22 8:35 ` Maxime Ripard
2017-12-22 8:35 ` Maxime Ripard
2017-12-22 10:07 ` Emmanuel Vadot
2017-12-22 10:07 ` Emmanuel Vadot
2017-12-22 10:07 ` Emmanuel Vadot
2017-12-22 10:11 ` Chen-Yu Tsai
2017-12-22 10:11 ` Chen-Yu Tsai
2018-01-04 14:01 ` Maxime Ripard
2018-01-04 14:01 ` Maxime Ripard
2018-01-04 14:01 ` Maxime Ripard
2018-01-08 15:30 ` Kyle Evans
2018-01-08 15:30 ` Kyle Evans
2018-01-08 15:30 ` Kyle Evans
2018-01-09 13:34 ` Maxime Ripard
2018-01-09 13:34 ` Maxime Ripard
2018-01-09 13:34 ` Maxime Ripard
2018-01-09 13:55 ` Kyle Evans
2018-01-09 13:55 ` Kyle Evans
2018-01-09 13:55 ` Kyle Evans
2018-04-18 14:05 ` Kyle Evans
2018-04-18 14:05 ` Kyle Evans
2018-04-18 14:05 ` Kyle Evans
2018-04-19 13:38 ` Maxime Ripard
2018-04-19 13:38 ` Maxime Ripard
2018-04-19 13:38 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACNAnaE9GiVTXD-TV1xXyBJKtTGKpdA6n0REk6a=qm218EgHbg@mail.gmail.com' \
--to=kevans91@ksu.edu \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.