All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karol Herbst <kherbst@redhat.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: David Airlie <airlied@linux.ie>,
	nouveau <nouveau@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc
Date: Fri, 19 Mar 2021 10:57:19 +0100	[thread overview]
Message-ID: <CACO55tvmj1-_ZcmLyN0tUdrH1QzN2c23-a+bDBXCKEOEsiak9g@mail.gmail.com> (raw)
In-Reply-To: <20210319082428.3294591-18-lee.jones@linaro.org>

On Fri, Mar 19, 2021 at 9:25 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand  * file mga_ioc32.c
>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> index adf01ca9e035d..8ddf9b2325a42 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
>   * \file mga_ioc32.c
>   *
>   * 32-bit ioctl compatibility routines for the MGA DRM.
> --
> 2.27.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

Reviewed-by: Karol Herbst <kherbst@redhat.com>


WARNING: multiple messages have this Message-ID (diff)
From: Karol Herbst <kherbst@redhat.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: David Airlie <airlied@linux.ie>,
	nouveau <nouveau@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [Nouveau] [PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc
Date: Fri, 19 Mar 2021 10:57:19 +0100	[thread overview]
Message-ID: <CACO55tvmj1-_ZcmLyN0tUdrH1QzN2c23-a+bDBXCKEOEsiak9g@mail.gmail.com> (raw)
In-Reply-To: <20210319082428.3294591-18-lee.jones@linaro.org>

On Fri, Mar 19, 2021 at 9:25 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand  * file mga_ioc32.c
>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> index adf01ca9e035d..8ddf9b2325a42 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
>   * \file mga_ioc32.c
>   *
>   * 32-bit ioctl compatibility routines for the MGA DRM.
> --
> 2.27.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

Reviewed-by: Karol Herbst <kherbst@redhat.com>

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

WARNING: multiple messages have this Message-ID (diff)
From: Karol Herbst <kherbst@redhat.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: David Airlie <airlied@linux.ie>,
	nouveau <nouveau@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc
Date: Fri, 19 Mar 2021 10:57:19 +0100	[thread overview]
Message-ID: <CACO55tvmj1-_ZcmLyN0tUdrH1QzN2c23-a+bDBXCKEOEsiak9g@mail.gmail.com> (raw)
In-Reply-To: <20210319082428.3294591-18-lee.jones@linaro.org>

On Fri, Mar 19, 2021 at 9:25 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand  * file mga_ioc32.c
>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/gpu/drm/nouveau/nouveau_ioc32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_ioc32.c b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> index adf01ca9e035d..8ddf9b2325a42 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_ioc32.c
> @@ -1,4 +1,4 @@
> -/**
> +/*
>   * \file mga_ioc32.c
>   *
>   * 32-bit ioctl compatibility routines for the MGA DRM.
> --
> 2.27.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

Reviewed-by: Karol Herbst <kherbst@redhat.com>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-03-19  9:58 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  8:24 [RESEND 00/19] Rid GPU from W=1 warnings Lee Jones
2021-03-19  8:24 ` Lee Jones
2021-03-19  8:24 ` Lee Jones
2021-03-19  8:24 ` [Nouveau] " Lee Jones
2021-03-19  8:24 ` [PATCH 01/19] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:54   ` Karol Herbst
2021-03-19  9:54     ` Karol Herbst
2021-03-19  9:54     ` [Nouveau] " Karol Herbst
2021-03-19  8:24 ` [PATCH 02/19] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  8:24 ` [PATCH 03/19] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24 ` [PATCH 04/19] include: drm: drm_atomic: Make use of 'new_plane_state' Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19 13:52   ` Ville Syrjälä
2021-03-19 13:52     ` Ville Syrjälä
2021-03-19  8:24 ` [PATCH 05/19] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:55   ` Karol Herbst
2021-03-19  9:55     ` Karol Herbst
2021-03-19  9:55     ` [Nouveau] " Karol Herbst
2021-03-19  8:24 ` [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19 18:13   ` Alex Deucher
2021-03-19 18:13     ` Alex Deucher
2021-03-19 18:13     ` Alex Deucher
2021-03-19 18:26     ` Harry Wentland
2021-03-19 18:26       ` Harry Wentland
2021-03-19 18:26       ` Harry Wentland
2021-03-19 18:31       ` Alex Deucher
2021-03-19 18:31         ` Alex Deucher
2021-03-19 18:31         ` Alex Deucher
2021-03-19 18:46       ` Christian König
2021-03-19 18:46         ` Christian König
2021-03-19 18:46         ` Christian König
2021-03-19 19:31         ` Alex Deucher
2021-03-19 19:31           ` Alex Deucher
2021-03-19 19:31           ` Alex Deucher
2021-03-19  8:24 ` [PATCH 07/19] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-20 20:38   ` kernel test robot
2021-03-20 20:39   ` [PATCH] drm/amd/display/dc/calcs/dce_calcs: fix noderef.cocci warnings kernel test robot
2021-03-19  8:24 ` [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19 18:24   ` Alex Deucher
2021-03-19 18:24     ` Alex Deucher
2021-03-19 18:24     ` Alex Deucher
2021-03-19 18:25   ` Harry Wentland
2021-03-19 18:25     ` Harry Wentland
2021-03-19 18:25     ` Harry Wentland
2021-03-19  8:24 ` [PATCH 09/19] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:55   ` Karol Herbst
2021-03-19  9:55     ` Karol Herbst
2021-03-19  9:55     ` [Nouveau] " Karol Herbst
2021-03-19  8:24 ` [PATCH 10/19] drm/nouveau/nouveau_bo: Remove unused variables 'dev' Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:56   ` Karol Herbst
2021-03-19  9:56     ` Karol Herbst
2021-03-19  9:56     ` [Nouveau] " Karol Herbst
2021-03-19  8:24 ` [PATCH 11/19] drm/nouveau/nouveau_display: Remove set but unused variable 'width' Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  8:24 ` [PATCH 12/19] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:57   ` Karol Herbst
2021-03-19  9:57     ` Karol Herbst
2021-03-19  9:57     ` [Nouveau] " Karol Herbst
2021-03-19  8:24 ` [PATCH 13/19] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  8:24 ` [PATCH 14/19] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:58   ` Karol Herbst
2021-03-19  9:58     ` Karol Herbst
2021-03-19  9:58     ` [Nouveau] " Karol Herbst
2021-03-19 17:36   ` Lyude Paul
2021-03-19 17:36     ` Lyude Paul
2021-03-19 17:36     ` [Nouveau] " Lyude Paul
2021-03-19  8:24 ` [PATCH 15/19] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:56   ` Karol Herbst
2021-03-19  9:56     ` Karol Herbst
2021-03-19  9:56     ` [Nouveau] " Karol Herbst
2021-03-19  8:24 ` [PATCH 16/19] drm/nouveau/dispnv50/disp: Include header containing our prototypes Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  8:24 ` [PATCH 17/19] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:57   ` Karol Herbst [this message]
2021-03-19  9:57     ` Karol Herbst
2021-03-19  9:57     ` [Nouveau] " Karol Herbst
2021-03-19  8:24 ` [PATCH 18/19] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  8:24 ` [PATCH 19/19] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones
2021-03-19  8:24   ` Lee Jones
2021-03-19  8:24   ` [Nouveau] " Lee Jones
2021-03-19  9:57   ` Karol Herbst
2021-03-19  9:57     ` Karol Herbst
2021-03-19  9:57     ` [Nouveau] " Karol Herbst
2021-03-24 10:36 ` [RESEND 00/19] Rid GPU from W=1 warnings Lee Jones
2021-03-24 10:36   ` Lee Jones
2021-03-24 10:36   ` Lee Jones
2021-03-24 10:36   ` [Nouveau] " Lee Jones
2021-03-30 15:19   ` Lee Jones
2021-03-30 15:19     ` Lee Jones
2021-03-30 15:19     ` Lee Jones
2021-03-30 15:19     ` [Nouveau] " Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACO55tvmj1-_ZcmLyN0tUdrH1QzN2c23-a+bDBXCKEOEsiak9g@mail.gmail.com \
    --to=kherbst@redhat.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.