All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daeho Jeong <daeho43@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Daeho Jeong <daehojeong@google.com>,
	linux-f2fs-devel@lists.sourceforge.net,
	kernel-janitors@vger.kernel.org,
	Colin Ian King <colin.king@canonical.com>,
	kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks
Date: Wed, 6 Jan 2021 08:44:53 +0900	[thread overview]
Message-ID: <CACOAw_xXPZm65BD0SAwFECyEMCD0i_g+7mKyd+=Gtm3p-W19og@mail.gmail.com> (raw)
In-Reply-To: <dba4be04-70dd-d48b-391c-1f2355591097@web.de>

Got it~

Thanks,

2021년 1월 5일 (화) 오후 9:06, Markus Elfring <Markus.Elfring@web.de>님이 작성:
>
> > Fixed null page reference when find_lock_page() fails in
> > redirty_blocks().
>
> I suggest to choose an other imperative wording for this change description.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89
>
>
> > v2: changed error value and break the loop when error occurs
>
> I propose to use a return statement instead of a break in the second if branch
> for this function implementation.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481
>
> Regards,
> Markus
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Daeho Jeong <daeho43@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Daeho Jeong <daehojeong@google.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Colin Ian King <colin.king@canonical.com>,
	kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks
Date: Tue, 05 Jan 2021 23:44:53 +0000	[thread overview]
Message-ID: <CACOAw_xXPZm65BD0SAwFECyEMCD0i_g+7mKyd+=Gtm3p-W19og@mail.gmail.com> (raw)
In-Reply-To: <dba4be04-70dd-d48b-391c-1f2355591097@web.de>

Got it~

Thanks,

2021년 1월 5일 (화) 오후 9:06, Markus Elfring <Markus.Elfring@web.de>님이 작성:
>
> > Fixed null page reference when find_lock_page() fails in
> > redirty_blocks().
>
> I suggest to choose an other imperative wording for this change description.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89
>
>
> > v2: changed error value and break the loop when error occurs
>
> I propose to use a return statement instead of a break in the second if branch
> for this function implementation.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481
>
> Regards,
> Markus
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Daeho Jeong <daeho43@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Daeho Jeong <daehojeong@google.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	Colin Ian King <colin.king@canonical.com>,
	kernel-team@android.com
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix null page reference in redirty_blocks
Date: Wed, 6 Jan 2021 08:44:53 +0900	[thread overview]
Message-ID: <CACOAw_xXPZm65BD0SAwFECyEMCD0i_g+7mKyd+=Gtm3p-W19og@mail.gmail.com> (raw)
In-Reply-To: <dba4be04-70dd-d48b-391c-1f2355591097@web.de>

Got it~

Thanks,

2021년 1월 5일 (화) 오후 9:06, Markus Elfring <Markus.Elfring@web.de>님이 작성:
>
> > Fixed null page reference when find_lock_page() fails in
> > redirty_blocks().
>
> I suggest to choose an other imperative wording for this change description.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n89
>
>
> > v2: changed error value and break the loop when error occurs
>
> I propose to use a return statement instead of a break in the second if branch
> for this function implementation.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=36bbbd0e234d817938bdc52121a0f5473b3e58f5#n481
>
> Regards,
> Markus
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2021-01-05 23:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  4:16 [PATCH v2] f2fs: fix null page reference in redirty_blocks Daeho Jeong
2021-01-05  4:16 ` [f2fs-dev] " Daeho Jeong
2021-01-05  6:05 ` Chao Yu
2021-01-05  6:05   ` Chao Yu
2021-01-05  9:34 ` Colin Ian King
2021-01-05  9:34   ` [f2fs-dev] " Colin Ian King
2021-01-05 12:04 ` Markus Elfring
2021-01-05 23:44   ` Daeho Jeong [this message]
2021-01-05 23:44     ` Daeho Jeong
2021-01-05 23:44     ` Daeho Jeong
2021-01-06  1:03   ` Chao Yu
2021-01-06  1:03     ` Chao Yu
2021-01-06  1:03     ` Chao Yu
2021-01-06  3:35     ` Daeho Jeong
2021-01-06  3:35       ` Daeho Jeong
2021-01-06  3:35       ` Daeho Jeong
2021-01-05 23:49 Daeho Jeong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACOAw_xXPZm65BD0SAwFECyEMCD0i_g+7mKyd+=Gtm3p-W19og@mail.gmail.com' \
    --to=daeho43@gmail.com \
    --cc=Markus.Elfring@web.de \
    --cc=colin.king@canonical.com \
    --cc=daehojeong@google.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.