* [PATCH 2/2] hwmon: (tacho) Remove an unused variable
@ 2017-04-10 13:47 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-04-10 13:47 UTC (permalink / raw)
To: Joel Stanley, Jaghathiswari Rankappagounder Natarajan
Cc: Jean Delvare, Guenter Roeck, linux-hwmon, kernel-janitors
We never use this global variable.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
index 2f22add5c73b..b96fff50a3ee 100644
--- a/drivers/hwmon/aspeed-pwm-tacho.c
+++ b/drivers/hwmon/aspeed-pwm-tacho.c
@@ -153,8 +153,6 @@
#define M_TACH_UNIT 0x1000
#define INIT_FAN_CTRL 0xFF
-void __iomem *regs;
-
struct aspeed_pwm_tacho_data {
struct regmap *regmap;
unsigned long clk_freq;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] hwmon: (tacho) Remove an unused variable
@ 2017-04-10 13:47 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-04-10 13:47 UTC (permalink / raw)
To: Joel Stanley, Jaghathiswari Rankappagounder Natarajan
Cc: Jean Delvare, Guenter Roeck, linux-hwmon, kernel-janitors
We never use this global variable.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
index 2f22add5c73b..b96fff50a3ee 100644
--- a/drivers/hwmon/aspeed-pwm-tacho.c
+++ b/drivers/hwmon/aspeed-pwm-tacho.c
@@ -153,8 +153,6 @@
#define M_TACH_UNIT 0x1000
#define INIT_FAN_CTRL 0xFF
-void __iomem *regs;
-
struct aspeed_pwm_tacho_data {
struct regmap *regmap;
unsigned long clk_freq;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] hwmon: (tacho) Remove an unused variable
2017-04-10 13:47 ` Dan Carpenter
@ 2017-04-12 10:39 ` Joel Stanley
-1 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2017-04-12 10:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaghathiswari Rankappagounder Natarajan, Jean Delvare,
Guenter Roeck, linux-hwmon, kernel-janitors
On Mon, Apr 10, 2017 at 11:17 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> We never use this global variable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Joel Stanley <joel@jms.id.au>
>
> diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
> index 2f22add5c73b..b96fff50a3ee 100644
> --- a/drivers/hwmon/aspeed-pwm-tacho.c
> +++ b/drivers/hwmon/aspeed-pwm-tacho.c
> @@ -153,8 +153,6 @@
> #define M_TACH_UNIT 0x1000
> #define INIT_FAN_CTRL 0xFF
>
> -void __iomem *regs;
> -
> struct aspeed_pwm_tacho_data {
> struct regmap *regmap;
> unsigned long clk_freq;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] hwmon: (tacho) Remove an unused variable
@ 2017-04-12 10:39 ` Joel Stanley
0 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2017-04-12 10:39 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jaghathiswari Rankappagounder Natarajan, Jean Delvare,
Guenter Roeck, linux-hwmon, kernel-janitors
On Mon, Apr 10, 2017 at 11:17 PM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> We never use this global variable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Joel Stanley <joel@jms.id.au>
>
> diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
> index 2f22add5c73b..b96fff50a3ee 100644
> --- a/drivers/hwmon/aspeed-pwm-tacho.c
> +++ b/drivers/hwmon/aspeed-pwm-tacho.c
> @@ -153,8 +153,6 @@
> #define M_TACH_UNIT 0x1000
> #define INIT_FAN_CTRL 0xFF
>
> -void __iomem *regs;
> -
> struct aspeed_pwm_tacho_data {
> struct regmap *regmap;
> unsigned long clk_freq;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-12 10:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-10 13:47 [PATCH 2/2] hwmon: (tacho) Remove an unused variable Dan Carpenter
2017-04-10 13:47 ` Dan Carpenter
2017-04-12 10:27 ` Joel Stanley
2017-04-12 10:39 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.