All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Rick Altherr <raltherr@google.com>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [U-Boot,1/2] aspeed: Use HUSH shell
Date: Tue, 17 Jan 2017 11:31:31 +1100	[thread overview]
Message-ID: <CACPK8XcQe4U5qvJ3QDW=ORUYGA-4ShVxuCajzTr4n=e=fqnvSw@mail.gmail.com> (raw)
In-Reply-To: <20170112021328.27200-2-raltherr@google.com>

Hi Rick,

On Thu, Jan 12, 2017 at 1:13 PM, Rick Altherr <raltherr@google.com> wrote:
> HUSH is the newer command-line interface that provides scripting
> capabilities.  Those are needed for an boot command that can boot either
> a FIT image that includes a ramdisk or a separate kernel and ramdisk.

For some reason this patch didn't arrive in my mailbox. I found it on patchwork.

I took at look at the code size change with enabling this:

$ size u-boot && ls -la u-boot.bin
   text    data     bss     dec     hex filename
 215567    7152   71048  293767   47b87 u-boot
-rw-r--r-- 1 joel joel 222536 Dec  8 12:03 u-boot.bin

$ size u-boot && ls -la u-boot.bin
   text    data     bss     dec     hex filename
 227643    7448   71448  306539   4ad6b u-boot
-rw-r--r-- 1 joel joel 234908 Jan 16 08:30 u-boot.bin

We go up by 5.6%, or 12KB. We're still well within the 384KB partition
size, so there is no issue there.

I've merged it into our u-boot tree.

Cheers,

Joel


> Signed-off-by: Rick Altherr <raltherr@google.com>


> ---
>
>  configs/ast_g4_ncsi_defconfig | 1 +
>  configs/ast_g4_phy_defconfig  | 1 +
>  configs/ast_g5_ncsi_defconfig | 1 +
>  configs/ast_g5_phy_defconfig  | 1 +
>  4 files changed, 4 insertions(+)
>
> diff --git a/configs/ast_g4_ncsi_defconfig b/configs/ast_g4_ncsi_defconfig
> index ab4907cfe2..54686bee5c 100644
> --- a/configs/ast_g4_ncsi_defconfig
> +++ b/configs/ast_g4_ncsi_defconfig
> @@ -7,6 +7,7 @@ CONFIG_CMD_PING=y
>  CONFIG_EFI_LOADER=n
>  CONFIG_FIT=y
>  CONFIG_FIT_VERBOSE=y
> +CONFIG_HUSH_PARSER=y
>  CONFIG_OF_LIBFDT=y
>  CONFIG_SPI_FLASH=y
>  CONFIG_SYS_NS16550=y
> diff --git a/configs/ast_g4_phy_defconfig b/configs/ast_g4_phy_defconfig
> index 21a56c4b96..f8db39ef13 100644
> --- a/configs/ast_g4_phy_defconfig
> +++ b/configs/ast_g4_phy_defconfig
> @@ -8,6 +8,7 @@ CONFIG_CMD_PING=y
>  CONFIG_EFI_LOADER=n
>  CONFIG_FIT=y
>  CONFIG_FIT_VERBOSE=y
> +CONFIG_HUSH_PARSER=y
>  CONFIG_OF_LIBFDT=y
>  CONFIG_SPI_FLASH=y
>  CONFIG_SYS_NS16550=y
> diff --git a/configs/ast_g5_ncsi_defconfig b/configs/ast_g5_ncsi_defconfig
> index 7cd4fd116d..74029ed514 100644
> --- a/configs/ast_g5_ncsi_defconfig
> +++ b/configs/ast_g5_ncsi_defconfig
> @@ -7,6 +7,7 @@ CONFIG_CMD_PING=y
>  CONFIG_EFI_LOADER=n
>  CONFIG_FIT=y
>  CONFIG_FIT_VERBOSE=y
> +CONFIG_HUSH_PARSER=y
>  CONFIG_OF_LIBFDT=y
>  CONFIG_SPI_FLASH=y
>  CONFIG_SYS_NS16550=y
> diff --git a/configs/ast_g5_phy_defconfig b/configs/ast_g5_phy_defconfig
> index c686dd2297..767f3af605 100644
> --- a/configs/ast_g5_phy_defconfig
> +++ b/configs/ast_g5_phy_defconfig
> @@ -8,6 +8,7 @@ CONFIG_CMD_PING=y
>  CONFIG_EFI_LOADER=n
>  CONFIG_FIT=y
>  CONFIG_FIT_VERBOSE=y
> +CONFIG_HUSH_PARSER=y
>  CONFIG_OF_LIBFDT=y
>  CONFIG_SPI_FLASH=y
>  CONFIG_SYS_NS16550=y

  reply	other threads:[~2017-01-17  0:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12  2:13 [U-Boot PATCH 0/2] aspeed: Use FIT-provided ramdisk if available Rick Altherr
2017-01-12  2:13 ` [U-Boot PATCH 1/2] aspeed: Use HUSH shell Rick Altherr
2017-01-17  0:31   ` Joel Stanley [this message]
2017-01-12  2:13 ` [U-Boot PATCH 2/2] aspeed: use FIT-provided ramdisk if available Rick Altherr
2017-01-17  0:33   ` [U-Boot,2/2] " Joel Stanley
2017-01-17 23:33     ` Rick Altherr
2017-01-19 13:57       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8XcQe4U5qvJ3QDW=ORUYGA-4ShVxuCajzTr4n=e=fqnvSw@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=raltherr@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.