All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Rick Altherr <raltherr@google.com>, Simon Glass <sjg@chromium.org>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [U-Boot,2/2] aspeed: use FIT-provided ramdisk if available
Date: Tue, 17 Jan 2017 11:33:26 +1100	[thread overview]
Message-ID: <CACPK8Xd3LtSZ3i_r19AZtVMxRLxXnQwOw8oQc+eS7b5iJvWS9A@mail.gmail.com> (raw)
In-Reply-To: <20170112021328.27200-3-raltherr@google.com>

On Thu, Jan 12, 2017 at 1:13 PM, Rick Altherr <raltherr@google.com> wrote:
> If the kernel FIT specifies a ramdisk, use it.  Otherwise, expect a
> ramdisk at 0x20300000.
>
> Signed-off-by: Rick Altherr <raltherr@google.com>
> ---
>
>  include/configs/ast-common.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/configs/ast-common.h b/include/configs/ast-common.h
> index b39ea33ce7..110c780070 100644
> --- a/include/configs/ast-common.h
> +++ b/include/configs/ast-common.h
> @@ -96,7 +96,11 @@
>  #define CONFIG_ENV_OFFSET              0x60000 /* environment starts here  */
>  #define CONFIG_ENV_SIZE                        0x20000 /* Total Size of Environment Sector */
>
> -#define CONFIG_BOOTCOMMAND     "bootm 20080000 20300000"
> +#define CONFIG_BOOTCOMMAND     \
> +       "fdt addr 20080000; " \
> +       "if fdt get value ramdisk_conf /configurations/conf@1 ramdisk; then " \
> +       "    bootm 20080000; else bootm 20080000 20300000; " \
> +       "fi"

This feels a little clunky. Is this the method upstream suggests to
solve this problem?

Cheers,

Joel

  reply	other threads:[~2017-01-17  0:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12  2:13 [U-Boot PATCH 0/2] aspeed: Use FIT-provided ramdisk if available Rick Altherr
2017-01-12  2:13 ` [U-Boot PATCH 1/2] aspeed: Use HUSH shell Rick Altherr
2017-01-17  0:31   ` [U-Boot,1/2] " Joel Stanley
2017-01-12  2:13 ` [U-Boot PATCH 2/2] aspeed: use FIT-provided ramdisk if available Rick Altherr
2017-01-17  0:33   ` Joel Stanley [this message]
2017-01-17 23:33     ` [U-Boot,2/2] " Rick Altherr
2017-01-19 13:57       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPK8Xd3LtSZ3i_r19AZtVMxRLxXnQwOw8oQc+eS7b5iJvWS9A@mail.gmail.com \
    --to=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=raltherr@google.com \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.