From: Joel Stanley <joel@jms.id.au> To: Konstantin Aladyshev <aladyshev22@gmail.com>, Patrick Williams <patrick@stwcx.xyz> Cc: Supreeth Venkatesh <supreeth.venkatesh@amd.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, SoC Team <soc@kernel.org>, Rob Herring <robh+dt@kernel.org>, Andrew Jeffery <andrew@aj.id.au>, Linux ARM <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-aspeed <linux-aspeed@lists.ozlabs.org>, Andrew Geissler <geissonator@yahoo.com> Subject: Re: [PATCH] ARM: dts: aspeed: Add AMD DaytonaX BMC Date: Tue, 16 Nov 2021 06:07:55 +0000 [thread overview] Message-ID: <CACPK8Xcc6Nem00zZdGmHF=U4T2O90aL+_vKO4YmAqSW9wKeegA@mail.gmail.com> (raw) In-Reply-To: <CACSj6VVTFa0t9WK=R2TucG7eFqUzBsWYFzvsaRt6eXOiFuQORA@mail.gmail.com> On Wed, 27 Oct 2021 at 10:59, Konstantin Aladyshev <aladyshev22@gmail.com> wrote: > > Thanks for the comments. Can I ask you some questions about this > `device-tree-gpio-naming.md`? > > 1) First of all in my naming I've tried to use naming scheme the same > as the EthanolX CRB DTS currently has > (https://github.com/torvalds/linux/blob/d25f27432f80a800a3592db128254c8140bd71bf/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts#L102). > Do you want me to change GPIO naming in the EthanolX CRB as well? Yeah, that would make sense. > 2) Also this naming comes from the signal names in the board > schematics. This way it is clear to check schematics vs DTS. If we use > this OpenBMC naming style, we will lose that correspondence. Is it > really good? This is a good point. The preference is to use human readable names over the schematic net. I can see cases where this would be worse, but hopefully on balance it results in consistent naming between machines. > 3) In the initial version of the DTS file I've supplied only a minimal > set of GPIO, that are used by OpenBMC. GPIOs for x86-power-control app > and led id/fault gpios. With renaming these GPIOs I'm only sure about > these GPIOs: > > FAULT_LED - led-fault > CHASSIS_ID_BTN - led-identify > > What about the rest? For example the document doesn't really state > what the *-button postfix states? Is it for asserting or monitoring > buttons? How should I name these signals? > > ASSERT_BMC_READY > ASSERT_RST_BTN > ASSERT_PWR_BTN > > MON_P0_RST_BTN > MON_P0_PWR_BTN > MON_P0_PWR_GOOD > MON_PWROK > > Can you help me with those? Patrick, do you have thoughts here? > > 4) And what should I do to the board GPIO signals that OpenBMC doesn't > use? If you look at the EthanolX CRB DTS > (https://github.com/torvalds/linux/blob/d25f27432f80a800a3592db128254c8140bd71bf/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts#L102) > it has a ton of GPIOs. Should they be renamed to this OpenBMC style as > well? Or can they be named exactly like in the schematics? That's up to you. > > I've also CCed original author of the `device-tree-gpio-naming.md` > document Andrew Geissler. Andrew, can you please provide your opinion > on the subject? I've also added Patrick, who is helping review this document. Cheers, Joel > > Best regards, > Konstantin Aladyshev > > On Wed, Oct 27, 2021 at 12:03 AM Joel Stanley <joel@jms.id.au> wrote: > > > > Hello Konstantin, > > > > On Tue, 26 Oct 2021 at 20:01, Konstantin Aladyshev > > <aladyshev22@gmail.com> wrote: > > > > > > Add initial version of device tree for the BMC in the AMD DaytonaX > > > platform. > > > > > > AMD DaytonaX platform is a customer reference board (CRB) with an > > > Aspeed ast2500 BMC manufactured by AMD. > > > > > > Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> > > > > This looks good. I have one comment about the GPIOs below. > > > > > +&gpio { > > > + status = "okay"; > > > + gpio-line-names = > > > + /*A0-A7*/ "","","FAULT_LED","","","","","", > > > + /*B0-B7*/ "","","","","","","","", > > > + /*C0-C7*/ "CHASSIS_ID_BTN","","","","","","","", > > > + /*D0-D7*/ "","","ASSERT_BMC_READY","","","","","", > > > + /*E0-E7*/ "MON_P0_RST_BTN","ASSERT_RST_BTN","MON_P0_PWR_BTN","ASSERT_PWR_BTN","", > > > + "MON_P0_PWR_GOOD","MON_PWROK","", > > > > For systems that will run openbmc, we try to use naming conventions > > from this document: > > > > https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md > > > > If a GPIO is missing from that doc I encourage you to add it.
WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au> To: Konstantin Aladyshev <aladyshev22@gmail.com>, Patrick Williams <patrick@stwcx.xyz> Cc: Supreeth Venkatesh <supreeth.venkatesh@amd.com>, Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, SoC Team <soc@kernel.org>, Rob Herring <robh+dt@kernel.org>, Andrew Jeffery <andrew@aj.id.au>, Linux ARM <linux-arm-kernel@lists.infradead.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-aspeed <linux-aspeed@lists.ozlabs.org>, Andrew Geissler <geissonator@yahoo.com> Subject: Re: [PATCH] ARM: dts: aspeed: Add AMD DaytonaX BMC Date: Tue, 16 Nov 2021 06:07:55 +0000 [thread overview] Message-ID: <CACPK8Xcc6Nem00zZdGmHF=U4T2O90aL+_vKO4YmAqSW9wKeegA@mail.gmail.com> (raw) Message-ID: <20211116060755.KUpRXlMR1Omp33B9ZscKi-15_qa6X62ic0h9muNAXfY@z> (raw) In-Reply-To: <CACSj6VVTFa0t9WK=R2TucG7eFqUzBsWYFzvsaRt6eXOiFuQORA@mail.gmail.com> On Wed, 27 Oct 2021 at 10:59, Konstantin Aladyshev <aladyshev22@gmail.com> wrote: > > Thanks for the comments. Can I ask you some questions about this > `device-tree-gpio-naming.md`? > > 1) First of all in my naming I've tried to use naming scheme the same > as the EthanolX CRB DTS currently has > (https://github.com/torvalds/linux/blob/d25f27432f80a800a3592db128254c8140bd71bf/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts#L102). > Do you want me to change GPIO naming in the EthanolX CRB as well? Yeah, that would make sense. > 2) Also this naming comes from the signal names in the board > schematics. This way it is clear to check schematics vs DTS. If we use > this OpenBMC naming style, we will lose that correspondence. Is it > really good? This is a good point. The preference is to use human readable names over the schematic net. I can see cases where this would be worse, but hopefully on balance it results in consistent naming between machines. > 3) In the initial version of the DTS file I've supplied only a minimal > set of GPIO, that are used by OpenBMC. GPIOs for x86-power-control app > and led id/fault gpios. With renaming these GPIOs I'm only sure about > these GPIOs: > > FAULT_LED - led-fault > CHASSIS_ID_BTN - led-identify > > What about the rest? For example the document doesn't really state > what the *-button postfix states? Is it for asserting or monitoring > buttons? How should I name these signals? > > ASSERT_BMC_READY > ASSERT_RST_BTN > ASSERT_PWR_BTN > > MON_P0_RST_BTN > MON_P0_PWR_BTN > MON_P0_PWR_GOOD > MON_PWROK > > Can you help me with those? Patrick, do you have thoughts here? > > 4) And what should I do to the board GPIO signals that OpenBMC doesn't > use? If you look at the EthanolX CRB DTS > (https://github.com/torvalds/linux/blob/d25f27432f80a800a3592db128254c8140bd71bf/arch/arm/boot/dts/aspeed-bmc-amd-ethanolx.dts#L102) > it has a ton of GPIOs. Should they be renamed to this OpenBMC style as > well? Or can they be named exactly like in the schematics? That's up to you. > > I've also CCed original author of the `device-tree-gpio-naming.md` > document Andrew Geissler. Andrew, can you please provide your opinion > on the subject? I've also added Patrick, who is helping review this document. Cheers, Joel > > Best regards, > Konstantin Aladyshev > > On Wed, Oct 27, 2021 at 12:03 AM Joel Stanley <joel@jms.id.au> wrote: > > > > Hello Konstantin, > > > > On Tue, 26 Oct 2021 at 20:01, Konstantin Aladyshev > > <aladyshev22@gmail.com> wrote: > > > > > > Add initial version of device tree for the BMC in the AMD DaytonaX > > > platform. > > > > > > AMD DaytonaX platform is a customer reference board (CRB) with an > > > Aspeed ast2500 BMC manufactured by AMD. > > > > > > Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> > > > > This looks good. I have one comment about the GPIOs below. > > > > > +&gpio { > > > + status = "okay"; > > > + gpio-line-names = > > > + /*A0-A7*/ "","","FAULT_LED","","","","","", > > > + /*B0-B7*/ "","","","","","","","", > > > + /*C0-C7*/ "CHASSIS_ID_BTN","","","","","","","", > > > + /*D0-D7*/ "","","ASSERT_BMC_READY","","","","","", > > > + /*E0-E7*/ "MON_P0_RST_BTN","ASSERT_RST_BTN","MON_P0_PWR_BTN","ASSERT_PWR_BTN","", > > > + "MON_P0_PWR_GOOD","MON_PWROK","", > > > > For systems that will run openbmc, we try to use naming conventions > > from this document: > > > > https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md > > > > If a GPIO is missing from that doc I encourage you to add it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-16 6:08 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-26 20:00 [PATCH] ARM: dts: aspeed: Add AMD DaytonaX BMC Konstantin Aladyshev 2021-10-26 20:00 ` Konstantin Aladyshev 2021-10-26 20:00 ` Konstantin Aladyshev 2021-10-26 21:03 ` Joel Stanley 2021-10-26 21:03 ` Joel Stanley 2021-10-27 11:05 ` Konstantin Aladyshev 2021-10-27 11:05 ` Konstantin Aladyshev 2021-11-16 6:07 ` Joel Stanley [this message] 2021-11-16 6:07 ` Joel Stanley 2022-09-20 15:34 Konstantin Aladyshev 2022-09-20 15:34 ` Konstantin Aladyshev 2022-09-20 15:34 ` Konstantin Aladyshev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACPK8Xcc6Nem00zZdGmHF=U4T2O90aL+_vKO4YmAqSW9wKeegA@mail.gmail.com' \ --to=joel@jms.id.au \ --cc=aladyshev22@gmail.com \ --cc=andrew@aj.id.au \ --cc=arnd@arndb.de \ --cc=devicetree@vger.kernel.org \ --cc=geissonator@yahoo.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=olof@lixom.net \ --cc=patrick@stwcx.xyz \ --cc=robh+dt@kernel.org \ --cc=soc@kernel.org \ --cc=supreeth.venkatesh@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.