From: Joel Stanley <joel@jms.id.au>
To: Steven Lee <steven_lee@aspeedtech.com>, Andrew Jeffery <andrew@aj.id.au>
Cc: Rob Herring <robh+dt@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"moderated list:ASPEED SD/MMC DRIVER" <openbmc@lists.ozlabs.org>,
Hongwei Zhang <Hongweiz@ami.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Subject: Re: [PATCH v5 0/4] mmc: sdhci-of-aspeed: Support toggling SD bus signal
Date: Tue, 25 May 2021 07:55:41 +0000 [thread overview]
Message-ID: <CACPK8XcfvUQD5xwb=2Va5Sr+bmaWfJMZkh61HK1=J1qLYc84zQ@mail.gmail.com> (raw)
In-Reply-To: <20210524073308.9328-1-steven_lee@aspeedtech.com>
On Mon, 24 May 2021 at 07:33, Steven Lee <steven_lee@aspeedtech.com> wrote:
>
> AST2600-A2 EVB has the reference design for enabling SD bus
> power and toggling SD bus signal voltage between 3.3v and 1.8v by
> GPIO regulators.
> This patch series adds sdhci node and gpio regulators in a new dts file
> for AST2600-A2 EVB.
> The description of the reference design of AST2600-A2 EVB is added
> in the new dts file.
>
> This patch also include a helper for updating AST2600 sdhci capability
> registers.
The device trees look good:
Reviewed-by: Joel Stanley <joel@jms.id.au>
I've applied patches 1-3 to the aspeed tree for v5.14. I made a little
fix to patch 3 as it needed to add the new device tree to the
makefile.
When I was testing on my A2 EVB I saw this:
[ 1.436219] sdhci-aspeed 1e750100.sdhci: Requested out of range
phase tap 192 for 9 degrees of phase compensation at 1562500Hz,
clamping to tap 15
[ 1.450913] sdhci-aspeed 1e750100.sdhci: Requested out of range
phase tap 963 for 45 degrees of phase compensation at 1562500Hz,
clamping to tap 15
Do you know what is happening there?
Cheers,
Joel
WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au>
To: Steven Lee <steven_lee@aspeedtech.com>, Andrew Jeffery <andrew@aj.id.au>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Ryan Chen <ryan_chen@aspeedtech.com>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
"moderated list:ASPEED SD/MMC DRIVER" <openbmc@lists.ozlabs.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
open list <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Hongwei Zhang <Hongweiz@ami.com>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 0/4] mmc: sdhci-of-aspeed: Support toggling SD bus signal
Date: Tue, 25 May 2021 07:55:41 +0000 [thread overview]
Message-ID: <CACPK8XcfvUQD5xwb=2Va5Sr+bmaWfJMZkh61HK1=J1qLYc84zQ@mail.gmail.com> (raw)
In-Reply-To: <20210524073308.9328-1-steven_lee@aspeedtech.com>
On Mon, 24 May 2021 at 07:33, Steven Lee <steven_lee@aspeedtech.com> wrote:
>
> AST2600-A2 EVB has the reference design for enabling SD bus
> power and toggling SD bus signal voltage between 3.3v and 1.8v by
> GPIO regulators.
> This patch series adds sdhci node and gpio regulators in a new dts file
> for AST2600-A2 EVB.
> The description of the reference design of AST2600-A2 EVB is added
> in the new dts file.
>
> This patch also include a helper for updating AST2600 sdhci capability
> registers.
The device trees look good:
Reviewed-by: Joel Stanley <joel@jms.id.au>
I've applied patches 1-3 to the aspeed tree for v5.14. I made a little
fix to patch 3 as it needed to add the new device tree to the
makefile.
When I was testing on my A2 EVB I saw this:
[ 1.436219] sdhci-aspeed 1e750100.sdhci: Requested out of range
phase tap 192 for 9 degrees of phase compensation at 1562500Hz,
clamping to tap 15
[ 1.450913] sdhci-aspeed 1e750100.sdhci: Requested out of range
phase tap 963 for 45 degrees of phase compensation at 1562500Hz,
clamping to tap 15
Do you know what is happening there?
Cheers,
Joel
WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au>
To: Steven Lee <steven_lee@aspeedtech.com>, Andrew Jeffery <andrew@aj.id.au>
Cc: Rob Herring <robh+dt@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"moderated list:ASPEED SD/MMC DRIVER" <openbmc@lists.ozlabs.org>,
Hongwei Zhang <Hongweiz@ami.com>,
Ryan Chen <ryan_chen@aspeedtech.com>,
Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Subject: Re: [PATCH v5 0/4] mmc: sdhci-of-aspeed: Support toggling SD bus signal
Date: Tue, 25 May 2021 07:55:41 +0000 [thread overview]
Message-ID: <CACPK8XcfvUQD5xwb=2Va5Sr+bmaWfJMZkh61HK1=J1qLYc84zQ@mail.gmail.com> (raw)
In-Reply-To: <20210524073308.9328-1-steven_lee@aspeedtech.com>
On Mon, 24 May 2021 at 07:33, Steven Lee <steven_lee@aspeedtech.com> wrote:
>
> AST2600-A2 EVB has the reference design for enabling SD bus
> power and toggling SD bus signal voltage between 3.3v and 1.8v by
> GPIO regulators.
> This patch series adds sdhci node and gpio regulators in a new dts file
> for AST2600-A2 EVB.
> The description of the reference design of AST2600-A2 EVB is added
> in the new dts file.
>
> This patch also include a helper for updating AST2600 sdhci capability
> registers.
The device trees look good:
Reviewed-by: Joel Stanley <joel@jms.id.au>
I've applied patches 1-3 to the aspeed tree for v5.14. I made a little
fix to patch 3 as it needed to add the new device tree to the
makefile.
When I was testing on my A2 EVB I saw this:
[ 1.436219] sdhci-aspeed 1e750100.sdhci: Requested out of range
phase tap 192 for 9 degrees of phase compensation at 1562500Hz,
clamping to tap 15
[ 1.450913] sdhci-aspeed 1e750100.sdhci: Requested out of range
phase tap 963 for 45 degrees of phase compensation at 1562500Hz,
clamping to tap 15
Do you know what is happening there?
Cheers,
Joel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-25 7:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 7:32 [PATCH v5 0/4] mmc: sdhci-of-aspeed: Support toggling SD bus signal Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 7:32 ` [PATCH v5 1/4] ARM: dts: aspeed: ast2600evb: Add sdhci node and gpio regulator for A2 evb Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-25 1:00 ` Andrew Jeffery
2021-05-25 1:00 ` Andrew Jeffery
2021-05-25 1:00 ` Andrew Jeffery
2021-05-24 7:32 ` [PATCH v5 2/4] ARM: dts: aspeed: ast2600evb: Add phase correction for emmc controller Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 7:32 ` [PATCH v5 3/4] ARM: dts: aspeed: ast2600evb: Add dts file for A1 and A0 Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-25 1:00 ` Andrew Jeffery
2021-05-25 1:00 ` Andrew Jeffery
2021-05-25 1:00 ` Andrew Jeffery
2021-05-24 7:32 ` [PATCH v5 4/4] mmc: sdhci-of-aspeed: Configure the SDHCIs as specified by the devicetree Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 7:32 ` Steven Lee
2021-05-24 14:11 ` Ulf Hansson
2021-05-24 14:11 ` Ulf Hansson
2021-05-24 14:11 ` Ulf Hansson
2021-05-25 7:55 ` Joel Stanley [this message]
2021-05-25 7:55 ` [PATCH v5 0/4] mmc: sdhci-of-aspeed: Support toggling SD bus signal Joel Stanley
2021-05-25 7:55 ` Joel Stanley
2021-05-25 9:48 ` Steven Lee
2021-05-25 9:48 ` Steven Lee
2021-05-25 9:48 ` Steven Lee
2021-05-25 12:56 ` Joel Stanley
2021-05-25 12:56 ` Joel Stanley
2021-05-25 12:56 ` Joel Stanley
2021-05-25 22:59 ` Andrew Jeffery
2021-05-25 22:59 ` Andrew Jeffery
2021-05-25 22:59 ` Andrew Jeffery
2021-06-07 0:59 ` Andrew Jeffery
2021-06-07 0:59 ` Andrew Jeffery
2021-06-07 0:59 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XcfvUQD5xwb=2Va5Sr+bmaWfJMZkh61HK1=J1qLYc84zQ@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=Hongweiz@ami.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=steven_lee@aspeedtech.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.