All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Cédric Le Goater" <clg@kaod.org>,
	"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
	joe.hershberger@ni.com, "Simon Glass" <sjg@chromium.org>
Subject: Re: [PATCH v2 4/4] net: NC-SI setup and handling
Date: Wed, 19 Jun 2019 02:35:15 +0000	[thread overview]
Message-ID: <CACPK8XctZJj3KwhB_5ctmBgungeNrHe8gCORmjtwdx=enHROxg@mail.gmail.com> (raw)
In-Reply-To: <20190618013720.2823-5-sam@mendozajonas.com>

On Tue, 18 Jun 2019 at 01:38, Samuel Mendoza-Jonas <sam@mendozajonas.com> wrote:
>
> Add the handling of NC-SI ethernet frames, and add a check at the start
> of net_loop() to configure NC-SI before starting other network commands.
> This also adds an "ncsi" command to manually start NC-SI configuration.
>
> Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
> ---
> v2: Update ncsi command help text
>
>  cmd/Kconfig   |  8 ++++++++
>  cmd/net.c     | 18 ++++++++++++++++++
>  include/net.h |  2 +-
>  net/net.c     | 27 ++++++++++++++++++++++++++-
>  4 files changed, 53 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 0badcb3fe0..9851b04972 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1332,6 +1332,14 @@ config CMD_LINK_LOCAL
>         help
>           Acquire a network IP address using the link-local protocol
>
> +config CMD_NCSI
> +       bool "ncsi"
> +       depends on PHY_NCSI
> +       help
> +         Manually configure the attached NIC via NC-SI.
> +         Normally this happens automatically before other network
> +         operations.

Do we need to make it even clearer that "this command not required to use NCSI"?

I'm thinking of future me wondering if we should put this in openbmc
builds or not. It would be good to have your advice on this.

Cheers,

Joel

WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] net: NC-SI setup and handling
Date: Wed, 19 Jun 2019 02:35:15 +0000	[thread overview]
Message-ID: <CACPK8XctZJj3KwhB_5ctmBgungeNrHe8gCORmjtwdx=enHROxg@mail.gmail.com> (raw)
In-Reply-To: <20190618013720.2823-5-sam@mendozajonas.com>

On Tue, 18 Jun 2019 at 01:38, Samuel Mendoza-Jonas <sam@mendozajonas.com> wrote:
>
> Add the handling of NC-SI ethernet frames, and add a check at the start
> of net_loop() to configure NC-SI before starting other network commands.
> This also adds an "ncsi" command to manually start NC-SI configuration.
>
> Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
> ---
> v2: Update ncsi command help text
>
>  cmd/Kconfig   |  8 ++++++++
>  cmd/net.c     | 18 ++++++++++++++++++
>  include/net.h |  2 +-
>  net/net.c     | 27 ++++++++++++++++++++++++++-
>  4 files changed, 53 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 0badcb3fe0..9851b04972 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1332,6 +1332,14 @@ config CMD_LINK_LOCAL
>         help
>           Acquire a network IP address using the link-local protocol
>
> +config CMD_NCSI
> +       bool "ncsi"
> +       depends on PHY_NCSI
> +       help
> +         Manually configure the attached NIC via NC-SI.
> +         Normally this happens automatically before other network
> +         operations.

Do we need to make it even clearer that "this command not required to use NCSI"?

I'm thinking of future me wondering if we should put this in openbmc
builds or not. It would be good to have your advice on this.

Cheers,

Joel

  reply	other threads:[~2019-06-19  2:35 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18  1:37 [PATCH v2 0/4] NC-SI PHY Support Samuel Mendoza-Jonas
2019-06-18  1:37 ` [U-Boot] " Samuel Mendoza-Jonas
2019-06-18  1:37 ` [PATCH v2 1/4] phy: Add support for the NC-SI protocol Samuel Mendoza-Jonas
2019-06-18  1:37   ` [U-Boot] " Samuel Mendoza-Jonas
2019-06-19  2:32   ` Joel Stanley
2019-06-19  2:32     ` [U-Boot] " Joel Stanley
2019-07-09 23:22   ` Joe Hershberger
2019-07-09 23:22     ` Joe Hershberger
2019-06-18  1:37 ` [PATCH v2 2/4] phy: Include NC-SI in phy setup Samuel Mendoza-Jonas
2019-06-18  1:37   ` [U-Boot] " Samuel Mendoza-Jonas
2019-06-19  2:32   ` Joel Stanley
2019-06-19  2:32     ` [U-Boot] " Joel Stanley
2019-07-09 23:24   ` Joe Hershberger
2019-07-09 23:24     ` Joe Hershberger
2019-06-18  1:37 ` [PATCH v2 3/4] net/ftgmac100: Add NC-SI mode support Samuel Mendoza-Jonas
2019-06-18  1:37   ` [U-Boot] " Samuel Mendoza-Jonas
2019-06-18  8:31   ` Cédric Le Goater
2019-06-18  8:31     ` [U-Boot] " Cédric Le Goater
2019-07-09 23:28   ` Joe Hershberger
2019-07-09 23:28     ` Joe Hershberger
2019-06-18  1:37 ` [PATCH v2 4/4] net: NC-SI setup and handling Samuel Mendoza-Jonas
2019-06-18  1:37   ` [U-Boot] " Samuel Mendoza-Jonas
2019-06-19  2:35   ` Joel Stanley [this message]
2019-06-19  2:35     ` Joel Stanley
2019-06-20  3:35     ` Samuel Mendoza-Jonas
2019-06-20  3:35       ` [U-Boot] " Samuel Mendoza-Jonas
2019-07-09 23:33   ` Joe Hershberger
2019-07-09 23:33     ` Joe Hershberger
2019-09-09  2:34     ` Samuel Mendoza-Jonas
2019-09-09  2:34       ` Samuel Mendoza-Jonas
2019-06-18  8:35 ` [PATCH v2 0/4] NC-SI PHY Support Cédric Le Goater
2019-06-18  8:35   ` [U-Boot] " Cédric Le Goater
2019-06-19  2:27   ` Joel Stanley
2019-06-19  2:27     ` [U-Boot] " Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACPK8XctZJj3KwhB_5ctmBgungeNrHe8gCORmjtwdx=enHROxg@mail.gmail.com' \
    --to=joel@jms.id.au \
    --cc=clg@kaod.org \
    --cc=joe.hershberger@ni.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=sam@mendozajonas.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.