[PATCH linux] boot/dts: Keep the LED initial state during kernel loading

[PATCH linux] boot/dts: Keep the LED initial state during kernel loading

[OpenBMC Patches]

Base on the Barreleye HW spec, the beep LED shouldn't be
turned to OFF until BMC ready.

Now the LED will be turned to OFF when the kernel loading,
so enable the LED sub-node property "default-state" to keep the LED
initial state.

Signed-off-by: johnhcwang <hsienchiang@gmail.com>

https://github.com/openbmc/linux/pull/99

johnhcwang (1):
  boot/dts: Keep the LED initial state during kernel loading

 arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.9.0

[PATCH linux] boot/dts: Keep the LED initial state during kernel loading

[OpenBMC Patches]

From: johnhcwang <hsienchiang@gmail.com>

Base on the Barreleye HW spec, the beep LED shouldn't be
turned to OFF until BMC ready.

Now the LED will be turned to OFF when the kernel loading,
so enable the LED sub-node property "default-state" to keep the LED
initial state.

Signed-off-by: johnhcwang <hsienchiang@gmail.com>
---
 arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
index 0e567e8..3146ea9 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
@@ -132,12 +132,15 @@
 
 		heartbeat {
 			gpios = <&gpio 140 GPIO_ACTIVE_HIGH>;
+			default-state = "keep";
 		};
 		identify {
 			gpios = <&gpio 58 GPIO_ACTIVE_LOW>;
+			default-state = "keep";
 		};
 		beep {
 			gpios = <&gpio 111 GPIO_ACTIVE_HIGH>;
+			default-state = "keep";
 		};
 	};
 };
-- 
2.9.0

Re: [PATCH linux] boot/dts: Keep the LED initial state during kernel loading

[Joel Stanley]

Hello John,

Thanks for the pull request. In the future, can you please use
git-send-email to post the patch to openbmc@lists.ozlabs.org?

On Mon, Aug 8, 2016 at 3:50 PM, OpenBMC Patches
<openbmc-patches@stwcx.xyz> wrote:
> From: johnhcwang <hsienchiang@gmail.com>
>
> Base on the Barreleye HW spec, the beep LED shouldn't be
> turned to OFF until BMC ready.
>
> Now the LED will be turned to OFF when the kernel loading,
> so enable the LED sub-node property "default-state" to keep the LED
> initial state.
>
> Signed-off-by: johnhcwang <hsienchiang@gmail.com>

Please set this to be your name. It should look something like:

Signed-off-by: John Wang <hsienchiang@gmail.com>

You can do this with this line:

git config --global author.name "John Wang"

Cheers,

Joel

> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> index 0e567e8..3146ea9 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> @@ -132,12 +132,15 @@
>
>                 heartbeat {
>                         gpios = <&gpio 140 GPIO_ACTIVE_HIGH>;
> +                       default-state = "keep";
>                 };
>                 identify {
>                         gpios = <&gpio 58 GPIO_ACTIVE_LOW>;
> +                       default-state = "keep";
>                 };
>                 beep {
>                         gpios = <&gpio 111 GPIO_ACTIVE_HIGH>;
> +                       default-state = "keep";
>                 };
>         };
>  };
> --
> 2.9.0
>
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc