[PATCH linux dev-4.7 1/3] ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

[PATCH linux dev-4.7 1/3] ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

[Lei YU]

Also add the reserved-memory node needed by the LPC
control driver.

Signed-off-by: Lei YU <mine260309@gmail.com>
---
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
index c23627e..f47eb63 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
@@ -19,6 +19,18 @@
 	memory {
 		reg = <0x80000000 0x40000000>;
 	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		flash_memory: region@94000000 {
+			no-map;
+			reg = <0x94000000 0x04000000>; /* 64M */
+		};
+	};
+
 };
 
 &fmc {
@@ -44,6 +56,16 @@
 	};
 };
 
+&lpc_ctrl {
+	status = "okay";
+	memory-region = <&flash_memory>;
+	flash = <&spi1>;
+};
+
+&mbox {
+	status = "okay";
+};
+
 &uart5 {
 	status = "okay";
 };
-- 
1.9.1

Re: [PATCH linux dev-4.7 1/3] ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

[Andrew Jeffery]

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

Hi Lei,

On Tue, 2017-02-14 at 15:25 +0800, Lei YU wrote:
> Also add the reserved-memory node needed by the LPC
> control driver.
> 
> > Signed-off-by: Lei YU <mine260309@gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index c23627e..f47eb63 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -19,6 +19,18 @@
> >  	memory {
> >  		reg = <0x80000000 0x40000000>;
> >  	};
> +
> > +	reserved-memory {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges;
> +
> > > +		flash_memory: region@94000000 {
> > +			no-map;
> +			reg = <0x94000000 0x04000000>; /* 64M */

So these values are also used in the zaius dts. Why are we reserving
64M 128M down from the top of the RAM address space? Is the top 64M
meant to be reserved for anything as well? Why not reserve the top 64M?

> +		};
> > +	};
> +
>  };
>  
>  &fmc {
> @@ -44,6 +56,16 @@
> >  	};
>  };
>  
> +&lpc_ctrl {
> > +	status = "okay";
> > +	memory-region = <&flash_memory>;
> > +	flash = <&spi1>;
> +};
> +
> +&mbox {
> > +	status = "okay";
> +};

This looks fine.

Andrew
> +
>  &uart5 {
> >  	status = "okay";
>  };

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [PATCH linux dev-4.7 1/3] ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

[Mine]

Hi Andrew,

On Thu, Feb 16, 2017 at 9:12 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
> Hi Lei,
>
> On Tue, 2017-02-14 at 15:25 +0800, Lei YU wrote:
>> Also add the reserved-memory node needed by the LPC
>> control driver.
>>
>> > Signed-off-by: Lei YU <mine260309@gmail.com>
>> ---
>>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> index c23627e..f47eb63 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>> @@ -19,6 +19,18 @@
>> >     memory {
>> >             reg = <0x80000000 0x40000000>;
>> >     };
>> +
>> > +   reserved-memory {
>> > +           #address-cells = <1>;
>> > +           #size-cells = <1>;
>> > +           ranges;
>> +
>> > > +         flash_memory: region@94000000 {
>> > +                   no-map;
>> +                     reg = <0x94000000 0x04000000>; /* 64M */
>
> So these values are also used in the zaius dts. Why are we reserving
> 64M 128M down from the top of the RAM address space? Is the top 64M
> meant to be reserved for anything as well? Why not reserve the top 64M?
>

This is a good question, but honestly I just copied this part from Witherspoon,
and this is just the same as Zaius.
Maybe Joel has some comments on this?

>> +             };
>> > +   };
>> +
>>  };
>>
>>  &fmc {
>> @@ -44,6 +56,16 @@
>> >     };
>>  };
>>
>> +&lpc_ctrl {
>> > +   status = "okay";
>> > +   memory-region = <&flash_memory>;
>> > +   flash = <&spi1>;
>> +};
>> +
>> +&mbox {
>> > +   status = "okay";
>> +};
>
> This looks fine.
>
> Andrew
>> +
>>  &uart5 {
>> >     status = "okay";
>>  };

Re: [PATCH linux dev-4.7 1/3] ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

[Joel Stanley]

On Thu, Feb 16, 2017 at 2:02 PM, Mine <mine260309@gmail.com> wrote:
> Hi Andrew,
>
> On Thu, Feb 16, 2017 at 9:12 AM, Andrew Jeffery <andrew@aj.id.au> wrote:
>> Hi Lei,
>>
>> On Tue, 2017-02-14 at 15:25 +0800, Lei YU wrote:
>>> Also add the reserved-memory node needed by the LPC
>>> control driver.
>>>
>>> > Signed-off-by: Lei YU <mine260309@gmail.com>
>>> ---
>>>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
>>>  1 file changed, 22 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>>> index c23627e..f47eb63 100644
>>> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>>> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
>>> @@ -19,6 +19,18 @@
>>> >     memory {
>>> >             reg = <0x80000000 0x40000000>;
>>> >     };
>>> +
>>> > +   reserved-memory {
>>> > +           #address-cells = <1>;
>>> > +           #size-cells = <1>;
>>> > +           ranges;
>>> +
>>> > > +         flash_memory: region@94000000 {
>>> > +                   no-map;
>>> +                     reg = <0x94000000 0x04000000>; /* 64M */
>>
>> So these values are also used in the zaius dts. Why are we reserving
>> 64M 128M down from the top of the RAM address space? Is the top 64M
>> meant to be reserved for anything as well? Why not reserve the top 64M?

The top 64MB is for the host VGA framebuffer.

$ python3 -c "print(((0x80000000 + 0x40000000) - (0x94000000 +
0x04000000)) /1024./1024.)"
640.0

There was a mistake made due to not knowing the size of Zaius' DRAM,
so things are 512MB lower than they should be.

> This is a good question, but honestly I just copied this part from Witherspoon,
> and this is just the same as Zaius.

> Maybe Joel has some comments on this?

The intent was to leave a 64MB window for the host framebuffer, and
then put the 64MB buffer for mbox below.

Can you please fix up this patch and also send one to fix Zaius?

Cheers,

Joel

Re: [PATCH linux dev-4.7 1/3] ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

[Joel Stanley]

On Tue, Feb 14, 2017 at 5:55 PM, Lei YU <mine260309@gmail.com> wrote:
> +&lpc_ctrl {
> +       status = "okay";
> +       memory-region = <&flash_memory>;
> +       flash = <&spi1>;
> +};
> +
> +&mbox {
> +       status = "okay";
> +};
> +

Lei,

I applied this part of the patch as the other part was applied as part
of "ARM: dts: aspeed: Reserve RAM on P9 machines".

Cheers,

Joel