* Re: [PATCH] arm: dts: aspeed-bmc-tiogapass: enable second MAC
[not found] <20200930192507.27847-1-fercerpav@gmail.com>
@ 2020-10-28 5:51 ` Joel Stanley
2020-11-12 19:14 ` Vijay Khemka
0 siblings, 1 reply; 3+ messages in thread
From: Joel Stanley @ 2020-10-28 5:51 UTC (permalink / raw)
To: Paul Fertser, Vijay Khemka; +Cc: Linux ARM, linux-aspeed
On Wed, 30 Sep 2020 at 19:27, Paul Fertser <fercerpav@gmail.com> wrote:
>
> Tioga Pass reference design includes Intel I210 Ethernet controller
> connected to the BMC with NC/SI.
>
> MAC readout is not supported.
>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Vijay, can I get a review from you on this one please?
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> index 2d44d9ad4e40..b2ba798bf3c4 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> @@ -196,6 +196,14 @@
> use-ncsi;
> };
>
> +&mac1 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii2_default>;
> + use-ncsi;
> +};
> +
> &adc {
> status = "okay";
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: dts: aspeed-bmc-tiogapass: enable second MAC
2020-10-28 5:51 ` [PATCH] arm: dts: aspeed-bmc-tiogapass: enable second MAC Joel Stanley
@ 2020-11-12 19:14 ` Vijay Khemka
2020-11-16 6:01 ` Joel Stanley
0 siblings, 1 reply; 3+ messages in thread
From: Vijay Khemka @ 2020-11-12 19:14 UTC (permalink / raw)
To: Joel Stanley, Paul Fertser; +Cc: Linux ARM, linux-aspeed
On 10/27/20, 10:51 PM, "Joel Stanley" <joel@jms.id.au> wrote:
On Wed, 30 Sep 2020 at 19:27, Paul Fertser <fercerpav@gmail.com> wrote:
>
> Tioga Pass reference design includes Intel I210 Ethernet controller
> connected to the BMC with NC/SI.
>
> MAC readout is not supported.
>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-by: Vijay Khemka<vijaykhemkalinux@gmail.com>
Tested-by: Vijay Khemka<vijaykhemkalinux@gmail.com>
Vijay, can I get a review from you on this one please?
Sorry Joel, for late response, I have tested and verified this yesterday
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> index 2d44d9ad4e40..b2ba798bf3c4 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> @@ -196,6 +196,14 @@
> use-ncsi;
> };
>
> +&mac1 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rmii2_default>;
> + use-ncsi;
> +};
> +
> &adc {
> status = "okay";
> };
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: dts: aspeed-bmc-tiogapass: enable second MAC
2020-11-12 19:14 ` Vijay Khemka
@ 2020-11-16 6:01 ` Joel Stanley
0 siblings, 0 replies; 3+ messages in thread
From: Joel Stanley @ 2020-11-16 6:01 UTC (permalink / raw)
To: Vijay Khemka; +Cc: Paul Fertser, Linux ARM, linux-aspeed
On Thu, 12 Nov 2020 at 19:14, Vijay Khemka <vijaykhemka@fb.com> wrote:
>
>
>
> On 10/27/20, 10:51 PM, "Joel Stanley" <joel@jms.id.au> wrote:
>
> On Wed, 30 Sep 2020 at 19:27, Paul Fertser <fercerpav@gmail.com> wrote:
> >
> > Tioga Pass reference design includes Intel I210 Ethernet controller
> > connected to the BMC with NC/SI.
> >
> > MAC readout is not supported.
> >
> > Signed-off-by: Paul Fertser <fercerpav@gmail.com>
> Reviewed-by: Vijay Khemka<vijaykhemkalinux@gmail.com>
> Tested-by: Vijay Khemka<vijaykhemkalinux@gmail.com>
>
>
> Vijay, can I get a review from you on this one please?
>
> Sorry Joel, for late response, I have tested and verified this yesterday
Thanks for taking a look.
Paul, in the future please use scripts/get_maintainers.pl in the
kernel tree to send this patch to the correct location. Importantly,
you should cc linux-arm-kernel and myself (as the maintainer).
I've merged this for 5.11.
Cheers,
Joel
>
> > ---
> > arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> > index 2d44d9ad4e40..b2ba798bf3c4 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts
> > @@ -196,6 +196,14 @@
> > use-ncsi;
> > };
> >
> > +&mac1 {
> > + status = "okay";
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_rmii2_default>;
> > + use-ncsi;
> > +};
> > +
> > &adc {
> > status = "okay";
> > };
> > --
> > 2.17.1
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-16 6:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200930192507.27847-1-fercerpav@gmail.com>
2020-10-28 5:51 ` [PATCH] arm: dts: aspeed-bmc-tiogapass: enable second MAC Joel Stanley
2020-11-12 19:14 ` Vijay Khemka
2020-11-16 6:01 ` Joel Stanley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.