* [PATCH] NET5501: Change active_low to 0 for LED driver.
@ 2012-04-10 23:45 Bjarke Istrup Pedersen
2012-04-13 22:17 ` Bjarke Istrup Pedersen
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Bjarke Istrup Pedersen @ 2012-04-10 23:45 UTC (permalink / raw)
To: linux-kernel; +Cc: philipp, Bjarke Istrup Pedersen
It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.
The wiki article about it confuses it, since it contradicts
itself, regarding what turns on the LED.
I have tested 3.4-rc2 on my net5501 with this patch, and it
makes the LED behave correctly, where "none" turns it off, and
"default-on" turns it on, when echoed onto the trigger "file"
in /sys/class/leds.
Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
---
arch/x86/platform/geode/net5501.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
index 66d377e..646e3b5 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
.name = "net5501:1",
.gpio = 6,
.default_trigger = "default-on",
- .active_low = 1,
+ .active_low = 0,
},
};
--
1.7.8.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] NET5501: Change active_low to 0 for LED driver.
2012-04-10 23:45 [PATCH] NET5501: Change active_low to 0 for LED driver Bjarke Istrup Pedersen
@ 2012-04-13 22:17 ` Bjarke Istrup Pedersen
2012-04-13 22:19 ` Philip Prindeville
2012-04-14 0:42 ` Bjarke Istrup Pedersen
2012-04-14 17:27 ` Bjarke Istrup Pedersen
2 siblings, 1 reply; 9+ messages in thread
From: Bjarke Istrup Pedersen @ 2012-04-13 22:17 UTC (permalink / raw)
To: linux-kernel; +Cc: philipp
11. apr. 2012 01.45 skrev Bjarke Istrup Pedersen <gurligebis@gentoo.org>:
> It seems that there was an error with the active_low = 1 for the
> LED, since it should be set to 0 (meaning that active is high,
> since 0 is false, hence the confusion.
>
> The wiki article about it confuses it, since it contradicts
> itself, regarding what turns on the LED.
>
> I have tested 3.4-rc2 on my net5501 with this patch, and it
> makes the LED behave correctly, where "none" turns it off, and
> "default-on" turns it on, when echoed onto the trigger "file"
> in /sys/class/leds.
>
> Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
> ---
> arch/x86/platform/geode/net5501.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
> index 66d377e..646e3b5 100644
> --- a/arch/x86/platform/geode/net5501.c
> +++ b/arch/x86/platform/geode/net5501.c
> @@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
> .name = "net5501:1",
> .gpio = 6,
> .default_trigger = "default-on",
> - .active_low = 1,
> + .active_low = 0,
> },
> };
>
> --
> 1.7.8.5
>
I have tried sending it to linux-geode, but the list seems to reject
mails from me for some reason.
Anyone able to forward it to the right people for inclusion in 3.4-rcX ?
Thanks in advance,
Bjarke
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] NET5501: Change active_low to 0 for LED driver.
2012-04-13 22:17 ` Bjarke Istrup Pedersen
@ 2012-04-13 22:19 ` Philip Prindeville
2012-04-13 22:33 ` Bjarke Istrup Pedersen
0 siblings, 1 reply; 9+ messages in thread
From: Philip Prindeville @ 2012-04-13 22:19 UTC (permalink / raw)
To: Bjarke Istrup Pedersen; +Cc: linux-kernel
On 4/13/12 3:17 PM, Bjarke Istrup Pedersen wrote:
> 11. apr. 2012 01.45 skrev Bjarke Istrup Pedersen <gurligebis@gentoo.org>:
>> It seems that there was an error with the active_low = 1 for the
>> LED, since it should be set to 0 (meaning that active is high,
>> since 0 is false, hence the confusion.
>>
>> The wiki article about it confuses it, since it contradicts
>> itself, regarding what turns on the LED.
>>
>> I have tested 3.4-rc2 on my net5501 with this patch, and it
>> makes the LED behave correctly, where "none" turns it off, and
>> "default-on" turns it on, when echoed onto the trigger "file"
>> in /sys/class/leds.
>>
>> Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
>> ---
>> arch/x86/platform/geode/net5501.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
>> index 66d377e..646e3b5 100644
>> --- a/arch/x86/platform/geode/net5501.c
>> +++ b/arch/x86/platform/geode/net5501.c
>> @@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
>> .name = "net5501:1",
>> .gpio = 6,
>> .default_trigger = "default-on",
>> - .active_low = 1,
>> + .active_low = 0,
>> },
>> };
>>
>> --
>> 1.7.8.5
>>
>
> I have tried sending it to linux-geode, but the list seems to reject
> mails from me for some reason.
> Anyone able to forward it to the right people for inclusion in 3.4-rcX ?
>
> Thanks in advance,
> Bjarke
The linux-geode list is currently buggered and without an owner, as far as I know.
-Philip
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] NET5501: Change active_low to 0 for LED driver.
2012-04-13 22:19 ` Philip Prindeville
@ 2012-04-13 22:33 ` Bjarke Istrup Pedersen
2012-04-13 23:22 ` Philip Prindeville
0 siblings, 1 reply; 9+ messages in thread
From: Bjarke Istrup Pedersen @ 2012-04-13 22:33 UTC (permalink / raw)
To: Philip Prindeville; +Cc: linux-kernel
14. apr. 2012 00.19 skrev Philip Prindeville
<philipp_subx@redfish-solutions.com>:
> On 4/13/12 3:17 PM, Bjarke Istrup Pedersen wrote:
>> 11. apr. 2012 01.45 skrev Bjarke Istrup Pedersen <gurligebis@gentoo.org>:
>>> It seems that there was an error with the active_low = 1 for the
>>> LED, since it should be set to 0 (meaning that active is high,
>>> since 0 is false, hence the confusion.
>>>
>>> The wiki article about it confuses it, since it contradicts
>>> itself, regarding what turns on the LED.
>>>
>>> I have tested 3.4-rc2 on my net5501 with this patch, and it
>>> makes the LED behave correctly, where "none" turns it off, and
>>> "default-on" turns it on, when echoed onto the trigger "file"
>>> in /sys/class/leds.
>>>
>>> Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
>>> ---
>>> arch/x86/platform/geode/net5501.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
>>> index 66d377e..646e3b5 100644
>>> --- a/arch/x86/platform/geode/net5501.c
>>> +++ b/arch/x86/platform/geode/net5501.c
>>> @@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
>>> .name = "net5501:1",
>>> .gpio = 6,
>>> .default_trigger = "default-on",
>>> - .active_low = 1,
>>> + .active_low = 0,
>>> },
>>> };
>>>
>>> --
>>> 1.7.8.5
>>>
>>
>> I have tried sending it to linux-geode, but the list seems to reject
>> mails from me for some reason.
>> Anyone able to forward it to the right people for inclusion in 3.4-rcX ?
>>
>> Thanks in advance,
>> Bjarke
>
> The linux-geode list is currently buggered and without an owner, as far as I know.
>
> -Philip
That would explain it :)
Do you have a chance to push it upstream, like your changes? (Not sure
who I should poke about it)
/Bjarke
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] NET5501: Change active_low to 0 for LED driver.
2012-04-13 22:33 ` Bjarke Istrup Pedersen
@ 2012-04-13 23:22 ` Philip Prindeville
2012-04-14 0:43 ` Bjarke Istrup Pedersen
0 siblings, 1 reply; 9+ messages in thread
From: Philip Prindeville @ 2012-04-13 23:22 UTC (permalink / raw)
To: Bjarke Istrup Pedersen; +Cc: linux-kernel
On 4/13/12 3:33 PM, Bjarke Istrup Pedersen wrote:
> 14. apr. 2012 00.19 skrev Philip Prindeville
> <philipp_subx@redfish-solutions.com>:
>> On 4/13/12 3:17 PM, Bjarke Istrup Pedersen wrote:
>>> 11. apr. 2012 01.45 skrev Bjarke Istrup Pedersen <gurligebis@gentoo.org>:
>>>> It seems that there was an error with the active_low = 1 for the
>>>> LED, since it should be set to 0 (meaning that active is high,
>>>> since 0 is false, hence the confusion.
>>>>
>>>> The wiki article about it confuses it, since it contradicts
>>>> itself, regarding what turns on the LED.
>>>>
>>>> I have tested 3.4-rc2 on my net5501 with this patch, and it
>>>> makes the LED behave correctly, where "none" turns it off, and
>>>> "default-on" turns it on, when echoed onto the trigger "file"
>>>> in /sys/class/leds.
>>>>
>>>> Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
>>>> ---
>>>> arch/x86/platform/geode/net5501.c | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
>>>> index 66d377e..646e3b5 100644
>>>> --- a/arch/x86/platform/geode/net5501.c
>>>> +++ b/arch/x86/platform/geode/net5501.c
>>>> @@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
>>>> .name = "net5501:1",
>>>> .gpio = 6,
>>>> .default_trigger = "default-on",
>>>> - .active_low = 1,
>>>> + .active_low = 0,
>>>> },
>>>> };
>>>>
>>>> --
>>>> 1.7.8.5
>>>>
>>> I have tried sending it to linux-geode, but the list seems to reject
>>> mails from me for some reason.
>>> Anyone able to forward it to the right people for inclusion in 3.4-rcX ?
>>>
>>> Thanks in advance,
>>> Bjarke
>> The linux-geode list is currently buggered and without an owner, as far as I know.
>>
>> -Philip
> That would explain it :)
>
> Do you have a chance to push it upstream, like your changes? (Not sure
> who I should poke about it)
>
> /Bjarke
>
I'd copy it to Andrew Morton, and maybe also platform-driver-x86@vger.kernel.org ...
-Philip
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] NET5501: Change active_low to 0 for LED driver.
2012-04-13 23:22 ` Philip Prindeville
@ 2012-04-14 0:43 ` Bjarke Istrup Pedersen
0 siblings, 0 replies; 9+ messages in thread
From: Bjarke Istrup Pedersen @ 2012-04-14 0:43 UTC (permalink / raw)
To: Philip Prindeville; +Cc: linux-kernel
14. apr. 2012 01.22 skrev Philip Prindeville
<philipp_subx@redfish-solutions.com>:
> On 4/13/12 3:33 PM, Bjarke Istrup Pedersen wrote:
>> 14. apr. 2012 00.19 skrev Philip Prindeville
>> <philipp_subx@redfish-solutions.com>:
>>> On 4/13/12 3:17 PM, Bjarke Istrup Pedersen wrote:
>>>> 11. apr. 2012 01.45 skrev Bjarke Istrup Pedersen <gurligebis@gentoo.org>:
>>>>> It seems that there was an error with the active_low = 1 for the
>>>>> LED, since it should be set to 0 (meaning that active is high,
>>>>> since 0 is false, hence the confusion.
>>>>>
>>>>> The wiki article about it confuses it, since it contradicts
>>>>> itself, regarding what turns on the LED.
>>>>>
>>>>> I have tested 3.4-rc2 on my net5501 with this patch, and it
>>>>> makes the LED behave correctly, where "none" turns it off, and
>>>>> "default-on" turns it on, when echoed onto the trigger "file"
>>>>> in /sys/class/leds.
>>>>>
>>>>> Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
>>>>> ---
>>>>> arch/x86/platform/geode/net5501.c | 2 +-
>>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
>>>>> index 66d377e..646e3b5 100644
>>>>> --- a/arch/x86/platform/geode/net5501.c
>>>>> +++ b/arch/x86/platform/geode/net5501.c
>>>>> @@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
>>>>> .name = "net5501:1",
>>>>> .gpio = 6,
>>>>> .default_trigger = "default-on",
>>>>> - .active_low = 1,
>>>>> + .active_low = 0,
>>>>> },
>>>>> };
>>>>>
>>>>> --
>>>>> 1.7.8.5
>>>>>
>>>> I have tried sending it to linux-geode, but the list seems to reject
>>>> mails from me for some reason.
>>>> Anyone able to forward it to the right people for inclusion in 3.4-rcX ?
>>>>
>>>> Thanks in advance,
>>>> Bjarke
>>> The linux-geode list is currently buggered and without an owner, as far as I know.
>>>
>>> -Philip
>> That would explain it :)
>>
>> Do you have a chance to push it upstream, like your changes? (Not sure
>> who I should poke about it)
>>
>> /Bjarke
>>
>
> I'd copy it to Andrew Morton, and maybe also platform-driver-x86@vger.kernel.org ...
Forwarded to andrew and that mailing list :)
Lets hope that works, and doesn't gives errors like linux-geode list :)
/Bjarke
> -Philip
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] NET5501: Change active_low to 0 for LED driver.
2012-04-10 23:45 [PATCH] NET5501: Change active_low to 0 for LED driver Bjarke Istrup Pedersen
2012-04-13 22:17 ` Bjarke Istrup Pedersen
@ 2012-04-14 0:42 ` Bjarke Istrup Pedersen
2012-04-14 17:27 ` Bjarke Istrup Pedersen
2 siblings, 0 replies; 9+ messages in thread
From: Bjarke Istrup Pedersen @ 2012-04-14 0:42 UTC (permalink / raw)
To: akpm, platform-driver-x86
It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.
The wiki article about it confuses it, since it contradicts
itself, regarding what turns on the LED.
I have tested 3.4-rc2 on my net5501 with this patch, and it
makes the LED behave correctly, where "none" turns it off, and
"default-on" turns it on, when echoed onto the trigger "file"
in /sys/class/leds.
Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
---
arch/x86/platform/geode/net5501.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/geode/net5501.c
b/arch/x86/platform/geode/net5501.c
index 66d377e..646e3b5 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
.name = "net5501:1",
.gpio = 6,
.default_trigger = "default-on",
- .active_low = 1,
+ .active_low = 0,
},
};
--
1.7.8.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] NET5501: Change active_low to 0 for LED driver.
2012-04-10 23:45 [PATCH] NET5501: Change active_low to 0 for LED driver Bjarke Istrup Pedersen
2012-04-13 22:17 ` Bjarke Istrup Pedersen
2012-04-14 0:42 ` Bjarke Istrup Pedersen
@ 2012-04-14 17:27 ` Bjarke Istrup Pedersen
2 siblings, 0 replies; 9+ messages in thread
From: Bjarke Istrup Pedersen @ 2012-04-14 17:27 UTC (permalink / raw)
To: platform-driver-x86
It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.
The wiki article about it confuses it, since it contradicts
itself, regarding what turns on the LED.
I have tested 3.4-rc2 on my net5501 with this patch, and it
makes the LED behave correctly, where "none" turns it off, and
"default-on" turns it on, when echoed onto the trigger "file"
in /sys/class/leds.
Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
---
arch/x86/platform/geode/net5501.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/geode/net5501.c
b/arch/x86/platform/geode/net5501.c
index 66d377e..646e3b5 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
.name = "net5501:1",
.gpio = 6,
.default_trigger = "default-on",
- .active_low = 1,
+ .active_low = 0,
},
};
--
1.7.8.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] NET5501: Change active_low to 0 for LED driver.
@ 2012-04-14 17:42 Bjarke Istrup Pedersen
0 siblings, 0 replies; 9+ messages in thread
From: Bjarke Istrup Pedersen @ 2012-04-14 17:42 UTC (permalink / raw)
To: platform-driver-x86; +Cc: Bjarke Istrup Pedersen
It seems that there was an error with the active_low = 1 for the
LED, since it should be set to 0 (meaning that active is high,
since 0 is false, hence the confusion.
The wiki article about it confuses it, since it contradicts
itself, regarding what turns on the LED.
I have tested 3.4-rc2 on my net5501 with this patch, and it
makes the LED behave correctly, where "none" turns it off, and
"default-on" turns it on, when echoed onto the trigger "file"
in /sys/class/leds.
Signed-off-by: Bjarke Istrup Pedersen <gurligebis@gentoo.org>
---
arch/x86/platform/geode/net5501.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/platform/geode/net5501.c b/arch/x86/platform/geode/net5501.c
index 66d377e..646e3b5 100644
--- a/arch/x86/platform/geode/net5501.c
+++ b/arch/x86/platform/geode/net5501.c
@@ -63,7 +63,7 @@ static struct gpio_led net5501_leds[] = {
.name = "net5501:1",
.gpio = 6,
.default_trigger = "default-on",
- .active_low = 1,
+ .active_low = 0,
},
};
--
1.7.8.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-04-14 17:43 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-10 23:45 [PATCH] NET5501: Change active_low to 0 for LED driver Bjarke Istrup Pedersen
2012-04-13 22:17 ` Bjarke Istrup Pedersen
2012-04-13 22:19 ` Philip Prindeville
2012-04-13 22:33 ` Bjarke Istrup Pedersen
2012-04-13 23:22 ` Philip Prindeville
2012-04-14 0:43 ` Bjarke Istrup Pedersen
2012-04-14 0:42 ` Bjarke Istrup Pedersen
2012-04-14 17:27 ` Bjarke Istrup Pedersen
2012-04-14 17:42 Bjarke Istrup Pedersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.