From: Richard Genoud <richard.genoud@gmail.com> To: Mark Brown <broonie@kernel.org> Cc: "Nicolas Ferre" <nicolas.ferre@atmel.com>, "Liam Girdwood" <lgirdwood@gmail.com>, "Bo Shen" <voice.shen@atmel.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Date: Tue, 9 Jul 2013 10:19:45 +0200 [thread overview] Message-ID: <CACQ1gAgJyTSdxAKK7uwG-ybE2ddC90podM3+tOAqQwZUspsU8Q@mail.gmail.com> (raw) In-Reply-To: <20130708150721.GK27646@sirena.org.uk> 2013/7/8 Mark Brown <broonie@kernel.org>: > On Mon, Jul 08, 2013 at 03:29:49PM +0200, Richard Genoud wrote: > >> + * Nicolas Ferre <nicolas.ferre@atmel.com> >> + * >> + * Based on sam9g20_wm8731.c by: >> + * Sedji Gaouaou <sedji.gaouaou@atmel.com> > > The obvious question here is of course if we can use the same driver for > both of them. I haven't got a g20 to test that, but that's the goal. For now, g20 is still non-DT, so I think it's best to have a DT-only driver like this one for the 9x5 family (9g15, 9g25, 9x25, 9g35, 9x25). When the g20 will move to DT completely, we can drop sam9g20_wm8731.c and adjust sam9x5_wm8731.c (mainly master clock and widgets it seems) By the way, maybe g45 could use that also (and SAMA5 ?) > >> + codec_dai->driver->playback.rates &= SNDRV_PCM_RATE_8000 | >> + SNDRV_PCM_RATE_32000 | >> + SNDRV_PCM_RATE_48000 | >> + SNDRV_PCM_RATE_96000; >> + codec_dai->driver->capture.rates &= SNDRV_PCM_RATE_8000 | >> + SNDRV_PCM_RATE_32000 | >> + SNDRV_PCM_RATE_48000 | >> + SNDRV_PCM_RATE_96000; > > You definitely shouldn't be fiddling with a driver's constant static > data. You want to be using snd_pcm_hw_constraint() APIs to set > additional constraints intead. Ok, I'll change that. Thanks ! -- for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
WARNING: multiple messages have this Message-ID (diff)
From: richard.genoud@gmail.com (Richard Genoud) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Date: Tue, 9 Jul 2013 10:19:45 +0200 [thread overview] Message-ID: <CACQ1gAgJyTSdxAKK7uwG-ybE2ddC90podM3+tOAqQwZUspsU8Q@mail.gmail.com> (raw) In-Reply-To: <20130708150721.GK27646@sirena.org.uk> 2013/7/8 Mark Brown <broonie@kernel.org>: > On Mon, Jul 08, 2013 at 03:29:49PM +0200, Richard Genoud wrote: > >> + * Nicolas Ferre <nicolas.ferre@atmel.com> >> + * >> + * Based on sam9g20_wm8731.c by: >> + * Sedji Gaouaou <sedji.gaouaou@atmel.com> > > The obvious question here is of course if we can use the same driver for > both of them. I haven't got a g20 to test that, but that's the goal. For now, g20 is still non-DT, so I think it's best to have a DT-only driver like this one for the 9x5 family (9g15, 9g25, 9x25, 9g35, 9x25). When the g20 will move to DT completely, we can drop sam9g20_wm8731.c and adjust sam9x5_wm8731.c (mainly master clock and widgets it seems) By the way, maybe g45 could use that also (and SAMA5 ?) > >> + codec_dai->driver->playback.rates &= SNDRV_PCM_RATE_8000 | >> + SNDRV_PCM_RATE_32000 | >> + SNDRV_PCM_RATE_48000 | >> + SNDRV_PCM_RATE_96000; >> + codec_dai->driver->capture.rates &= SNDRV_PCM_RATE_8000 | >> + SNDRV_PCM_RATE_32000 | >> + SNDRV_PCM_RATE_48000 | >> + SNDRV_PCM_RATE_96000; > > You definitely shouldn't be fiddling with a driver's constant static > data. You want to be using snd_pcm_hw_constraint() APIs to set > additional constraints intead. Ok, I'll change that. Thanks ! -- for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?
next prev parent reply other threads:[~2013-07-09 8:20 UTC|newest] Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-07-08 13:29 [PATCH v2 0/5] Sound support for at91sam9x5-wm8731 based boards Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 13:29 ` [PATCH v2 1/5] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 14:39 ` [alsa-devel] " Lars-Peter Clausen 2013-07-08 14:39 ` Lars-Peter Clausen 2013-07-09 7:37 ` Richard Genoud 2013-07-09 7:37 ` Richard Genoud 2013-07-08 15:07 ` Mark Brown 2013-07-08 15:07 ` Mark Brown 2013-07-08 15:07 ` Mark Brown 2013-07-09 8:19 ` Richard Genoud [this message] 2013-07-09 8:19 ` Richard Genoud 2013-07-09 8:37 ` Bo Shen 2013-07-09 8:37 ` Bo Shen 2013-07-09 9:29 ` Mark Brown 2013-07-09 9:29 ` Mark Brown 2013-07-09 9:29 ` Mark Brown 2013-07-09 10:27 ` Richard Genoud 2013-07-09 10:27 ` Richard Genoud 2013-07-09 10:27 ` Richard Genoud 2013-07-08 13:29 ` [PATCH v2 2/5] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 15:07 ` Mark Brown 2013-07-08 15:07 ` Mark Brown 2013-07-08 15:07 ` Mark Brown 2013-07-09 8:27 ` Richard Genoud 2013-07-09 8:27 ` Richard Genoud 2013-07-09 8:27 ` Richard Genoud 2013-07-09 9:32 ` Mark Brown 2013-07-09 9:32 ` Mark Brown 2013-07-09 9:32 ` Mark Brown 2013-07-09 9:46 ` Richard Genoud 2013-07-09 9:46 ` Richard Genoud 2013-07-08 13:29 ` [PATCH v2 3/5] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 14:36 ` [alsa-devel] " Mark Brown 2013-07-08 14:36 ` Mark Brown 2013-07-08 14:36 ` Mark Brown 2013-07-08 13:29 ` [PATCH v2 4/5] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 13:29 ` [PATCH v2 5/5] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud 2013-07-08 13:29 ` Richard Genoud 2013-07-08 13:53 ` [PATCH v2 0/5] Sound support for at91sam9x5-wm8731 based boards Nicolas Ferre 2013-07-08 13:53 ` Nicolas Ferre 2013-07-08 13:53 ` Nicolas Ferre 2013-07-09 12:28 ` [PATCH v3 0/7] " Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 12:28 ` [PATCH v3 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 12:28 ` [PATCH v3 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 12:28 ` [PATCH v3 3/7] Documentation: DT: update atmel SSC with DMA binding Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 13:19 ` Richard Genoud 2013-07-09 13:19 ` Richard Genoud 2013-07-09 13:20 ` Nicolas Ferre 2013-07-09 13:20 ` Nicolas Ferre 2013-07-09 13:20 ` Nicolas Ferre 2013-07-09 13:31 ` Richard Genoud 2013-07-09 13:31 ` Richard Genoud 2013-07-09 12:28 ` [PATCH v3 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 12:28 ` [PATCH v3 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 12:28 ` [PATCH v3 6/7] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 12:28 ` [PATCH v3 7/7] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud 2013-07-09 12:28 ` Richard Genoud 2013-07-09 14:25 ` [PATCH v4 0/7] Sound support for at91sam9x5-wm8731 based boards Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:25 ` [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:59 ` Mark Brown 2013-07-09 14:59 ` Mark Brown 2013-07-09 14:59 ` Mark Brown 2013-07-10 9:25 ` Richard Genoud 2013-07-10 9:25 ` Richard Genoud 2013-07-10 10:00 ` Mark Brown 2013-07-10 10:00 ` Mark Brown 2013-07-10 10:00 ` Mark Brown 2013-07-10 6:11 ` Bo Shen 2013-07-10 6:11 ` Bo Shen 2013-07-10 9:30 ` Richard Genoud 2013-07-10 9:30 ` Richard Genoud 2013-07-10 9:30 ` Richard Genoud 2013-07-09 14:25 ` [PATCH v4 2/7] Documentation: DT: add sam9x5ek-wm8731 machine driver Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 15:01 ` Mark Brown 2013-07-09 15:01 ` Mark Brown 2013-07-09 15:01 ` Mark Brown 2013-07-10 9:32 ` Richard Genoud 2013-07-10 9:32 ` Richard Genoud 2013-07-10 9:32 ` Richard Genoud 2013-07-09 14:25 ` [PATCH v4 3/7] Documentation: DT: update atmel SSC with DMA binding Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 15:05 ` Mark Brown 2013-07-09 15:05 ` Mark Brown 2013-07-09 15:05 ` Mark Brown 2013-07-10 9:48 ` Richard Genoud 2013-07-10 9:48 ` Richard Genoud 2013-07-10 10:01 ` Mark Brown 2013-07-10 10:01 ` Mark Brown 2013-07-09 14:25 ` [PATCH v4 4/7] ARM: AT91: DTS: sam9x5: add SSC DMA parameters Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:25 ` [PATCH v4 5/7] ARM: AT91: DTS: sam9x5ek: add WM8731 codec Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:25 ` [PATCH v4 6/7] ARM: AT91: DTS: sam9x5ek: add sound configuration Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:25 ` [PATCH v4 7/7] ARM: AT91: DTS: sam9x5ek: enable SSC Richard Genoud 2013-07-09 14:25 ` Richard Genoud 2013-07-09 14:42 ` [PATCH v4 0/7] Sound support for at91sam9x5-wm8731 based boards Mark Brown 2013-07-09 14:42 ` Mark Brown 2013-07-09 14:52 ` Richard Genoud 2013-07-09 14:52 ` Richard Genoud 2013-07-09 14:52 ` Richard Genoud
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACQ1gAgJyTSdxAKK7uwG-ybE2ddC90podM3+tOAqQwZUspsU8Q@mail.gmail.com \ --to=richard.genoud@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nicolas.ferre@atmel.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=voice.shen@atmel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.