All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Genoud <richard.genoud@gmail.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Nicolas Ferre" <nicolas.ferre@atmel.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/7] tty/serial: at91: use mctrl_gpio helpers
Date: Tue, 18 Feb 2014 16:09:28 +0100	[thread overview]
Message-ID: <CACQ1gAhOxMdjMGUFS68LijMTdZdsOX0zzww2QBVVsDdPYMEh_g@mail.gmail.com> (raw)
In-Reply-To: <20140218190442.b5f5668e02e2dda0bf45d0b4@mail.ru>

2014-02-18 16:04 GMT+01:00 Alexander Shiyan <shc_work@mail.ru>:
> On Mon, 17 Feb 2014 17:57:24 +0100
> Richard Genoud <richard.genoud@gmail.com> wrote:
>
>> On sam9x5, dedicated CTS (and RTS) pins are unusable together with the
>> LCDC, the EMAC, or the MMC because they share the same line.
>>
>> Moreover, the USART controller doesn't handle DTR/DSR/DCD/RI signals,
>> so we have to control them via GPIO.
>>
>> This patch permits to use GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI
>> signals.
>>
>> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ...
>> diff --git a/arch/arm/mach-at91/at91rm9200_devices.c b/arch/arm/mach-at91/at91rm9200_devices.c
>> index 605add05af7e..6dd386e3d9fe 100644
>> --- a/arch/arm/mach-at91/at91rm9200_devices.c
>> +++ b/arch/arm/mach-at91/at91rm9200_devices.c
> ...
>> @@ -961,7 +961,14 @@ static struct resource uart0_resources[] = {
>>  static struct atmel_uart_data uart0_data = {
>>       .use_dma_tx     = 1,
>>       .use_dma_rx     = 1,
>> -     .rts_gpio       = -EINVAL,
>> +};
>> +
>> +struct gpiod_lookup_table uart0_gpios_table = {
>
> static
arg ! I missed this one !
good catch !

>> +     .dev_id = "atmel_usart",
>> +     .table = {
>> +             GPIO_LOOKUP("pioA", 21, "rts", GPIO_ACTIVE_LOW),
>> +             { },
>> +     },
>>  };
> ...
>
> --
> Alexander Shiyan <shc_work@mail.ru>



-- 
for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?

WARNING: multiple messages have this Message-ID (diff)
From: richard.genoud@gmail.com (Richard Genoud)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/7] tty/serial: at91: use mctrl_gpio helpers
Date: Tue, 18 Feb 2014 16:09:28 +0100	[thread overview]
Message-ID: <CACQ1gAhOxMdjMGUFS68LijMTdZdsOX0zzww2QBVVsDdPYMEh_g@mail.gmail.com> (raw)
In-Reply-To: <20140218190442.b5f5668e02e2dda0bf45d0b4@mail.ru>

2014-02-18 16:04 GMT+01:00 Alexander Shiyan <shc_work@mail.ru>:
> On Mon, 17 Feb 2014 17:57:24 +0100
> Richard Genoud <richard.genoud@gmail.com> wrote:
>
>> On sam9x5, dedicated CTS (and RTS) pins are unusable together with the
>> LCDC, the EMAC, or the MMC because they share the same line.
>>
>> Moreover, the USART controller doesn't handle DTR/DSR/DCD/RI signals,
>> so we have to control them via GPIO.
>>
>> This patch permits to use GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI
>> signals.
>>
>> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ...
>> diff --git a/arch/arm/mach-at91/at91rm9200_devices.c b/arch/arm/mach-at91/at91rm9200_devices.c
>> index 605add05af7e..6dd386e3d9fe 100644
>> --- a/arch/arm/mach-at91/at91rm9200_devices.c
>> +++ b/arch/arm/mach-at91/at91rm9200_devices.c
> ...
>> @@ -961,7 +961,14 @@ static struct resource uart0_resources[] = {
>>  static struct atmel_uart_data uart0_data = {
>>       .use_dma_tx     = 1,
>>       .use_dma_rx     = 1,
>> -     .rts_gpio       = -EINVAL,
>> +};
>> +
>> +struct gpiod_lookup_table uart0_gpios_table = {
>
> static
arg ! I missed this one !
good catch !

>> +     .dev_id = "atmel_usart",
>> +     .table = {
>> +             GPIO_LOOKUP("pioA", 21, "rts", GPIO_ACTIVE_LOW),
>> +             { },
>> +     },
>>  };
> ...
>
> --
> Alexander Shiyan <shc_work@mail.ru>



-- 
for me, ck means con kolivas and not calvin klein... does it mean I'm a geek ?

  reply	other threads:[~2014-02-18 15:09 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17 16:57 [PATCH v3 0/7] tty/serial: Add helpers to use GPIOs to control modem lines and implement atmel_serial.c Richard Genoud
2014-02-17 16:57 ` Richard Genoud
2014-02-17 16:57 ` [PATCH v3 1/7] tty/serial: Add GPIOLIB helpers for controlling modem lines Richard Genoud
2014-02-17 16:57   ` Richard Genoud
2014-02-17 18:37   ` Alexander Shiyan
2014-02-17 18:37     ` Alexander Shiyan
2014-02-18  9:59     ` Richard Genoud
2014-02-18  9:59       ` Richard Genoud
2014-02-18 15:26       ` Alexander Shiyan
2014-02-18 15:26         ` Alexander Shiyan
2014-02-20 11:20         ` Richard Genoud
2014-02-20 11:20           ` Richard Genoud
2014-02-17 16:57 ` [PATCH v3 2/7] tty/serial: at91: use dev_err instead of printk Richard Genoud
2014-02-17 16:57   ` Richard Genoud
2014-02-17 16:57 ` [PATCH v3 3/7] tty/serial: at91: remove unused open/close hooks Richard Genoud
2014-02-17 16:57   ` Richard Genoud
2014-02-17 16:57 ` [PATCH v3 4/7] tty/serial: at91: use mctrl_gpio helpers Richard Genoud
2014-02-17 16:57   ` Richard Genoud
2014-02-18 15:04   ` Alexander Shiyan
2014-02-18 15:04     ` Alexander Shiyan
2014-02-18 15:09     ` Richard Genoud [this message]
2014-02-18 15:09       ` Richard Genoud
2014-02-17 16:57 ` [PATCH v3 5/7] ARM: at91: gpio: implement get_direction Richard Genoud
2014-02-17 16:57   ` Richard Genoud
2014-02-24 14:42   ` Linus Walleij
2014-02-24 14:42     ` Linus Walleij
2014-02-17 16:57 ` [PATCH v3 6/7] pinctrl: at91: " Richard Genoud
2014-02-17 16:57   ` Richard Genoud
2014-02-24 14:44   ` Linus Walleij
2014-02-24 14:44     ` Linus Walleij
2014-02-24 14:56     ` Richard Genoud
2014-02-24 14:56       ` Richard Genoud
2014-02-25  9:34       ` Linus Walleij
2014-02-25  9:34         ` Linus Walleij
2014-02-17 16:57 ` [PATCH v3 7/7] tty/serial: at91: add interrupts for modem control lines Richard Genoud
2014-02-17 16:57   ` Richard Genoud
2014-02-17 17:53 ` [PATCH v3 0/7] tty/serial: Add helpers to use GPIOs to control modem lines and implement atmel_serial.c Alexander Shiyan
2014-02-17 17:53   ` Alexander Shiyan
2014-02-18  9:59   ` Richard Genoud
2014-02-18  9:59     ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACQ1gAhOxMdjMGUFS68LijMTdZdsOX0zzww2QBVVsDdPYMEh_g@mail.gmail.com \
    --to=richard.genoud@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=shc_work@mail.ru \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.