* [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950
@ 2019-10-31 10:35 kholk11
2019-10-31 10:35 ` [PATCH 1/4] pinctrl: qcom: spmi-gpio: Add PM/PMI8950 compatibility kholk11
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: kholk11 @ 2019-10-31 10:35 UTC (permalink / raw)
To: linux-arm-msm
Cc: kholk11, marijns95, bjorn.andersson, agross, linus.walleij,
robh+dt, mark.rutland, linux-gpio, devicetree
From: AngeloGioacchino Del Regno <kholk11@gmail.com>
This patch series enables support for GPIOs and MPPs found on the
PM8950 and PMI8950 ICs, usually found on boards using the MSM8956,
MSM8976, MSM8952, MSM8953 (and APQ variants) SoC.
These are important to get the PA_THERM, QUIET_THERM MPPs enabled
on PM8950 for standard thermals (and other board specific ones,
where applicable) and GPIOs usually used to enable the audio mclk
path, the wlan sleep clock and sometimes the eLDO for the WCD codec,
plus other board specific paths, where applicable.
For example, on the MSM8956 Sony Xperia Loire platform, this also
includes a GPIO for the USB switch and one for the simple GPIO
controlled vibrator included in all devices for this series of
boards.
This has been tested on Sony Xperia Loire phones, including the
Xperia X Compact (Kugo) and Xperia X (Suzu).
AngeloGioacchino Del Regno (4):
pinctrl: qcom: spmi-gpio: Add PM/PMI8950 compatibility
dt-bindings: pinctrl: qcom-pmic-gpio: Add support for PM/PMI8950
pinctrl: qcom: spmi-mpp: Add PM/PMI8950 compatible strings
dt-bindings: pinctrl: qcom-pmic-mpp: Add support for PM/PMI8950
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 4 ++++
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 3 +++
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 2 ++
4 files changed, 13 insertions(+)
--
2.21.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] pinctrl: qcom: spmi-gpio: Add PM/PMI8950 compatibility
2019-10-31 10:35 [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 kholk11
@ 2019-10-31 10:35 ` kholk11
2019-10-31 10:35 ` [PATCH 2/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for PM/PMI8950 kholk11
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: kholk11 @ 2019-10-31 10:35 UTC (permalink / raw)
To: linux-arm-msm
Cc: kholk11, marijns95, bjorn.andersson, agross, linus.walleij,
robh+dt, mark.rutland, linux-gpio, devicetree
From: AngeloGioacchino Del Regno <kholk11@gmail.com>
The PM8950 features 8 GPIOs with hole in 3 and PMI8950 has
only two; these PMICs are totally compatible with this driver.
Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index 387917c517d3..653d1095bfea 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1108,6 +1108,9 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pm8005-gpio", .data = (void *) 4 },
{ .compatible = "qcom,pm8916-gpio", .data = (void *) 4 },
{ .compatible = "qcom,pm8941-gpio", .data = (void *) 36 },
+ /* pm8950 has 8 GPIOs with holes on 3 */
+ { .compatible = "qcom,pm8950-gpio", .data = (void *) 8 },
+ { .compatible = "qcom,pmi8950-gpio", .data = (void *) 2 },
{ .compatible = "qcom,pm8994-gpio", .data = (void *) 22 },
{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
{ .compatible = "qcom,pm8998-gpio", .data = (void *) 26 },
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for PM/PMI8950
2019-10-31 10:35 [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 kholk11
2019-10-31 10:35 ` [PATCH 1/4] pinctrl: qcom: spmi-gpio: Add PM/PMI8950 compatibility kholk11
@ 2019-10-31 10:35 ` kholk11
2019-10-31 10:35 ` [PATCH 3/4] pinctrl: qcom: spmi-mpp: Add PM/PMI8950 compatible strings kholk11
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: kholk11 @ 2019-10-31 10:35 UTC (permalink / raw)
To: linux-arm-msm
Cc: kholk11, marijns95, bjorn.andersson, agross, linus.walleij,
robh+dt, mark.rutland, linux-gpio, devicetree
From: AngeloGioacchino Del Regno <kholk11@gmail.com>
Document the bindings for PM8950 and PMI8950 PMIC GPIOs.
Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
index 2f48cca1d581..7be5de8d253f 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
@@ -15,9 +15,11 @@ PMIC's from Qualcomm.
"qcom,pm8917-gpio"
"qcom,pm8921-gpio"
"qcom,pm8941-gpio"
+ "qcom,pm8950-gpio"
"qcom,pm8994-gpio"
"qcom,pm8998-gpio"
"qcom,pma8084-gpio"
+ "qcom,pmi8950-gpio"
"qcom,pmi8994-gpio"
"qcom,pmi8998-gpio"
"qcom,pms405-gpio"
@@ -93,9 +95,11 @@ to specify in a pin configuration subnode:
gpio1-gpio38 for pm8917
gpio1-gpio44 for pm8921
gpio1-gpio36 for pm8941
+ gpio1-gpio8 for pm8950 (hole on gpio3)
gpio1-gpio22 for pm8994
gpio1-gpio26 for pm8998
gpio1-gpio22 for pma8084
+ gpio1-gpio2 for pmi8950
gpio1-gpio10 for pmi8994
gpio1-gpio12 for pms405 (holes on gpio1, gpio9 and gpio10)
gpio1-gpio10 for pm8150 (holes on gpio2, gpio5, gpio7
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] pinctrl: qcom: spmi-mpp: Add PM/PMI8950 compatible strings
2019-10-31 10:35 [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 kholk11
2019-10-31 10:35 ` [PATCH 1/4] pinctrl: qcom: spmi-gpio: Add PM/PMI8950 compatibility kholk11
2019-10-31 10:35 ` [PATCH 2/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for PM/PMI8950 kholk11
@ 2019-10-31 10:35 ` kholk11
2019-10-31 10:35 ` [PATCH 4/4] dt-bindings: pinctrl: qcom-pmic-mpp: Add support for PM/PMI8950 kholk11
2019-11-05 10:20 ` [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 Linus Walleij
4 siblings, 0 replies; 6+ messages in thread
From: kholk11 @ 2019-10-31 10:35 UTC (permalink / raw)
To: linux-arm-msm
Cc: kholk11, marijns95, bjorn.andersson, agross, linus.walleij,
robh+dt, mark.rutland, linux-gpio, devicetree
From: AngeloGioacchino Del Regno <kholk11@gmail.com>
PM8950 and PMI8950 have four MPPs and this driver is compatible.
Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
---
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
index 91407b024cf3..48602dba4967 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
@@ -915,6 +915,8 @@ static const struct of_device_id pmic_mpp_of_match[] = {
{ .compatible = "qcom,pm8841-mpp" }, /* 4 MPP's */
{ .compatible = "qcom,pm8916-mpp" }, /* 4 MPP's */
{ .compatible = "qcom,pm8941-mpp" }, /* 8 MPP's */
+ { .compatible = "qcom,pm8950-mpp" }, /* 4 MPP's */
+ { .compatible = "qcom,pmi8950-mpp" }, /* 4 MPP's */
{ .compatible = "qcom,pm8994-mpp" }, /* 8 MPP's */
{ .compatible = "qcom,pma8084-mpp" }, /* 8 MPP's */
{ .compatible = "qcom,spmi-mpp" }, /* Generic */
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] dt-bindings: pinctrl: qcom-pmic-mpp: Add support for PM/PMI8950
2019-10-31 10:35 [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 kholk11
` (2 preceding siblings ...)
2019-10-31 10:35 ` [PATCH 3/4] pinctrl: qcom: spmi-mpp: Add PM/PMI8950 compatible strings kholk11
@ 2019-10-31 10:35 ` kholk11
2019-11-05 10:20 ` [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 Linus Walleij
4 siblings, 0 replies; 6+ messages in thread
From: kholk11 @ 2019-10-31 10:35 UTC (permalink / raw)
To: linux-arm-msm
Cc: kholk11, marijns95, bjorn.andersson, agross, linus.walleij,
robh+dt, mark.rutland, linux-gpio, devicetree
From: AngeloGioacchino Del Regno <kholk11@gmail.com>
Document the bindings for PM8950 and PMI8950 PMIC MPPs.
Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
index 2ab95bc26066..448d36a85730 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
@@ -16,6 +16,8 @@ of PMIC's from Qualcomm.
"qcom,pm8917-mpp",
"qcom,pm8921-mpp",
"qcom,pm8941-mpp",
+ "qcom,pm8950-mpp",
+ "qcom,pmi8950-mpp",
"qcom,pm8994-mpp",
"qcom,pma8084-mpp",
@@ -80,6 +82,8 @@ to specify in a pin configuration subnode:
mpp1-mpp4 for pm8841
mpp1-mpp4 for pm8916
mpp1-mpp8 for pm8941
+ mpp1-mpp4 for pm8950
+ mpp1-mpp4 for pmi8950
mpp1-mpp4 for pma8084
- function:
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950
2019-10-31 10:35 [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 kholk11
` (3 preceding siblings ...)
2019-10-31 10:35 ` [PATCH 4/4] dt-bindings: pinctrl: qcom-pmic-mpp: Add support for PM/PMI8950 kholk11
@ 2019-11-05 10:20 ` Linus Walleij
4 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-11-05 10:20 UTC (permalink / raw)
To: kholk11
Cc: MSM, marijns95, Bjorn Andersson, Andy Gross, Rob Herring,
Mark Rutland, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Thu, Oct 31, 2019 at 11:35 AM <kholk11@gmail.com> wrote:
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> This patch series enables support for GPIOs and MPPs found on the
> PM8950 and PMI8950 ICs, usually found on boards using the MSM8956,
> MSM8976, MSM8952, MSM8953 (and APQ variants) SoC.
>
> These are important to get the PA_THERM, QUIET_THERM MPPs enabled
> on PM8950 for standard thermals (and other board specific ones,
> where applicable) and GPIOs usually used to enable the audio mclk
> path, the wlan sleep clock and sometimes the eLDO for the WCD codec,
> plus other board specific paths, where applicable.
> For example, on the MSM8956 Sony Xperia Loire platform, this also
> includes a GPIO for the USB switch and one for the simple GPIO
> controlled vibrator included in all devices for this series of
> boards.
>
> This has been tested on Sony Xperia Loire phones, including the
> Xperia X Compact (Kugo) and Xperia X (Suzu).
>
> AngeloGioacchino Del Regno (4):
> pinctrl: qcom: spmi-gpio: Add PM/PMI8950 compatibility
> dt-bindings: pinctrl: qcom-pmic-gpio: Add support for PM/PMI8950
> pinctrl: qcom: spmi-mpp: Add PM/PMI8950 compatible strings
> dt-bindings: pinctrl: qcom-pmic-mpp: Add support for PM/PMI8950
These patches seem very simple and straight-forward and
noncontroversial so I just applied them.
Stakeholders can complain if they think otherwise.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-05 10:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 10:35 [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 kholk11
2019-10-31 10:35 ` [PATCH 1/4] pinctrl: qcom: spmi-gpio: Add PM/PMI8950 compatibility kholk11
2019-10-31 10:35 ` [PATCH 2/4] dt-bindings: pinctrl: qcom-pmic-gpio: Add support for PM/PMI8950 kholk11
2019-10-31 10:35 ` [PATCH 3/4] pinctrl: qcom: spmi-mpp: Add PM/PMI8950 compatible strings kholk11
2019-10-31 10:35 ` [PATCH 4/4] dt-bindings: pinctrl: qcom-pmic-mpp: Add support for PM/PMI8950 kholk11
2019-11-05 10:20 ` [PATCH 0/4] SPMI GPIOs and MPPs on PM/PMI8950 Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.