From: Linus Walleij <linus.walleij@linaro.org> To: "Lothar Waßmann" <LW@karo-electronics.de>, "Shawn Guo" <shawn.guo@freescale.com>, "Sascha Hauer" <s.hauer@pengutronix.de> Cc: linus.walleij@stericsson.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Dong Aisheng <b29396@freescale.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 2/3] pinctrl: imx: add pinmux-imx53 support Date: Wed, 7 Dec 2011 10:01:13 +0100 [thread overview] Message-ID: <CACRpkdY43PuU50nZxd4TMqj5T+4ZOGXOhOsOKOKNQ-wA_qUgaA@mail.gmail.com> (raw) In-Reply-To: <20189.50504.375779.311903@ipc1.ka-ro> On Tue, Dec 6, 2011 at 8:33 AM, Lothar Waßmann <LW@karo-electronics.de> wrote: > Shawn Guo writes: >> On Mon, Dec 05, 2011 at 10:18:38PM +0100, Sascha Hauer wrote: >> > This brings me to the point that currently we have the pins described as >> > >> > #define MX53_PAD_<name>__<function> >> > >> But that's also the reason why we have so many lengthy iomux-mx*.h on >> imx. Taking iomux-mx53.h for example, it's a 109K header with 1219 >> LOC, but probably only 10% of the definitions will actually be used. >> > Which has the benefit of having correct pin definitions for everyone > to use. If developers who need to use currently unused pindefs have to > create them on their own, there will always be a good chance in > getting them wrong. > >> > which means that you don't have to look into the datasheet to get the >> > different options for a pin >> >> Looking at the datasheet when we write code is a pretty natural thing >> to me. >> > The pindefs are like interrupt numbers or IO addresses for which there > also is a complete list of definitions in the kernel no matter whether > they are actually all in use. In both cases I'd say it's not the business of the pin control implementation to worry about size of .h files in arch/arm/* Getting rid of such defines and board data is the business of the device tree and nothing else, if I understand the way people are thinking about this. So I would prefer to keep these two concepts separate: 1) get something in place that integrates nicely with pinctrl 2) get device tree in place 3) get rid of old board files and huge .h define lists including I/O, irqs, pinmux lists... 4) ... 5) profit So don't try to solve all things at once or you'll end up trying to drink the ocean. Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 2/3] pinctrl: imx: add pinmux-imx53 support Date: Wed, 7 Dec 2011 10:01:13 +0100 [thread overview] Message-ID: <CACRpkdY43PuU50nZxd4TMqj5T+4ZOGXOhOsOKOKNQ-wA_qUgaA@mail.gmail.com> (raw) In-Reply-To: <20189.50504.375779.311903@ipc1.ka-ro> On Tue, Dec 6, 2011 at 8:33 AM, Lothar Wa?mann <LW@karo-electronics.de> wrote: > Shawn Guo writes: >> On Mon, Dec 05, 2011 at 10:18:38PM +0100, Sascha Hauer wrote: >> > This brings me to the point that currently we have the pins described as >> > >> > #define MX53_PAD_<name>__<function> >> > >> But that's also the reason why we have so many lengthy iomux-mx*.h on >> imx. ?Taking iomux-mx53.h for example, it's a 109K header with 1219 >> LOC, but probably only 10% of the definitions will actually be used. >> > Which has the benefit of having correct pin definitions for everyone > to use. If developers who need to use currently unused pindefs have to > create them on their own, there will always be a good chance in > getting them wrong. > >> > which means that you don't have to look into the datasheet to get the >> > different options for a pin >> >> Looking at the datasheet when we write code is a pretty natural thing >> to me. >> > The pindefs are like interrupt numbers or IO addresses for which there > also is a complete list of definitions in the kernel no matter whether > they are actually all in use. In both cases I'd say it's not the business of the pin control implementation to worry about size of .h files in arch/arm/* Getting rid of such defines and board data is the business of the device tree and nothing else, if I understand the way people are thinking about this. So I would prefer to keep these two concepts separate: 1) get something in place that integrates nicely with pinctrl 2) get device tree in place 3) get rid of old board files and huge .h define lists including I/O, irqs, pinmux lists... 4) ... 5) profit So don't try to solve all things at once or you'll end up trying to drink the ocean. Yours, Linus Walleij
next prev parent reply other threads:[~2011-12-07 9:01 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-12-04 11:49 [RFC PATCH 1/3] pinctrl: imx: add pinmux imx core driver Dong Aisheng 2011-12-04 11:49 ` Dong Aisheng 2011-12-04 11:49 ` [RFC PATCH 2/3] pinctrl: imx: add pinmux-imx53 support Dong Aisheng 2011-12-04 11:49 ` Dong Aisheng 2011-12-04 16:11 ` Sascha Hauer 2011-12-04 16:11 ` Sascha Hauer 2011-12-05 2:43 ` Dong Aisheng 2011-12-05 2:43 ` Dong Aisheng 2011-12-05 7:51 ` Sascha Hauer 2011-12-05 7:51 ` Sascha Hauer 2011-12-06 3:21 ` Dong Aisheng-B29396 2011-12-06 3:21 ` Dong Aisheng-B29396 2011-12-05 17:03 ` Linus Walleij 2011-12-05 17:03 ` Linus Walleij 2011-12-05 17:01 ` Linus Walleij 2011-12-05 17:01 ` Linus Walleij 2011-12-06 3:42 ` Dong Aisheng-B29396 2011-12-06 3:42 ` Dong Aisheng-B29396 2011-12-05 16:57 ` Linus Walleij 2011-12-05 16:57 ` Linus Walleij 2011-12-05 21:18 ` Sascha Hauer 2011-12-05 21:18 ` Sascha Hauer 2011-12-06 5:54 ` Dong Aisheng-B29396 2011-12-06 5:54 ` Dong Aisheng-B29396 2011-12-06 6:58 ` Shawn Guo 2011-12-06 6:58 ` Shawn Guo 2011-12-06 7:21 ` Dong Aisheng-B29396 2011-12-06 7:21 ` Dong Aisheng-B29396 2011-12-06 6:25 ` Shawn Guo 2011-12-06 6:25 ` Shawn Guo 2011-12-06 7:33 ` Lothar Waßmann 2011-12-06 7:33 ` Lothar Waßmann 2011-12-06 8:00 ` Shawn Guo 2011-12-06 8:00 ` Shawn Guo 2011-12-06 8:05 ` Uwe Kleine-König 2011-12-06 8:05 ` Uwe Kleine-König 2011-12-07 9:01 ` Linus Walleij [this message] 2011-12-07 9:01 ` Linus Walleij 2011-12-06 10:53 ` Sascha Hauer 2011-12-06 10:53 ` Sascha Hauer 2011-12-06 3:39 ` Dong Aisheng 2011-12-06 3:39 ` Dong Aisheng 2011-12-04 11:49 ` [RFC PATCH 3/3] pinctrl: imx: add pinmux-imx6q support Dong Aisheng 2011-12-04 11:49 ` Dong Aisheng 2011-12-06 7:23 ` Shawn Guo 2011-12-06 7:23 ` Shawn Guo 2011-12-06 7:23 ` Dong Aisheng-B29396 2011-12-06 7:23 ` Dong Aisheng-B29396 2011-12-06 14:44 ` Shawn Guo 2011-12-06 14:44 ` Shawn Guo 2011-12-07 9:09 ` Linus Walleij 2011-12-07 9:09 ` Linus Walleij 2011-12-07 9:18 ` Dong Aisheng-B29396 2011-12-07 9:18 ` Dong Aisheng-B29396 2011-12-05 13:09 ` [RFC PATCH 1/3] pinctrl: imx: add pinmux imx core driver Linus Walleij 2011-12-05 13:09 ` Linus Walleij 2011-12-06 3:41 ` Dong Aisheng-B29396 2011-12-06 3:41 ` Dong Aisheng-B29396 2011-12-06 7:06 ` Shawn Guo 2011-12-06 7:06 ` Shawn Guo 2011-12-06 7:13 ` Dong Aisheng-B29396 2011-12-06 7:13 ` Dong Aisheng-B29396 2011-12-06 7:32 ` Shawn Guo 2011-12-06 7:32 ` Shawn Guo 2011-12-06 7:39 ` Shawn Guo 2011-12-06 7:39 ` Shawn Guo 2011-12-06 7:35 ` Dong Aisheng-B29396 2011-12-06 7:35 ` Dong Aisheng-B29396 2011-12-06 9:42 ` Shawn Guo 2011-12-06 9:42 ` Shawn Guo 2011-12-06 9:38 ` Dong Aisheng-B29396 2011-12-06 9:38 ` Dong Aisheng-B29396
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACRpkdY43PuU50nZxd4TMqj5T+4ZOGXOhOsOKOKNQ-wA_qUgaA@mail.gmail.com \ --to=linus.walleij@linaro.org \ --cc=LW@karo-electronics.de \ --cc=b29396@freescale.com \ --cc=kernel@pengutronix.de \ --cc=linus.walleij@stericsson.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawn.guo@freescale.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.