* [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
@ 2017-10-05 7:50 ` Lars Poeschel
0 siblings, 0 replies; 9+ messages in thread
From: Lars Poeschel @ 2017-10-05 7:50 UTC (permalink / raw)
To: Linus Walleij, linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Mark Rutland,
devicetree-u79uwXL29TY76Z2rM5mHXA
Cc: Lars Poeschel
The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
devicetree binding doc as well. So driver and binding doc are in sync
again.
Signed-off-by: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
---
.../bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devicetree/bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} (100%)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
similarity index 100%
rename from Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
rename to Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
--
2.14.2
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
@ 2017-10-05 7:50 ` Lars Poeschel
0 siblings, 0 replies; 9+ messages in thread
From: Lars Poeschel @ 2017-10-05 7:50 UTC (permalink / raw)
To: Linus Walleij, linux-gpio, linux-kernel, Rob Herring,
Mark Rutland, devicetree
Cc: Lars Poeschel
The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
devicetree binding doc as well. So driver and binding doc are in sync
again.
Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
---
.../bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devicetree/bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} (100%)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
similarity index 100%
rename from Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
rename to Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
--
2.14.2
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
2017-10-05 7:50 ` Lars Poeschel
@ 2017-10-07 23:58 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-10-07 23:58 UTC (permalink / raw)
To: Lars Poeschel
Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Mark Rutland,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org> wrote:
> The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> devicetree binding doc as well. So driver and binding doc are in sync
> again.
>
> Signed-off-by: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
Are there no new references to the generic pin control binding
needed as well?
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
@ 2017-10-07 23:58 ` Linus Walleij
0 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-10-07 23:58 UTC (permalink / raw)
To: Lars Poeschel
Cc: linux-gpio, linux-kernel, Rob Herring, Mark Rutland, devicetree
On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:
> The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> devicetree binding doc as well. So driver and binding doc are in sync
> again.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
Are there no new references to the generic pin control binding
needed as well?
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
2017-10-07 23:58 ` Linus Walleij
(?)
@ 2017-10-09 9:39 ` Lars Poeschel
2017-10-09 10:33 ` Sebastian Reichel
-1 siblings, 1 reply; 9+ messages in thread
From: Lars Poeschel @ 2017-10-09 9:39 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-gpio, linux-kernel, Rob Herring, Mark Rutland, devicetree,
Sebastian Reichel
On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote:
CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as
well.
> On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:
> > The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> > devicetree binding doc as well. So driver and binding doc are in sync
> > again.
> >
> > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
>
> Are there no new references to the generic pin control binding
> needed as well?
Well, yes there is one: As far as I can see it supports the bias-pull-up
property.
My first intention was to have the doc as we have it in the right place, but
you are right: It needs an update as well. I can do this, but Sebastian,
please keep an eye on that.
As there are already patches depending on this patch (https://marc.info/?
l=linux-gpio&m=150726650325394&w=4) I would suggest, that you pull in this
patch as is and I do the little update on the doc as a seperate patch.
Regards,
Lars
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
2017-10-05 7:50 ` Lars Poeschel
(?)
(?)
@ 2017-10-09 10:29 ` Sebastian Reichel
-1 siblings, 0 replies; 9+ messages in thread
From: Sebastian Reichel @ 2017-10-09 10:29 UTC (permalink / raw)
To: Lars Poeschel
Cc: Linus Walleij, linux-gpio, linux-kernel, Rob Herring,
Mark Rutland, devicetree
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
Hi,
On Thu, Oct 05, 2017 at 09:50:02AM +0200, Lars Poeschel wrote:
> The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> devicetree binding doc as well. So driver and binding doc are in sync
> again.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> ---
> .../bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename Documentation/devicetree/bindings/{gpio/gpio-mcp23s08.txt => pinctrl/pinctrl-mcp23s08.txt} (100%)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
> rename to Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
2017-10-09 9:39 ` Lars Poeschel
@ 2017-10-09 10:33 ` Sebastian Reichel
0 siblings, 0 replies; 9+ messages in thread
From: Sebastian Reichel @ 2017-10-09 10:33 UTC (permalink / raw)
To: Lars Poeschel
Cc: Linus Walleij, linux-gpio-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rob Herring, Mark Rutland,
devicetree-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 2173 bytes --]
Hi,
On Mon, Oct 09, 2017 at 11:39:02AM +0200, Lars Poeschel wrote:
> On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote:
>
> CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as
> well.
>
> > On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org> wrote:
> > > The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> > > devicetree binding doc as well. So driver and binding doc are in sync
> > > again.
> > >
> > > Signed-off-by: Lars Poeschel <poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
> >
> > Are there no new references to the generic pin control binding
> > needed as well?
>
> Well, yes there is one: As far as I can see it supports the bias-pull-up
> property.
> My first intention was to have the doc as we have it in the right place, but
> you are right: It needs an update as well. I can do this, but Sebastian,
> please keep an eye on that.
>
> As there are already patches depending on this patch (https://marc.info/?
> l=linux-gpio&m=150726650325394&w=4) I would suggest, that you pull in this
> patch as is and I do the little update on the doc as a seperate patch.
Yes, the driver supports being used as pin controller with the
"bias-pull-up;" property now. For example I use this with a RPi
to enable pull-ups for all pins:
gpio21: gpio@21 {
compatible = "microchip,mcp23017";
gpio-controller;
#gpio-cells = <0x2>;
reg = <0x21>;
interrupt-parent = <&socgpio>;
interrupts = <0x17 0x8>;
interrupt-names = "mcp23017@21 irq";
interrupt-controller;
#interrupt-cells = <0x2>;
microchip,irq-mirror;
pinctrl-names = "default";
pinctrl-0 = <&i2cgpio0irq &gpio21pullups>;
gpio21pullups: pinmux {
pins = "gpio0", "gpio1", "gpio2", "gpio3",
"gpio4", "gpio5", "gpio6", "gpio7",
"gpio8", "gpio9", "gpio10", "gpio11",
"gpio12", "gpio13", "gpio14", "gpio15";
bias-pull-up;
};
};
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
@ 2017-10-09 10:33 ` Sebastian Reichel
0 siblings, 0 replies; 9+ messages in thread
From: Sebastian Reichel @ 2017-10-09 10:33 UTC (permalink / raw)
To: Lars Poeschel
Cc: Linus Walleij, linux-gpio, linux-kernel, Rob Herring,
Mark Rutland, devicetree
[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]
Hi,
On Mon, Oct 09, 2017 at 11:39:02AM +0200, Lars Poeschel wrote:
> On Sun, Oct 8, 2017 at 01:58:52 CEST Linus Walleij wrote:
>
> CCing-in Sebastian Reichel who did the move to pinctrl and pinctrl support as
> well.
>
> > On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:
> > > The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> > > devicetree binding doc as well. So driver and binding doc are in sync
> > > again.
> > >
> > > Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
> >
> > Are there no new references to the generic pin control binding
> > needed as well?
>
> Well, yes there is one: As far as I can see it supports the bias-pull-up
> property.
> My first intention was to have the doc as we have it in the right place, but
> you are right: It needs an update as well. I can do this, but Sebastian,
> please keep an eye on that.
>
> As there are already patches depending on this patch (https://marc.info/?
> l=linux-gpio&m=150726650325394&w=4) I would suggest, that you pull in this
> patch as is and I do the little update on the doc as a seperate patch.
Yes, the driver supports being used as pin controller with the
"bias-pull-up;" property now. For example I use this with a RPi
to enable pull-ups for all pins:
gpio21: gpio@21 {
compatible = "microchip,mcp23017";
gpio-controller;
#gpio-cells = <0x2>;
reg = <0x21>;
interrupt-parent = <&socgpio>;
interrupts = <0x17 0x8>;
interrupt-names = "mcp23017@21 irq";
interrupt-controller;
#interrupt-cells = <0x2>;
microchip,irq-mirror;
pinctrl-names = "default";
pinctrl-0 = <&i2cgpio0irq &gpio21pullups>;
gpio21pullups: pinmux {
pins = "gpio0", "gpio1", "gpio2", "gpio3",
"gpio4", "gpio5", "gpio6", "gpio7",
"gpio8", "gpio9", "gpio10", "gpio11",
"gpio12", "gpio13", "gpio14", "gpio15";
bias-pull-up;
};
};
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio
2017-10-05 7:50 ` Lars Poeschel
` (2 preceding siblings ...)
(?)
@ 2017-10-11 8:01 ` Linus Walleij
-1 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2017-10-11 8:01 UTC (permalink / raw)
To: Lars Poeschel
Cc: linux-gpio, linux-kernel, Rob Herring, Mark Rutland, devicetree
On Thu, Oct 5, 2017 at 9:50 AM, Lars Poeschel <poeschel@lemonage.de> wrote:
> The mcp23s08 driver was moved from gpio to pinctrl. This moves it's
> devicetree binding doc as well. So driver and binding doc are in sync
> again.
>
> Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
Patch applied with Sebastian's tag.
Nothing controversial about this so why not.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-10-11 8:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-05 7:50 [PATCH] dt-bindings: pinctrl: Move mcp23s08 from gpio Lars Poeschel
2017-10-05 7:50 ` Lars Poeschel
[not found] ` <20171005075002.9901-1-poeschel-Xtl8qvBWbHwb1SvskN2V4Q@public.gmane.org>
2017-10-07 23:58 ` Linus Walleij
2017-10-07 23:58 ` Linus Walleij
2017-10-09 9:39 ` Lars Poeschel
2017-10-09 10:33 ` Sebastian Reichel
2017-10-09 10:33 ` Sebastian Reichel
2017-10-09 10:29 ` Sebastian Reichel
2017-10-11 8:01 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.