* [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK
@ 2019-01-24 12:51 Philipp Zabel
2019-01-24 12:51 ` [PATCH 2/2] drm/imx: allow building under COMPILE_TEST Philipp Zabel
2019-01-30 8:16 ` [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK Linus Walleij
0 siblings, 2 replies; 6+ messages in thread
From: Philipp Zabel @ 2019-01-24 12:51 UTC (permalink / raw)
To: dri-devel; +Cc: kernel
Since the TVE provides a clock to the DI, the driver can only be
compiled if the common clock framework is enabled. With the COMMON_CLK
dependency in place, it will be possible to allow building the other
parts of imx-drm under COMPILE_TEST on architectures that do not select
the common clock framework.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
index c9e439c82241..c55428490e56 100644
--- a/drivers/gpu/drm/imx/Kconfig
+++ b/drivers/gpu/drm/imx/Kconfig
@@ -18,6 +18,7 @@ config DRM_IMX_PARALLEL_DISPLAY
config DRM_IMX_TVE
tristate "Support for TV and VGA displays"
depends on DRM_IMX
+ depends on COMMON_CLK
select REGMAP_MMIO
help
Choose this to enable the internal Television Encoder (TVe)
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] drm/imx: allow building under COMPILE_TEST
2019-01-24 12:51 [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK Philipp Zabel
@ 2019-01-24 12:51 ` Philipp Zabel
2019-01-30 8:16 ` Linus Walleij
2019-01-30 8:16 ` [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK Linus Walleij
1 sibling, 1 reply; 6+ messages in thread
From: Philipp Zabel @ 2019-01-24 12:51 UTC (permalink / raw)
To: dri-devel; +Cc: kernel
Allow to compile-test imx-drm on other platforms.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/gpu/drm/imx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
index c55428490e56..c3c84a09e628 100644
--- a/drivers/gpu/drm/imx/Kconfig
+++ b/drivers/gpu/drm/imx/Kconfig
@@ -4,7 +4,7 @@ config DRM_IMX
select VIDEOMODE_HELPERS
select DRM_GEM_CMA_HELPER
select DRM_KMS_CMA_HELPER
- depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM)
+ depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST)
depends on IMX_IPUV3_CORE
help
enable i.MX graphics support
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK
2019-01-24 12:51 [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK Philipp Zabel
2019-01-24 12:51 ` [PATCH 2/2] drm/imx: allow building under COMPILE_TEST Philipp Zabel
@ 2019-01-30 8:16 ` Linus Walleij
2019-01-30 9:01 ` Philipp Zabel
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2019-01-30 8:16 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Sascha Hauer, open list:DRM PANEL DRIVERS
On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Since the TVE provides a clock to the DI, the driver can only be
> compiled if the common clock framework is enabled. With the COMMON_CLK
> dependency in place, it will be possible to allow building the other
> parts of imx-drm under COMPILE_TEST on architectures that do not select
> the common clock framework.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Since the clock framework has stubs I bet it can be *compiled* without
COMMON_CLK. But it will certainly not work so if you reword the commit:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] drm/imx: allow building under COMPILE_TEST
2019-01-24 12:51 ` [PATCH 2/2] drm/imx: allow building under COMPILE_TEST Philipp Zabel
@ 2019-01-30 8:16 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-01-30 8:16 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Sascha Hauer, open list:DRM PANEL DRIVERS
On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Allow to compile-test imx-drm on other platforms.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK
2019-01-30 8:16 ` [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK Linus Walleij
@ 2019-01-30 9:01 ` Philipp Zabel
2019-01-30 9:46 ` Linus Walleij
0 siblings, 1 reply; 6+ messages in thread
From: Philipp Zabel @ 2019-01-30 9:01 UTC (permalink / raw)
To: Linus Walleij; +Cc: Sascha Hauer, open list:DRM PANEL DRIVERS
Hi Linus,
On Wed, 2019-01-30 at 09:16 +0100, Linus Walleij wrote:
> On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> > Since the TVE provides a clock to the DI, the driver can only be
> > compiled if the common clock framework is enabled. With the COMMON_CLK
> > dependency in place, it will be possible to allow building the other
> > parts of imx-drm under COMPILE_TEST on architectures that do not select
> > the common clock framework.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> Since the clock framework has stubs I bet it can be *compiled* without
> COMMON_CLK. But it will certainly not work so if you reword the commit:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
thank you for the review. It indeed does not compile because struct
imx_tve embeds a struct clk_hw, which is defined in linux/clk-provider.h
only if COMMON_CLK is enabled.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK
2019-01-30 9:01 ` Philipp Zabel
@ 2019-01-30 9:46 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2019-01-30 9:46 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Sascha Hauer, open list:DRM PANEL DRIVERS
On Wed, Jan 30, 2019 at 10:01 AM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> On Wed, 2019-01-30 at 09:16 +0100, Linus Walleij wrote:
> > On Thu, Jan 24, 2019 at 1:51 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
> >
> > > Since the TVE provides a clock to the DI, the driver can only be
> > > compiled if the common clock framework is enabled. With the COMMON_CLK
> > > dependency in place, it will be possible to allow building the other
> > > parts of imx-drm under COMPILE_TEST on architectures that do not select
> > > the common clock framework.
> > >
> > > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >
> > Since the clock framework has stubs I bet it can be *compiled* without
> > COMMON_CLK. But it will certainly not work so if you reword the commit:
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> thank you for the review. It indeed does not compile because struct
> imx_tve embeds a struct clk_hw, which is defined in linux/clk-provider.h
> only if COMMON_CLK is enabled.
Oh that one, I see it is a clock driver.
Sorry for my ignorance.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-30 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-24 12:51 [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK Philipp Zabel
2019-01-24 12:51 ` [PATCH 2/2] drm/imx: allow building under COMPILE_TEST Philipp Zabel
2019-01-30 8:16 ` Linus Walleij
2019-01-30 8:16 ` [PATCH 1/2] drm/imx: imx-tve: depend on COMMON_CLK Linus Walleij
2019-01-30 9:01 ` Philipp Zabel
2019-01-30 9:46 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.