* [PATCH] video: ARM CLCD: fix Vexpress regression
@ 2016-10-20 6:46 ` Linus Walleij
0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2016-10-20 6:46 UTC (permalink / raw)
To: linux-arm-kernel
The CLCD does not come up on Versatile Express as it does not
(currently) have a syscon node for controlling the block apart
from the CLCD itself. Make sure the .init() function can bail
out without an error making it probe again.
Reported-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
index 19ad8645d93c..d909b7dda14d 100644
--- a/drivers/video/fbdev/amba-clcd-versatile.c
+++ b/drivers/video/fbdev/amba-clcd-versatile.c
@@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
&clcd_id);
if (!np) {
dev_err(dev, "no Versatile syscon node\n");
- return -ENODEV;
+ /* Vexpress does not have this */
+ return 0;
}
versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] video: ARM CLCD: fix Vexpress regression
2016-10-20 6:46 ` Linus Walleij
@ 2016-10-22 3:44 ` Amit Pundir
-1 siblings, 0 replies; 14+ messages in thread
From: Amit Pundir @ 2016-10-22 3:44 UTC (permalink / raw)
To: linux-arm-kernel
On 20 October 2016 at 14:46, Linus Walleij <linus.walleij@linaro.org> wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
> index 19ad8645d93c..d909b7dda14d 100644
> --- a/drivers/video/fbdev/amba-clcd-versatile.c
> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
> &clcd_id);
> if (!np) {
> dev_err(dev, "no Versatile syscon node\n");
> - return -ENODEV;
> + /* Vexpress does not have this */
> + return 0;
> }
> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
Thanks. Works on my Qemu + Android setup.
Tested-by: Amit Pundir <amit.pundir@linaro.org>
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] video: ARM CLCD: fix Vexpress regression
@ 2016-10-22 3:44 ` Amit Pundir
0 siblings, 0 replies; 14+ messages in thread
From: Amit Pundir @ 2016-10-22 3:44 UTC (permalink / raw)
To: linux-arm-kernel
On 20 October 2016 at 14:46, Linus Walleij <linus.walleij@linaro.org> wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
> index 19ad8645d93c..d909b7dda14d 100644
> --- a/drivers/video/fbdev/amba-clcd-versatile.c
> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
> &clcd_id);
> if (!np) {
> dev_err(dev, "no Versatile syscon node\n");
> - return -ENODEV;
> + /* Vexpress does not have this */
> + return 0;
> }
> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
Thanks. Works on my Qemu + Android setup.
Tested-by: Amit Pundir <amit.pundir@linaro.org>
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] video: ARM CLCD: fix Vexpress regression
2016-10-20 6:46 ` Linus Walleij
@ 2016-10-28 16:19 ` Nicolae Rosia
-1 siblings, 0 replies; 14+ messages in thread
From: Nicolae Rosia @ 2016-10-28 16:19 UTC (permalink / raw)
To: linux-arm-kernel
Thanks, works for me on qemu.
Tested-by: Nicolae Rosia <nicolae_rosia@mentor.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] video: ARM CLCD: fix Vexpress regression
2016-10-20 6:46 ` Linus Walleij
@ 2016-10-29 8:23 ` Linus Walleij
-1 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2016-10-29 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 20, 2016 at 8:46 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Tomi can you please pick this up?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] video: ARM CLCD: fix Vexpress regression
@ 2016-10-29 8:23 ` Linus Walleij
0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2016-10-29 8:23 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 20, 2016 at 8:46 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Tomi can you please pick this up?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] video: ARM CLCD: fix Vexpress regression
2016-10-20 6:46 ` Linus Walleij
@ 2016-11-02 8:24 ` Tomi Valkeinen
-1 siblings, 0 replies; 14+ messages in thread
From: Tomi Valkeinen @ 2016-11-02 8:24 UTC (permalink / raw)
To: linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1128 bytes --]
On 20/10/16 09:46, Linus Walleij wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
> index 19ad8645d93c..d909b7dda14d 100644
> --- a/drivers/video/fbdev/amba-clcd-versatile.c
> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
> &clcd_id);
> if (!np) {
> dev_err(dev, "no Versatile syscon node\n");
> - return -ENODEV;
> + /* Vexpress does not have this */
> + return 0;
> }
> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
>
>
Thanks, queued for 4.9 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] video: ARM CLCD: fix Vexpress regression
@ 2016-11-02 8:24 ` Tomi Valkeinen
0 siblings, 0 replies; 14+ messages in thread
From: Tomi Valkeinen @ 2016-11-02 8:24 UTC (permalink / raw)
To: linux-arm-kernel
On 20/10/16 09:46, Linus Walleij wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
> index 19ad8645d93c..d909b7dda14d 100644
> --- a/drivers/video/fbdev/amba-clcd-versatile.c
> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
> &clcd_id);
> if (!np) {
> dev_err(dev, "no Versatile syscon node\n");
> - return -ENODEV;
> + /* Vexpress does not have this */
> + return 0;
> }
> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
>
>
Thanks, queued for 4.9 fixes.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161102/46980a9e/attachment.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] video: ARM CLCD: fix Vexpress regression
2016-10-20 6:46 ` Linus Walleij
@ 2016-11-02 8:34 ` Tomi Valkeinen
-1 siblings, 0 replies; 14+ messages in thread
From: Tomi Valkeinen @ 2016-11-02 8:34 UTC (permalink / raw)
To: linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1233 bytes --]
On 20/10/16 09:46, Linus Walleij wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
> index 19ad8645d93c..d909b7dda14d 100644
> --- a/drivers/video/fbdev/amba-clcd-versatile.c
> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
> &clcd_id);
> if (!np) {
> dev_err(dev, "no Versatile syscon node\n");
> - return -ENODEV;
> + /* Vexpress does not have this */
> + return 0;
> }
> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
Actually, the above doesn't look correct. If this is not an error, then
the driver shouldn't print an error.
Shall I just remove the print?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] video: ARM CLCD: fix Vexpress regression
@ 2016-11-02 8:34 ` Tomi Valkeinen
0 siblings, 0 replies; 14+ messages in thread
From: Tomi Valkeinen @ 2016-11-02 8:34 UTC (permalink / raw)
To: linux-arm-kernel
On 20/10/16 09:46, Linus Walleij wrote:
> The CLCD does not come up on Versatile Express as it does not
> (currently) have a syscon node for controlling the block apart
> from the CLCD itself. Make sure the .init() function can bail
> out without an error making it probe again.
>
> Reported-by: Amit Pundir <amit.pundir@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
> index 19ad8645d93c..d909b7dda14d 100644
> --- a/drivers/video/fbdev/amba-clcd-versatile.c
> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
> &clcd_id);
> if (!np) {
> dev_err(dev, "no Versatile syscon node\n");
> - return -ENODEV;
> + /* Vexpress does not have this */
> + return 0;
> }
> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
Actually, the above doesn't look correct. If this is not an error, then
the driver shouldn't print an error.
Shall I just remove the print?
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161102/6b56b131/attachment.sig>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] video: ARM CLCD: fix Vexpress regression
2016-11-02 8:34 ` Tomi Valkeinen
@ 2016-11-03 9:25 ` Linus Walleij
-1 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2016-11-03 9:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 2, 2016 at 9:34 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 20/10/16 09:46, Linus Walleij wrote:
>> The CLCD does not come up on Versatile Express as it does not
>> (currently) have a syscon node for controlling the block apart
>> from the CLCD itself. Make sure the .init() function can bail
>> out without an error making it probe again.
>>
>> Reported-by: Amit Pundir <amit.pundir@linaro.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
>> index 19ad8645d93c..d909b7dda14d 100644
>> --- a/drivers/video/fbdev/amba-clcd-versatile.c
>> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
>> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
>> &clcd_id);
>> if (!np) {
>> dev_err(dev, "no Versatile syscon node\n");
>> - return -ENODEV;
>> + /* Vexpress does not have this */
>> + return 0;
>> }
>> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
>
> Actually, the above doesn't look correct. If this is not an error, then
> the driver shouldn't print an error.
>
> Shall I just remove the print?
You're right, sorry for not thinking deeper :(
Just cut the print.
Thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH] video: ARM CLCD: fix Vexpress regression
@ 2016-11-03 9:25 ` Linus Walleij
0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2016-11-03 9:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 2, 2016 at 9:34 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On 20/10/16 09:46, Linus Walleij wrote:
>> The CLCD does not come up on Versatile Express as it does not
>> (currently) have a syscon node for controlling the block apart
>> from the CLCD itself. Make sure the .init() function can bail
>> out without an error making it probe again.
>>
>> Reported-by: Amit Pundir <amit.pundir@linaro.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> drivers/video/fbdev/amba-clcd-versatile.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/amba-clcd-versatile.c b/drivers/video/fbdev/amba-clcd-versatile.c
>> index 19ad8645d93c..d909b7dda14d 100644
>> --- a/drivers/video/fbdev/amba-clcd-versatile.c
>> +++ b/drivers/video/fbdev/amba-clcd-versatile.c
>> @@ -527,7 +527,8 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
>> &clcd_id);
>> if (!np) {
>> dev_err(dev, "no Versatile syscon node\n");
>> - return -ENODEV;
>> + /* Vexpress does not have this */
>> + return 0;
>> }
>> versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
>
> Actually, the above doesn't look correct. If this is not an error, then
> the driver shouldn't print an error.
>
> Shall I just remove the print?
You're right, sorry for not thinking deeper :(
Just cut the print.
Thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread