[PATCH v1] pinctrl: core: Make pinctrl_init_controller() static

[PATCH v1] pinctrl: core: Make pinctrl_init_controller() static

[Andy Shevchenko]

pinctrl_init_controller() is not used outside core.c, thus make it
static and prevent compiler to warn.

drivers/pinctrl/core.c:1943:21: warning: no previous prototype for ‘pinctrl_init_controller’ [-Wmissing-prototypes]
 struct pinctrl_dev *pinctrl_init_controller(struct pinctrl_desc *pctldesc,
                     ^~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index ddefdac7dd20..2892fe2a036c 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1940,9 +1940,9 @@ static int pinctrl_check_ops(struct pinctrl_dev *pctldev)
  * @dev: parent device for this pin controller
  * @driver_data: private pin controller data for this pin controller
  */
-struct pinctrl_dev *pinctrl_init_controller(struct pinctrl_desc *pctldesc,
-					    struct device *dev,
-					    void *driver_data)
+static struct pinctrl_dev *
+pinctrl_init_controller(struct pinctrl_desc *pctldesc, struct device *dev,
+			void *driver_data)
 {
 	struct pinctrl_dev *pctldev;
 	int ret;
-- 
2.11.0

Re: [PATCH v1] pinctrl: core: Make pinctrl_init_controller() static

[Linus Walleij]

On Mon, Mar 27, 2017 at 1:37 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> pinctrl_init_controller() is not used outside core.c, thus make it
> static and prevent compiler to warn.
>
> drivers/pinctrl/core.c:1943:21: warning: no previous prototype for ‘pinctrl_init_controller’ [-Wmissing-prototypes]
>  struct pinctrl_dev *pinctrl_init_controller(struct pinctrl_desc *pctldesc,
>                      ^~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Patch applied.

Yours,
Linus Walleij