* [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
@ 2014-10-18 12:56 Linus Walleij
2014-10-20 6:46 ` Lee Jones
0 siblings, 1 reply; 14+ messages in thread
From: Linus Walleij @ 2014-10-18 12:56 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, Dmitry Torokhov, linux-kernel, linux-input
Cc: Linus Walleij
This adds the register offsets for pull up/down for the STMPE
1601, 1801 and 24xx expanders. This is used to bias GPIO lines
and keypad lines.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
patch series through the input tree, where the registers need to be
used to enable the keypad on the STMPE2401.
---
drivers/mfd/stmpe.c | 4 ++++
drivers/mfd/stmpe.h | 3 +++
include/linux/mfd/stmpe.h | 2 ++
3 files changed, 9 insertions(+)
diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
index 3004d5ba0b82..497505bad4c4 100644
--- a/drivers/mfd/stmpe.c
+++ b/drivers/mfd/stmpe.c
@@ -547,6 +547,7 @@ static const u8 stmpe1601_regs[] = {
[STMPE_IDX_GPDR_LSB] = STMPE1601_REG_GPIO_SET_DIR_LSB,
[STMPE_IDX_GPRER_LSB] = STMPE1601_REG_GPIO_RE_LSB,
[STMPE_IDX_GPFER_LSB] = STMPE1601_REG_GPIO_FE_LSB,
+ [STMPE_IDX_GPPUR_LSB] = STMPE1601_REG_GPIO_PU_LSB,
[STMPE_IDX_GPAFR_U_MSB] = STMPE1601_REG_GPIO_AF_U_MSB,
[STMPE_IDX_IEGPIOR_LSB] = STMPE1601_REG_INT_EN_GPIO_MASK_LSB,
[STMPE_IDX_ISGPIOR_MSB] = STMPE1601_REG_INT_STA_GPIO_MSB,
@@ -695,6 +696,7 @@ static const u8 stmpe1801_regs[] = {
[STMPE_IDX_GPDR_LSB] = STMPE1801_REG_GPIO_SET_DIR_LOW,
[STMPE_IDX_GPRER_LSB] = STMPE1801_REG_GPIO_RE_LOW,
[STMPE_IDX_GPFER_LSB] = STMPE1801_REG_GPIO_FE_LOW,
+ [STMPE_IDX_GPPUR_LSB] = STMPE1801_REG_GPIO_PULL_UP_LOW,
[STMPE_IDX_IEGPIOR_LSB] = STMPE1801_REG_INT_EN_GPIO_MASK_LOW,
[STMPE_IDX_ISGPIOR_LSB] = STMPE1801_REG_INT_STA_GPIO_LOW,
};
@@ -778,6 +780,8 @@ static const u8 stmpe24xx_regs[] = {
[STMPE_IDX_GPDR_LSB] = STMPE24XX_REG_GPDR_LSB,
[STMPE_IDX_GPRER_LSB] = STMPE24XX_REG_GPRER_LSB,
[STMPE_IDX_GPFER_LSB] = STMPE24XX_REG_GPFER_LSB,
+ [STMPE_IDX_GPPUR_LSB] = STMPE24XX_REG_GPPUR_LSB,
+ [STMPE_IDX_GPPDR_LSB] = STMPE24XX_REG_GPPDR_LSB,
[STMPE_IDX_GPAFR_U_MSB] = STMPE24XX_REG_GPAFR_U_MSB,
[STMPE_IDX_IEGPIOR_LSB] = STMPE24XX_REG_IEGPIOR_LSB,
[STMPE_IDX_ISGPIOR_MSB] = STMPE24XX_REG_ISGPIOR_MSB,
diff --git a/drivers/mfd/stmpe.h b/drivers/mfd/stmpe.h
index bee0abf82040..84adb46b3e2f 100644
--- a/drivers/mfd/stmpe.h
+++ b/drivers/mfd/stmpe.h
@@ -188,6 +188,7 @@ int stmpe_remove(struct stmpe *stmpe);
#define STMPE1601_REG_GPIO_ED_MSB 0x8A
#define STMPE1601_REG_GPIO_RE_LSB 0x8D
#define STMPE1601_REG_GPIO_FE_LSB 0x8F
+#define STMPE1601_REG_GPIO_PU_LSB 0x91
#define STMPE1601_REG_GPIO_AF_U_MSB 0x92
#define STMPE1601_SYS_CTRL_ENABLE_GPIO (1 << 3)
@@ -276,6 +277,8 @@ int stmpe_remove(struct stmpe *stmpe);
#define STMPE24XX_REG_GPEDR_MSB 0x8C
#define STMPE24XX_REG_GPRER_LSB 0x91
#define STMPE24XX_REG_GPFER_LSB 0x94
+#define STMPE24XX_REG_GPPUR_LSB 0x97
+#define STMPE24XX_REG_GPPDR_LSB 0x9a
#define STMPE24XX_REG_GPAFR_U_MSB 0x9B
#define STMPE24XX_SYS_CTRL_ENABLE_GPIO (1 << 3)
diff --git a/include/linux/mfd/stmpe.h b/include/linux/mfd/stmpe.h
index af9e1b07a630..976e1a390177 100644
--- a/include/linux/mfd/stmpe.h
+++ b/include/linux/mfd/stmpe.h
@@ -50,6 +50,8 @@ enum {
STMPE_IDX_GPEDR_MSB,
STMPE_IDX_GPRER_LSB,
STMPE_IDX_GPFER_LSB,
+ STMPE_IDX_GPPUR_LSB,
+ STMPE_IDX_GPPDR_LSB,
STMPE_IDX_GPAFR_U_MSB,
STMPE_IDX_IEGPIOR_LSB,
STMPE_IDX_ISGPIOR_LSB,
--
1.9.3
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-10-18 12:56 [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE Linus Walleij
@ 2014-10-20 6:46 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2014-10-20 6:46 UTC (permalink / raw)
To: Linus Walleij; +Cc: Samuel Ortiz, Dmitry Torokhov, linux-kernel, linux-input
On Sat, 18 Oct 2014, Linus Walleij wrote:
> This adds the register offsets for pull up/down for the STMPE
> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> and keypad lines.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> patch series through the input tree, where the registers need to be
> used to enable the keypad on the STMPE2401.
> ---
> drivers/mfd/stmpe.c | 4 ++++
> drivers/mfd/stmpe.h | 3 +++
> include/linux/mfd/stmpe.h | 2 ++
> 3 files changed, 9 insertions(+)
Does this need to go in with the other patches in the set?
I'm _guessing_ that, as you've sent them separately, they can be
applied separately?
This needs to go in via MFD, but for my own reference:
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 3004d5ba0b82..497505bad4c4 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -547,6 +547,7 @@ static const u8 stmpe1601_regs[] = {
> [STMPE_IDX_GPDR_LSB] = STMPE1601_REG_GPIO_SET_DIR_LSB,
> [STMPE_IDX_GPRER_LSB] = STMPE1601_REG_GPIO_RE_LSB,
> [STMPE_IDX_GPFER_LSB] = STMPE1601_REG_GPIO_FE_LSB,
> + [STMPE_IDX_GPPUR_LSB] = STMPE1601_REG_GPIO_PU_LSB,
> [STMPE_IDX_GPAFR_U_MSB] = STMPE1601_REG_GPIO_AF_U_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1601_REG_INT_EN_GPIO_MASK_LSB,
> [STMPE_IDX_ISGPIOR_MSB] = STMPE1601_REG_INT_STA_GPIO_MSB,
> @@ -695,6 +696,7 @@ static const u8 stmpe1801_regs[] = {
> [STMPE_IDX_GPDR_LSB] = STMPE1801_REG_GPIO_SET_DIR_LOW,
> [STMPE_IDX_GPRER_LSB] = STMPE1801_REG_GPIO_RE_LOW,
> [STMPE_IDX_GPFER_LSB] = STMPE1801_REG_GPIO_FE_LOW,
> + [STMPE_IDX_GPPUR_LSB] = STMPE1801_REG_GPIO_PULL_UP_LOW,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1801_REG_INT_EN_GPIO_MASK_LOW,
> [STMPE_IDX_ISGPIOR_LSB] = STMPE1801_REG_INT_STA_GPIO_LOW,
> };
> @@ -778,6 +780,8 @@ static const u8 stmpe24xx_regs[] = {
> [STMPE_IDX_GPDR_LSB] = STMPE24XX_REG_GPDR_LSB,
> [STMPE_IDX_GPRER_LSB] = STMPE24XX_REG_GPRER_LSB,
> [STMPE_IDX_GPFER_LSB] = STMPE24XX_REG_GPFER_LSB,
> + [STMPE_IDX_GPPUR_LSB] = STMPE24XX_REG_GPPUR_LSB,
> + [STMPE_IDX_GPPDR_LSB] = STMPE24XX_REG_GPPDR_LSB,
> [STMPE_IDX_GPAFR_U_MSB] = STMPE24XX_REG_GPAFR_U_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE24XX_REG_IEGPIOR_LSB,
> [STMPE_IDX_ISGPIOR_MSB] = STMPE24XX_REG_ISGPIOR_MSB,
> diff --git a/drivers/mfd/stmpe.h b/drivers/mfd/stmpe.h
> index bee0abf82040..84adb46b3e2f 100644
> --- a/drivers/mfd/stmpe.h
> +++ b/drivers/mfd/stmpe.h
> @@ -188,6 +188,7 @@ int stmpe_remove(struct stmpe *stmpe);
> #define STMPE1601_REG_GPIO_ED_MSB 0x8A
> #define STMPE1601_REG_GPIO_RE_LSB 0x8D
> #define STMPE1601_REG_GPIO_FE_LSB 0x8F
> +#define STMPE1601_REG_GPIO_PU_LSB 0x91
> #define STMPE1601_REG_GPIO_AF_U_MSB 0x92
>
> #define STMPE1601_SYS_CTRL_ENABLE_GPIO (1 << 3)
> @@ -276,6 +277,8 @@ int stmpe_remove(struct stmpe *stmpe);
> #define STMPE24XX_REG_GPEDR_MSB 0x8C
> #define STMPE24XX_REG_GPRER_LSB 0x91
> #define STMPE24XX_REG_GPFER_LSB 0x94
> +#define STMPE24XX_REG_GPPUR_LSB 0x97
> +#define STMPE24XX_REG_GPPDR_LSB 0x9a
> #define STMPE24XX_REG_GPAFR_U_MSB 0x9B
>
> #define STMPE24XX_SYS_CTRL_ENABLE_GPIO (1 << 3)
> diff --git a/include/linux/mfd/stmpe.h b/include/linux/mfd/stmpe.h
> index af9e1b07a630..976e1a390177 100644
> --- a/include/linux/mfd/stmpe.h
> +++ b/include/linux/mfd/stmpe.h
> @@ -50,6 +50,8 @@ enum {
> STMPE_IDX_GPEDR_MSB,
> STMPE_IDX_GPRER_LSB,
> STMPE_IDX_GPFER_LSB,
> + STMPE_IDX_GPPUR_LSB,
> + STMPE_IDX_GPPDR_LSB,
> STMPE_IDX_GPAFR_U_MSB,
> STMPE_IDX_IEGPIOR_LSB,
> STMPE_IDX_ISGPIOR_LSB,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
@ 2014-10-20 6:46 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2014-10-20 6:46 UTC (permalink / raw)
To: Linus Walleij; +Cc: Samuel Ortiz, Dmitry Torokhov, linux-kernel, linux-input
On Sat, 18 Oct 2014, Linus Walleij wrote:
> This adds the register offsets for pull up/down for the STMPE
> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> and keypad lines.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> patch series through the input tree, where the registers need to be
> used to enable the keypad on the STMPE2401.
> ---
> drivers/mfd/stmpe.c | 4 ++++
> drivers/mfd/stmpe.h | 3 +++
> include/linux/mfd/stmpe.h | 2 ++
> 3 files changed, 9 insertions(+)
Does this need to go in with the other patches in the set?
I'm _guessing_ that, as you've sent them separately, they can be
applied separately?
This needs to go in via MFD, but for my own reference:
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 3004d5ba0b82..497505bad4c4 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -547,6 +547,7 @@ static const u8 stmpe1601_regs[] = {
> [STMPE_IDX_GPDR_LSB] = STMPE1601_REG_GPIO_SET_DIR_LSB,
> [STMPE_IDX_GPRER_LSB] = STMPE1601_REG_GPIO_RE_LSB,
> [STMPE_IDX_GPFER_LSB] = STMPE1601_REG_GPIO_FE_LSB,
> + [STMPE_IDX_GPPUR_LSB] = STMPE1601_REG_GPIO_PU_LSB,
> [STMPE_IDX_GPAFR_U_MSB] = STMPE1601_REG_GPIO_AF_U_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1601_REG_INT_EN_GPIO_MASK_LSB,
> [STMPE_IDX_ISGPIOR_MSB] = STMPE1601_REG_INT_STA_GPIO_MSB,
> @@ -695,6 +696,7 @@ static const u8 stmpe1801_regs[] = {
> [STMPE_IDX_GPDR_LSB] = STMPE1801_REG_GPIO_SET_DIR_LOW,
> [STMPE_IDX_GPRER_LSB] = STMPE1801_REG_GPIO_RE_LOW,
> [STMPE_IDX_GPFER_LSB] = STMPE1801_REG_GPIO_FE_LOW,
> + [STMPE_IDX_GPPUR_LSB] = STMPE1801_REG_GPIO_PULL_UP_LOW,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE1801_REG_INT_EN_GPIO_MASK_LOW,
> [STMPE_IDX_ISGPIOR_LSB] = STMPE1801_REG_INT_STA_GPIO_LOW,
> };
> @@ -778,6 +780,8 @@ static const u8 stmpe24xx_regs[] = {
> [STMPE_IDX_GPDR_LSB] = STMPE24XX_REG_GPDR_LSB,
> [STMPE_IDX_GPRER_LSB] = STMPE24XX_REG_GPRER_LSB,
> [STMPE_IDX_GPFER_LSB] = STMPE24XX_REG_GPFER_LSB,
> + [STMPE_IDX_GPPUR_LSB] = STMPE24XX_REG_GPPUR_LSB,
> + [STMPE_IDX_GPPDR_LSB] = STMPE24XX_REG_GPPDR_LSB,
> [STMPE_IDX_GPAFR_U_MSB] = STMPE24XX_REG_GPAFR_U_MSB,
> [STMPE_IDX_IEGPIOR_LSB] = STMPE24XX_REG_IEGPIOR_LSB,
> [STMPE_IDX_ISGPIOR_MSB] = STMPE24XX_REG_ISGPIOR_MSB,
> diff --git a/drivers/mfd/stmpe.h b/drivers/mfd/stmpe.h
> index bee0abf82040..84adb46b3e2f 100644
> --- a/drivers/mfd/stmpe.h
> +++ b/drivers/mfd/stmpe.h
> @@ -188,6 +188,7 @@ int stmpe_remove(struct stmpe *stmpe);
> #define STMPE1601_REG_GPIO_ED_MSB 0x8A
> #define STMPE1601_REG_GPIO_RE_LSB 0x8D
> #define STMPE1601_REG_GPIO_FE_LSB 0x8F
> +#define STMPE1601_REG_GPIO_PU_LSB 0x91
> #define STMPE1601_REG_GPIO_AF_U_MSB 0x92
>
> #define STMPE1601_SYS_CTRL_ENABLE_GPIO (1 << 3)
> @@ -276,6 +277,8 @@ int stmpe_remove(struct stmpe *stmpe);
> #define STMPE24XX_REG_GPEDR_MSB 0x8C
> #define STMPE24XX_REG_GPRER_LSB 0x91
> #define STMPE24XX_REG_GPFER_LSB 0x94
> +#define STMPE24XX_REG_GPPUR_LSB 0x97
> +#define STMPE24XX_REG_GPPDR_LSB 0x9a
> #define STMPE24XX_REG_GPAFR_U_MSB 0x9B
>
> #define STMPE24XX_SYS_CTRL_ENABLE_GPIO (1 << 3)
> diff --git a/include/linux/mfd/stmpe.h b/include/linux/mfd/stmpe.h
> index af9e1b07a630..976e1a390177 100644
> --- a/include/linux/mfd/stmpe.h
> +++ b/include/linux/mfd/stmpe.h
> @@ -50,6 +50,8 @@ enum {
> STMPE_IDX_GPEDR_MSB,
> STMPE_IDX_GPRER_LSB,
> STMPE_IDX_GPFER_LSB,
> + STMPE_IDX_GPPUR_LSB,
> + STMPE_IDX_GPPDR_LSB,
> STMPE_IDX_GPAFR_U_MSB,
> STMPE_IDX_IEGPIOR_LSB,
> STMPE_IDX_ISGPIOR_LSB,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-10-20 6:46 ` Lee Jones
(?)
@ 2014-10-24 21:42 ` Dmitry Torokhov
2014-11-03 12:25 ` Lee Jones
-1 siblings, 1 reply; 14+ messages in thread
From: Dmitry Torokhov @ 2014-10-24 21:42 UTC (permalink / raw)
To: Lee Jones; +Cc: Linus Walleij, Samuel Ortiz, linux-kernel, linux-input
On Mon, Oct 20, 2014 at 07:46:05AM +0100, Lee Jones wrote:
> On Sat, 18 Oct 2014, Linus Walleij wrote:
>
> > This adds the register offsets for pull up/down for the STMPE
> > 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> > and keypad lines.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> > patch series through the input tree, where the registers need to be
> > used to enable the keypad on the STMPE2401.
> > ---
> > drivers/mfd/stmpe.c | 4 ++++
> > drivers/mfd/stmpe.h | 3 +++
> > include/linux/mfd/stmpe.h | 2 ++
> > 3 files changed, 9 insertions(+)
>
> Does this need to go in with the other patches in the set?
>
> I'm _guessing_ that, as you've sent them separately, they can be
> applied separately?
>
> This needs to go in via MFD, but for my own reference:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
The new register definitions are needed for patch #3. If you insist on
this going through MFD then please take the other 2 patches with my Ack
through MFD tree as well I do not think we need the whole song and dance
trying to synchronize 2 trees.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-10-20 6:46 ` Lee Jones
(?)
(?)
@ 2014-10-29 9:55 ` Linus Walleij
2014-10-29 19:31 ` Dmitry Torokhov
-1 siblings, 1 reply; 14+ messages in thread
From: Linus Walleij @ 2014-10-29 9:55 UTC (permalink / raw)
To: Lee Jones; +Cc: Samuel Ortiz, Dmitry Torokhov, linux-kernel, Linux Input
On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Sat, 18 Oct 2014, Linus Walleij wrote:
>
>> This adds the register offsets for pull up/down for the STMPE
>> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
>> and keypad lines.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
>> patch series through the input tree, where the registers need to be
>> used to enable the keypad on the STMPE2401.
>> ---
>> drivers/mfd/stmpe.c | 4 ++++
>> drivers/mfd/stmpe.h | 3 +++
>> include/linux/mfd/stmpe.h | 2 ++
>> 3 files changed, 9 insertions(+)
>
> Does this need to go in with the other patches in the set?
>
> I'm _guessing_ that, as you've sent them separately, they can be
> applied separately?
No sorry if it was unclear, the series need to go in toghether.
So this patch adds some infrastructure to the MFD device which
is then utilized by the input driver in a later patch.
> This needs to go in via MFD, but for my own reference:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
Dmitry can you merge this & the rest with Lee's ACK?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-10-29 9:55 ` Linus Walleij
@ 2014-10-29 19:31 ` Dmitry Torokhov
2014-11-03 9:27 ` Linus Walleij
0 siblings, 1 reply; 14+ messages in thread
From: Dmitry Torokhov @ 2014-10-29 19:31 UTC (permalink / raw)
To: Linus Walleij; +Cc: Lee Jones, Samuel Ortiz, linux-kernel, Linux Input
On Wednesday, October 29, 2014 10:55:14 AM Linus Walleij wrote:
> On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >> This adds the register offsets for pull up/down for the STMPE
> >> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> >> and keypad lines.
> >>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> >> patch series through the input tree, where the registers need to be
> >> used to enable the keypad on the STMPE2401.
> >> ---
> >>
> >> drivers/mfd/stmpe.c | 4 ++++
> >> drivers/mfd/stmpe.h | 3 +++
> >> include/linux/mfd/stmpe.h | 2 ++
> >> 3 files changed, 9 insertions(+)
> >
> > Does this need to go in with the other patches in the set?
> >
> > I'm _guessing_ that, as you've sent them separately, they can be
> > applied separately?
>
> No sorry if it was unclear, the series need to go in toghether.
> So this patch adds some infrastructure to the MFD device which
> is then utilized by the input driver in a later patch.
>
> > This needs to go in via MFD, but for my own reference:
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Dmitry can you merge this & the rest with Lee's ACK?
I'd be delighted, but it _sounded_ like Lee wanted it to go though MFD?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-10-29 19:31 ` Dmitry Torokhov
@ 2014-11-03 9:27 ` Linus Walleij
2014-11-03 12:57 ` Lee Jones
0 siblings, 1 reply; 14+ messages in thread
From: Linus Walleij @ 2014-11-03 9:27 UTC (permalink / raw)
To: Dmitry Torokhov, Lee Jones; +Cc: Samuel Ortiz, linux-kernel, Linux Input
On Wed, Oct 29, 2014 at 8:31 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wednesday, October 29, 2014 10:55:14 AM Linus Walleij wrote:
>> On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> > On Sat, 18 Oct 2014, Linus Walleij wrote:
>> >> This adds the register offsets for pull up/down for the STMPE
>> >> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
>> >> and keypad lines.
>> >>
>> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> >> ---
>> >> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
>> >> patch series through the input tree, where the registers need to be
>> >> used to enable the keypad on the STMPE2401.
>> >> ---
>> >>
>> >> drivers/mfd/stmpe.c | 4 ++++
>> >> drivers/mfd/stmpe.h | 3 +++
>> >> include/linux/mfd/stmpe.h | 2 ++
>> >> 3 files changed, 9 insertions(+)
>> >
>> > Does this need to go in with the other patches in the set?
>> >
>> > I'm _guessing_ that, as you've sent them separately, they can be
>> > applied separately?
>>
>> No sorry if it was unclear, the series need to go in toghether.
>> So this patch adds some infrastructure to the MFD device which
>> is then utilized by the input driver in a later patch.
>>
>> > This needs to go in via MFD, but for my own reference:
>> >
>> > Acked-by: Lee Jones <lee.jones@linaro.org>
>>
>> Dmitry can you merge this & the rest with Lee's ACK?
>
> I'd be delighted, but it _sounded_ like Lee wanted it to go though MFD?
Lee, can Dmitry take these through input?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-10-24 21:42 ` Dmitry Torokhov
@ 2014-11-03 12:25 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2014-11-03 12:25 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Linus Walleij, Samuel Ortiz, linux-kernel, linux-input
On Fri, 24 Oct 2014, Dmitry Torokhov wrote:
> On Mon, Oct 20, 2014 at 07:46:05AM +0100, Lee Jones wrote:
> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >
> > > This adds the register offsets for pull up/down for the STMPE
> > > 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> > > and keypad lines.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > > ---
> > > Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> > > patch series through the input tree, where the registers need to be
> > > used to enable the keypad on the STMPE2401.
> > > ---
> > > drivers/mfd/stmpe.c | 4 ++++
> > > drivers/mfd/stmpe.h | 3 +++
> > > include/linux/mfd/stmpe.h | 2 ++
> > > 3 files changed, 9 insertions(+)
> >
> > Does this need to go in with the other patches in the set?
> >
> > I'm _guessing_ that, as you've sent them separately, they can be
> > applied separately?
> >
> > This needs to go in via MFD, but for my own reference:
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> The new register definitions are needed for patch #3. If you insist on
> this going through MFD then please take the other 2 patches with my Ack
> through MFD tree as well I do not think we need the whole song and dance
> trying to synchronize 2 trees.
Actually, I can't see the other patches as they weren't sent to me.
Please apply them all to your tree with my Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
@ 2014-11-03 12:25 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2014-11-03 12:25 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Linus Walleij, Samuel Ortiz, linux-kernel, linux-input
On Fri, 24 Oct 2014, Dmitry Torokhov wrote:
> On Mon, Oct 20, 2014 at 07:46:05AM +0100, Lee Jones wrote:
> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >
> > > This adds the register offsets for pull up/down for the STMPE
> > > 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> > > and keypad lines.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > > ---
> > > Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> > > patch series through the input tree, where the registers need to be
> > > used to enable the keypad on the STMPE2401.
> > > ---
> > > drivers/mfd/stmpe.c | 4 ++++
> > > drivers/mfd/stmpe.h | 3 +++
> > > include/linux/mfd/stmpe.h | 2 ++
> > > 3 files changed, 9 insertions(+)
> >
> > Does this need to go in with the other patches in the set?
> >
> > I'm _guessing_ that, as you've sent them separately, they can be
> > applied separately?
> >
> > This needs to go in via MFD, but for my own reference:
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
>
> The new register definitions are needed for patch #3. If you insist on
> this going through MFD then please take the other 2 patches with my Ack
> through MFD tree as well I do not think we need the whole song and dance
> trying to synchronize 2 trees.
Actually, I can't see the other patches as they weren't sent to me.
Please apply them all to your tree with my Ack.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-11-03 9:27 ` Linus Walleij
@ 2014-11-03 12:57 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2014-11-03 12:57 UTC (permalink / raw)
To: Linus Walleij; +Cc: Dmitry Torokhov, Samuel Ortiz, linux-kernel, Linux Input
On Mon, 03 Nov 2014, Linus Walleij wrote:
> On Wed, Oct 29, 2014 at 8:31 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Wednesday, October 29, 2014 10:55:14 AM Linus Walleij wrote:
> >> On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones <lee.jones@linaro.org> wrote:
> >> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >> >> This adds the register offsets for pull up/down for the STMPE
> >> >> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> >> >> and keypad lines.
> >> >>
> >> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> >> ---
> >> >> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> >> >> patch series through the input tree, where the registers need to be
> >> >> used to enable the keypad on the STMPE2401.
> >> >> ---
> >> >>
> >> >> drivers/mfd/stmpe.c | 4 ++++
> >> >> drivers/mfd/stmpe.h | 3 +++
> >> >> include/linux/mfd/stmpe.h | 2 ++
> >> >> 3 files changed, 9 insertions(+)
> >> >
> >> > Does this need to go in with the other patches in the set?
> >> >
> >> > I'm _guessing_ that, as you've sent them separately, they can be
> >> > applied separately?
> >>
> >> No sorry if it was unclear, the series need to go in toghether.
> >> So this patch adds some infrastructure to the MFD device which
> >> is then utilized by the input driver in a later patch.
> >>
> >> > This needs to go in via MFD, but for my own reference:
> >> >
> >> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >>
> >> Dmitry can you merge this & the rest with Lee's ACK?
> >
> > I'd be delighted, but it _sounded_ like Lee wanted it to go though MFD?
>
> Lee, can Dmitry take these through input?
That was weird, I replied at the same as as you sent this.
Yes, it's fine.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
@ 2014-11-03 12:57 ` Lee Jones
0 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2014-11-03 12:57 UTC (permalink / raw)
To: Linus Walleij; +Cc: Dmitry Torokhov, Samuel Ortiz, linux-kernel, Linux Input
On Mon, 03 Nov 2014, Linus Walleij wrote:
> On Wed, Oct 29, 2014 at 8:31 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > On Wednesday, October 29, 2014 10:55:14 AM Linus Walleij wrote:
> >> On Mon, Oct 20, 2014 at 8:46 AM, Lee Jones <lee.jones@linaro.org> wrote:
> >> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >> >> This adds the register offsets for pull up/down for the STMPE
> >> >> 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> >> >> and keypad lines.
> >> >>
> >> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> >> ---
> >> >> Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> >> >> patch series through the input tree, where the registers need to be
> >> >> used to enable the keypad on the STMPE2401.
> >> >> ---
> >> >>
> >> >> drivers/mfd/stmpe.c | 4 ++++
> >> >> drivers/mfd/stmpe.h | 3 +++
> >> >> include/linux/mfd/stmpe.h | 2 ++
> >> >> 3 files changed, 9 insertions(+)
> >> >
> >> > Does this need to go in with the other patches in the set?
> >> >
> >> > I'm _guessing_ that, as you've sent them separately, they can be
> >> > applied separately?
> >>
> >> No sorry if it was unclear, the series need to go in toghether.
> >> So this patch adds some infrastructure to the MFD device which
> >> is then utilized by the input driver in a later patch.
> >>
> >> > This needs to go in via MFD, but for my own reference:
> >> >
> >> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >>
> >> Dmitry can you merge this & the rest with Lee's ACK?
> >
> > I'd be delighted, but it _sounded_ like Lee wanted it to go though MFD?
>
> Lee, can Dmitry take these through input?
That was weird, I replied at the same as as you sent this.
Yes, it's fine.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-11-03 12:57 ` Lee Jones
(?)
@ 2014-11-03 15:27 ` Linus Walleij
-1 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2014-11-03 15:27 UTC (permalink / raw)
To: Lee Jones; +Cc: Dmitry Torokhov, Samuel Ortiz, linux-kernel, Linux Input
On Mon, Nov 3, 2014 at 1:57 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 03 Nov 2014, Linus Walleij wrote:
>
>> Lee, can Dmitry take these through input?
>
> That was weird, I replied at the same as as you sent this.
Synchronicity... :)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-11-03 12:25 ` Lee Jones
(?)
@ 2014-12-04 18:10 ` Linus Walleij
2014-12-04 18:23 ` Dmitry Torokhov
-1 siblings, 1 reply; 14+ messages in thread
From: Linus Walleij @ 2014-12-04 18:10 UTC (permalink / raw)
To: Lee Jones, Dmitry Torokhov; +Cc: Samuel Ortiz, linux-kernel, Linux Input
On Mon, Nov 3, 2014 at 1:25 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 24 Oct 2014, Dmitry Torokhov wrote:
>
>> On Mon, Oct 20, 2014 at 07:46:05AM +0100, Lee Jones wrote:
>> > On Sat, 18 Oct 2014, Linus Walleij wrote:
>> >
>> > > This adds the register offsets for pull up/down for the STMPE
>> > > 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
>> > > and keypad lines.
>> > >
>> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> > > ---
>> > > Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
>> > > patch series through the input tree, where the registers need to be
>> > > used to enable the keypad on the STMPE2401.
>> > > ---
>> > > drivers/mfd/stmpe.c | 4 ++++
>> > > drivers/mfd/stmpe.h | 3 +++
>> > > include/linux/mfd/stmpe.h | 2 ++
>> > > 3 files changed, 9 insertions(+)
>> >
>> > Does this need to go in with the other patches in the set?
>> >
>> > I'm _guessing_ that, as you've sent them separately, they can be
>> > applied separately?
>> >
>> > This needs to go in via MFD, but for my own reference:
>> >
>> > Acked-by: Lee Jones <lee.jones@linaro.org>
>>
>> The new register definitions are needed for patch #3. If you insist on
>> this going through MFD then please take the other 2 patches with my Ack
>> through MFD tree as well I do not think we need the whole song and dance
>> trying to synchronize 2 trees.
>
> Actually, I can't see the other patches as they weren't sent to me.
>
> Please apply them all to your tree with my Ack.
Dmitry can you please apply them so we don't miss this merge window...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE
2014-12-04 18:10 ` Linus Walleij
@ 2014-12-04 18:23 ` Dmitry Torokhov
0 siblings, 0 replies; 14+ messages in thread
From: Dmitry Torokhov @ 2014-12-04 18:23 UTC (permalink / raw)
To: Linus Walleij; +Cc: Lee Jones, Samuel Ortiz, linux-kernel, Linux Input
On Thu, Dec 04, 2014 at 07:10:30PM +0100, Linus Walleij wrote:
> On Mon, Nov 3, 2014 at 1:25 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > On Fri, 24 Oct 2014, Dmitry Torokhov wrote:
> >
> >> On Mon, Oct 20, 2014 at 07:46:05AM +0100, Lee Jones wrote:
> >> > On Sat, 18 Oct 2014, Linus Walleij wrote:
> >> >
> >> > > This adds the register offsets for pull up/down for the STMPE
> >> > > 1601, 1801 and 24xx expanders. This is used to bias GPIO lines
> >> > > and keypad lines.
> >> > >
> >> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> > > ---
> >> > > Hi Sam, Lee: I think you should just ACK this so Dmitry can take the
> >> > > patch series through the input tree, where the registers need to be
> >> > > used to enable the keypad on the STMPE2401.
> >> > > ---
> >> > > drivers/mfd/stmpe.c | 4 ++++
> >> > > drivers/mfd/stmpe.h | 3 +++
> >> > > include/linux/mfd/stmpe.h | 2 ++
> >> > > 3 files changed, 9 insertions(+)
> >> >
> >> > Does this need to go in with the other patches in the set?
> >> >
> >> > I'm _guessing_ that, as you've sent them separately, they can be
> >> > applied separately?
> >> >
> >> > This needs to go in via MFD, but for my own reference:
> >> >
> >> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >>
> >> The new register definitions are needed for patch #3. If you insist on
> >> this going through MFD then please take the other 2 patches with my Ack
> >> through MFD tree as well I do not think we need the whole song and dance
> >> trying to synchronize 2 trees.
> >
> > Actually, I can't see the other patches as they weren't sent to me.
> >
> > Please apply them all to your tree with my Ack.
>
> Dmitry can you please apply them so we don't miss this merge window...
I had a question about missing error handling in 3/3? Have you seen it?
--
Dmitry
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-12-04 18:23 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-18 12:56 [PATCH 1/3] mfd: stmpe: add pull up/down register offsets for STMPE Linus Walleij
2014-10-20 6:46 ` Lee Jones
2014-10-20 6:46 ` Lee Jones
2014-10-24 21:42 ` Dmitry Torokhov
2014-11-03 12:25 ` Lee Jones
2014-11-03 12:25 ` Lee Jones
2014-12-04 18:10 ` Linus Walleij
2014-12-04 18:23 ` Dmitry Torokhov
2014-10-29 9:55 ` Linus Walleij
2014-10-29 19:31 ` Dmitry Torokhov
2014-11-03 9:27 ` Linus Walleij
2014-11-03 12:57 ` Lee Jones
2014-11-03 12:57 ` Lee Jones
2014-11-03 15:27 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.