All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node
@ 2021-12-23 12:27 Andy Shevchenko
  2022-01-05 14:22 ` Andy Shevchenko
  2022-01-16  0:24 ` Linus Walleij
  0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2021-12-23 12:27 UTC (permalink / raw)
  To: Alexandru Ardelean, linux-gpio, linux-kernel
  Cc: Thor Thayer, Linus Walleij, Bartosz Golaszewski, Andy Shevchenko

GPIO library now accepts fwnode as a firmware node, so
switch the driver to use it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpio-altera-a10sr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-altera-a10sr.c b/drivers/gpio/gpio-altera-a10sr.c
index 6af51feda06f..be1ed7ee5225 100644
--- a/drivers/gpio/gpio-altera-a10sr.c
+++ b/drivers/gpio/gpio-altera-a10sr.c
@@ -10,6 +10,7 @@
 #include <linux/gpio/driver.h>
 #include <linux/mfd/altera-a10sr.h>
 #include <linux/module.h>
+#include <linux/property.h>
 
 /**
  * struct altr_a10sr_gpio - Altera Max5 GPIO device private data structure
@@ -88,7 +89,7 @@ static int altr_a10sr_gpio_probe(struct platform_device *pdev)
 
 	gpio->gp = altr_a10sr_gc;
 	gpio->gp.parent = pdev->dev.parent;
-	gpio->gp.of_node = pdev->dev.of_node;
+	gpio->gp.fwnode = dev_fwnode(&pdev->dev);
 
 	return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
 }
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node
  2021-12-23 12:27 [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node Andy Shevchenko
@ 2022-01-05 14:22 ` Andy Shevchenko
  2022-01-16  0:24 ` Linus Walleij
  1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-01-05 14:22 UTC (permalink / raw)
  To: Alexandru Ardelean, linux-gpio, linux-kernel
  Cc: Thor Thayer, Linus Walleij, Bartosz Golaszewski

On Thu, Dec 23, 2021 at 02:27:33PM +0200, Andy Shevchenko wrote:
> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.

Any comments on this?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node
  2021-12-23 12:27 [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node Andy Shevchenko
  2022-01-05 14:22 ` Andy Shevchenko
@ 2022-01-16  0:24 ` Linus Walleij
  2022-01-24 15:11   ` Andy Shevchenko
  1 sibling, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2022-01-16  0:24 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Alexandru Ardelean, linux-gpio, linux-kernel, Thor Thayer,
	Bartosz Golaszewski

On Thu, Dec 23, 2021 at 1:27 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> GPIO library now accepts fwnode as a firmware node, so
> switch the driver to use it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

LGTM!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node
  2022-01-16  0:24 ` Linus Walleij
@ 2022-01-24 15:11   ` Andy Shevchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2022-01-24 15:11 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Alexandru Ardelean, linux-gpio, linux-kernel, Thor Thayer,
	Bartosz Golaszewski

On Sun, Jan 16, 2022 at 01:24:02AM +0100, Linus Walleij wrote:
> On Thu, Dec 23, 2021 at 1:27 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > GPIO library now accepts fwnode as a firmware node, so
> > switch the driver to use it.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> LGTM!
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-24 15:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-23 12:27 [PATCH v1 1/1] gpio: altera-a10sr: Switch to use fwnode instead of of_node Andy Shevchenko
2022-01-05 14:22 ` Andy Shevchenko
2022-01-16  0:24 ` Linus Walleij
2022-01-24 15:11   ` Andy Shevchenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.