All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Liu Gang <Gang.Liu@nxp.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>,
	bhupesh.sharma@nxp.com, scott.wood@nxp.com, Leo.Li@nxp.com
Subject: Re: [PATCH V4] drivers/gpio: Switch gpio-mpc8xxx to use gpio-generic
Date: Mon, 8 Feb 2016 18:34:29 +0100	[thread overview]
Message-ID: <CACRpkdYSwSW+kd+QyvfabNoPyAXx9VDWJaYD79p3krpgmX8iOg@mail.gmail.com> (raw)
In-Reply-To: <1454498854-33169-1-git-send-email-Gang.Liu@nxp.com>

On Wed, Feb 3, 2016 at 12:27 PM, Liu Gang <Gang.Liu@nxp.com> wrote:

> The new Layerscape platforms has the same ip block/controller
> as GPIO on PowerPC platforms(MPC8XXX), but the GPIO registers
> may be big or little endian. So the code needs to get the
> endian property from DTB, then make additional functions to
> fit all the PowerPC/Layerscape GPIO register read/write
> operations.
>
> gpio-generic.c provides an universal infrastructure for both
> big and little endian register operations. So switch the
> gpio-mpc8xxx to use gpio-generic can simplify the driver and
> reduce a lot of code.
>
> The IRQ and some workaround parts in gpio-mpc8xxx.c will be
> updated with the new API interfaces but following the
> original functionalities.
>
> Signed-off-by: Liu Gang <Gang.Liu@nxp.com>
> ---
> -V4: Rebase the kernel to v4.5-rc1 for the new gpio-generic
>      infrastructure based on Linus Walleij comments.

Patch applied, I guess this also silences the compile errors I've
been getting about the be32 accessors.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4] drivers/gpio: Switch gpio-mpc8xxx to use gpio-generic
Date: Mon, 8 Feb 2016 18:34:29 +0100	[thread overview]
Message-ID: <CACRpkdYSwSW+kd+QyvfabNoPyAXx9VDWJaYD79p3krpgmX8iOg@mail.gmail.com> (raw)
In-Reply-To: <1454498854-33169-1-git-send-email-Gang.Liu@nxp.com>

On Wed, Feb 3, 2016 at 12:27 PM, Liu Gang <Gang.Liu@nxp.com> wrote:

> The new Layerscape platforms has the same ip block/controller
> as GPIO on PowerPC platforms(MPC8XXX), but the GPIO registers
> may be big or little endian. So the code needs to get the
> endian property from DTB, then make additional functions to
> fit all the PowerPC/Layerscape GPIO register read/write
> operations.
>
> gpio-generic.c provides an universal infrastructure for both
> big and little endian register operations. So switch the
> gpio-mpc8xxx to use gpio-generic can simplify the driver and
> reduce a lot of code.
>
> The IRQ and some workaround parts in gpio-mpc8xxx.c will be
> updated with the new API interfaces but following the
> original functionalities.
>
> Signed-off-by: Liu Gang <Gang.Liu@nxp.com>
> ---
> -V4: Rebase the kernel to v4.5-rc1 for the new gpio-generic
>      infrastructure based on Linus Walleij comments.

Patch applied, I guess this also silences the compile errors I've
been getting about the be32 accessors.

Yours,
Linus Walleij

  reply	other threads:[~2016-02-08 17:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 11:27 Liu Gang
2016-02-03 11:27 ` Liu Gang
2016-02-08 17:34 ` Linus Walleij [this message]
2016-02-08 17:34   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYSwSW+kd+QyvfabNoPyAXx9VDWJaYD79p3krpgmX8iOg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=Gang.Liu@nxp.com \
    --cc=Leo.Li@nxp.com \
    --cc=bhupesh.sharma@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=scott.wood@nxp.com \
    --subject='Re: [PATCH V4] drivers/gpio: Switch gpio-mpc8xxx to use gpio-generic' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.