All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	sathyaosid@gmail.com,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1 2/2] gpio: gpio-wcove: fix irq pending status bit width
Date: Mon, 24 Apr 2017 15:15:18 +0200	[thread overview]
Message-ID: <CACRpkdYTjvKbz55jVXuEe6B=OE-dcirjv+TsVf5aKFv_S8u0Vg@mail.gmail.com> (raw)
In-Reply-To: <197e6ca51bb83ae865022d7ffd085d06dfee7795.1492190203.git.sathyanarayanan.kuppuswamy@linux.intel.com>

On Fri, Apr 14, 2017 at 7:29 PM,
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:

> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Whiskey cove PMIC has three GPIO banks with total number of 13 GPIO
> pins. But when checking for the pending status, for_each_set_bit() uses
> bit width of 7 and hence it only checks the status for first 7 GPIO pins
> missing to check/clear the status of rest of the GPIO pins. This patch
> fixes this issue.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Looks reasonable so patch applied.

Just looping in Mika & Andy so they have an idea about what's going
on.

Yours,
Linus Walleij

  reply	other threads:[~2017-04-24 13:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 17:29 [PATCH v1 1/2] gpio: gpio-wcove: fix GPIO irq status mask sathyanarayanan.kuppuswamy
2017-04-14 17:29 ` sathyanarayanan.kuppuswamy
2017-04-14 17:29 ` [PATCH v1 2/2] gpio: gpio-wcove: fix irq pending status bit width sathyanarayanan.kuppuswamy
2017-04-14 17:29   ` sathyanarayanan.kuppuswamy
2017-04-24 13:15   ` Linus Walleij [this message]
2017-04-24 13:15     ` Linus Walleij
2017-04-24 14:27     ` Andy Shevchenko
2017-04-24 14:27       ` Andy Shevchenko
2017-04-19 20:41 ` [PATCH v1 1/2] gpio: gpio-wcove: fix GPIO irq status mask Andy Shevchenko
2017-04-19 20:41   ` Andy Shevchenko
2017-04-21  0:52   ` sathyanarayanan kuppuswamy
2017-04-21  0:52     ` sathyanarayanan kuppuswamy
2017-04-24 19:15   ` [PATCH v2 1/1] gpio: gpio-wcove: fix GPIO IRQ " sathyanarayanan.kuppuswamy
2017-04-24 19:15     ` sathyanarayanan.kuppuswamy
2017-04-26 14:26     ` Linus Walleij
2017-04-26 14:26       ` Linus Walleij
2017-04-26 14:50       ` Mika Westerberg
2017-04-26 14:50         ` Mika Westerberg
2017-04-26 14:52       ` Andy Shevchenko
2017-04-26 14:52         ` Andy Shevchenko
2017-04-26 16:42       ` Gao, Bin
2017-04-26 16:42         ` Gao, Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdYTjvKbz55jVXuEe6B=OE-dcirjv+TsVf5aKFv_S8u0Vg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gnurou@gmail.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=sathyaosid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.