* [PATCH 01/10] gpio: gpiolib-of.c: fix checkpatch error
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
@ 2013-03-20 12:15 ` Laurent Navet
2013-03-27 12:36 ` Linus Walleij
2013-03-20 12:15 ` [PATCH 02/10] gpio: gpio-mvebu.c: fix checkpatch errors Laurent Navet
` (8 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:15 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpiolib-of.c:64: ERROR: code indent should use tabs where possible
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpiolib-of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
index a71a54a..8940793 100644
--- a/drivers/gpio/gpiolib-of.c
+++ b/drivers/gpio/gpiolib-of.c
@@ -61,7 +61,7 @@ static int of_gpiochip_find_and_xlate(struct gpio_chip *gc, void *data)
* in flags for the GPIO.
*/
int of_get_named_gpio_flags(struct device_node *np, const char *propname,
- int index, enum of_gpio_flags *flags)
+ int index, enum of_gpio_flags *flags)
{
/* Return -EPROBE_DEFER to support probe() functions to be called
* later when the GPIO actually becomes available
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 02/10] gpio: gpio-mvebu.c: fix checkpatch errors
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
2013-03-20 12:15 ` [PATCH 01/10] gpio: gpiolib-of.c: fix checkpatch error Laurent Navet
@ 2013-03-20 12:15 ` Laurent Navet
2013-03-27 12:39 ` Linus Walleij
2013-03-20 12:15 ` [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error Laurent Navet
` (7 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:15 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-mvebu.c:120: ERROR: space required before the open parenthesis '('
gpio/gpio-mvebu.c:136: ERROR: space required before the open parenthesis '('
gpio/gpio-mvebu.c:154: ERROR: space required before the open parenthesis '('
gpio/gpio-mvebu.c:404: ERROR: space required before the open parenthesis '('
gpio/gpio-mvebu.c:476: ERROR: "(foo*)" should be "(foo *)"
gpio/gpio-mvebu.c:480: ERROR: "(foo*)" should be "(foo *)"
gpio/gpio-mvebu.c:484: ERROR: "(foo*)" should be "(foo *)"
gpio/gpio-mvebu.c:512: ERROR: space prohibited after that '!' (ctx:BxW)
gpio/gpio-mvebu.c:518: ERROR: space prohibited after that '!' (ctx:BxW)
gpio/gpio-mvebu.c:518: ERROR: space required before the open brace '{'
gpio/gpio-mvebu.c:563: ERROR: space prohibited after that '!' (ctx:BxW)
gpio/gpio-mvebu.c:570: ERROR: trailing whitespace
gpio/gpio-mvebu.c:577: ERROR: space required before the open parenthesis '('
gpio/gpio-mvebu.c:635: ERROR: space prohibited after that '!' (ctx:BxW)
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-mvebu.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index 61a6fde..ca6d4ac 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -117,7 +117,7 @@ static inline void __iomem *mvebu_gpioreg_edge_cause(struct mvebu_gpio_chip *mvc
{
int cpu;
- switch(mvchip->soc_variant) {
+ switch (mvchip->soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION:
case MVEBU_GPIO_SOC_VARIANT_MV78200:
return mvchip->membase + GPIO_EDGE_CAUSE_OFF;
@@ -133,7 +133,7 @@ static inline void __iomem *mvebu_gpioreg_edge_mask(struct mvebu_gpio_chip *mvch
{
int cpu;
- switch(mvchip->soc_variant) {
+ switch (mvchip->soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION:
return mvchip->membase + GPIO_EDGE_MASK_OFF;
case MVEBU_GPIO_SOC_VARIANT_MV78200:
@@ -151,7 +151,7 @@ static void __iomem *mvebu_gpioreg_level_mask(struct mvebu_gpio_chip *mvchip)
{
int cpu;
- switch(mvchip->soc_variant) {
+ switch (mvchip->soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION:
return mvchip->membase + GPIO_LEVEL_MASK_OFF;
case MVEBU_GPIO_SOC_VARIANT_MV78200:
@@ -401,7 +401,7 @@ static int mvebu_gpio_irq_set_type(struct irq_data *d, unsigned int type)
/*
* Configure interrupt polarity.
*/
- switch(type) {
+ switch (type) {
case IRQ_TYPE_EDGE_RISING:
case IRQ_TYPE_LEVEL_HIGH:
u = readl_relaxed(mvebu_gpioreg_in_pol(mvchip));
@@ -473,15 +473,15 @@ static void mvebu_gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
static struct of_device_id mvebu_gpio_of_match[] = {
{
.compatible = "marvell,orion-gpio",
- .data = (void*) MVEBU_GPIO_SOC_VARIANT_ORION,
+ .data = (void *) MVEBU_GPIO_SOC_VARIANT_ORION,
},
{
.compatible = "marvell,mv78200-gpio",
- .data = (void*) MVEBU_GPIO_SOC_VARIANT_MV78200,
+ .data = (void *) MVEBU_GPIO_SOC_VARIANT_MV78200,
},
{
.compatible = "marvell,armadaxp-gpio",
- .data = (void*) MVEBU_GPIO_SOC_VARIANT_ARMADAXP,
+ .data = (void *) MVEBU_GPIO_SOC_VARIANT_ARMADAXP,
},
{
/* sentinel */
@@ -509,13 +509,13 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
soc_variant = MVEBU_GPIO_SOC_VARIANT_ORION;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (! res) {
+ if (!res) {
dev_err(&pdev->dev, "Cannot get memory resource\n");
return -ENODEV;
}
mvchip = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_gpio_chip), GFP_KERNEL);
- if (! mvchip){
+ if (!mvchip) {
dev_err(&pdev->dev, "Cannot allocate memory\n");
return -ENOMEM;
}
@@ -560,21 +560,21 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
* per-CPU registers */
if (soc_variant == MVEBU_GPIO_SOC_VARIANT_ARMADAXP) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
- if (! res) {
+ if (!res) {
dev_err(&pdev->dev, "Cannot get memory resource\n");
return -ENODEV;
}
mvchip->percpu_membase = devm_ioremap_resource(&pdev->dev,
res);
- if (IS_ERR(mvchip->percpu_membase))
+ if (IS_ERR(mvchip->percpu_membase))
return PTR_ERR(mvchip->percpu_membase);
}
/*
* Mask and clear GPIO interrupts.
*/
- switch(soc_variant) {
+ switch (soc_variant) {
case MVEBU_GPIO_SOC_VARIANT_ORION:
writel_relaxed(0, mvchip->membase + GPIO_EDGE_CAUSE_OFF);
writel_relaxed(0, mvchip->membase + GPIO_EDGE_MASK_OFF);
@@ -632,7 +632,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
gc = irq_alloc_generic_chip("mvebu_gpio_irq", 2, mvchip->irqbase,
mvchip->membase, handle_level_irq);
- if (! gc) {
+ if (!gc) {
dev_err(&pdev->dev, "Cannot allocate generic irq_chip\n");
return -ENOMEM;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 02/10] gpio: gpio-mvebu.c: fix checkpatch errors
2013-03-20 12:15 ` [PATCH 02/10] gpio: gpio-mvebu.c: fix checkpatch errors Laurent Navet
@ 2013-03-27 12:39 ` Linus Walleij
0 siblings, 0 replies; 25+ messages in thread
From: Linus Walleij @ 2013-03-27 12:39 UTC (permalink / raw)
To: Laurent Navet, Gregory CLEMENT, Jamie Lentin, Thomas Petazzoni,
Andrew Lunn
Cc: grant.likely, santosh.shilimkar, khilman, linux-omap, linux-kernel
On Wed, Mar 20, 2013 at 1:15 PM, Laurent Navet <laurent.navet@gmail.com> wrote:
> Fix :
> gpio/gpio-mvebu.c:120: ERROR: space required before the open parenthesis '('
> gpio/gpio-mvebu.c:136: ERROR: space required before the open parenthesis '('
> gpio/gpio-mvebu.c:154: ERROR: space required before the open parenthesis '('
> gpio/gpio-mvebu.c:404: ERROR: space required before the open parenthesis '('
> gpio/gpio-mvebu.c:476: ERROR: "(foo*)" should be "(foo *)"
> gpio/gpio-mvebu.c:480: ERROR: "(foo*)" should be "(foo *)"
> gpio/gpio-mvebu.c:484: ERROR: "(foo*)" should be "(foo *)"
> gpio/gpio-mvebu.c:512: ERROR: space prohibited after that '!' (ctx:BxW)
> gpio/gpio-mvebu.c:518: ERROR: space prohibited after that '!' (ctx:BxW)
> gpio/gpio-mvebu.c:518: ERROR: space required before the open brace '{'
> gpio/gpio-mvebu.c:563: ERROR: space prohibited after that '!' (ctx:BxW)
> gpio/gpio-mvebu.c:570: ERROR: trailing whitespace
> gpio/gpio-mvebu.c:577: ERROR: space required before the open parenthesis '('
> gpio/gpio-mvebu.c:635: ERROR: space prohibited after that '!' (ctx:BxW)
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Patch applied.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
2013-03-20 12:15 ` [PATCH 01/10] gpio: gpiolib-of.c: fix checkpatch error Laurent Navet
2013-03-20 12:15 ` [PATCH 02/10] gpio: gpio-mvebu.c: fix checkpatch errors Laurent Navet
@ 2013-03-20 12:15 ` Laurent Navet
2013-03-20 12:24 ` Santosh Shilimkar
2013-03-27 12:41 ` Linus Walleij
2013-03-20 12:15 ` [PATCH 04/10] gpio: gpio-pca953x.c: " Laurent Navet
` (6 subsequent siblings)
9 siblings, 2 replies; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:15 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-omap.c:697: ERROR: space required before the open parenthesis '('
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 159f5c5..7e8f791 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -694,7 +694,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
if (WARN_ON(!isr_reg))
goto exit;
- while(1) {
+ while (1) {
u32 isr_saved, level_mask = 0;
u32 enabled;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error
2013-03-20 12:15 ` [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error Laurent Navet
@ 2013-03-20 12:24 ` Santosh Shilimkar
2013-03-27 12:41 ` Linus Walleij
1 sibling, 0 replies; 25+ messages in thread
From: Santosh Shilimkar @ 2013-03-20 12:24 UTC (permalink / raw)
To: Laurent Navet
Cc: grant.likely, linus.walleij, Kevin Hilman, linux-omap, linux-kernel
On Wednesday 20 March 2013 05:45 PM, Laurent Navet wrote:
> Fix :
> gpio/gpio-omap.c:697: ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error
@ 2013-03-20 12:24 ` Santosh Shilimkar
0 siblings, 0 replies; 25+ messages in thread
From: Santosh Shilimkar @ 2013-03-20 12:24 UTC (permalink / raw)
To: Laurent Navet
Cc: grant.likely, linus.walleij, Kevin Hilman, linux-omap, linux-kernel
On Wednesday 20 March 2013 05:45 PM, Laurent Navet wrote:
> Fix :
> gpio/gpio-omap.c:697: ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error
2013-03-20 12:24 ` Santosh Shilimkar
@ 2013-03-20 12:33 ` Santosh Shilimkar
-1 siblings, 0 replies; 25+ messages in thread
From: Santosh Shilimkar @ 2013-03-20 12:33 UTC (permalink / raw)
To: Laurent Navet
Cc: grant.likely, linus.walleij, Kevin Hilman, linux-omap, linux-kernel
On Wednesday 20 March 2013 05:54 PM, Santosh Shilimkar wrote:
> On Wednesday 20 March 2013 05:45 PM, Laurent Navet wrote:
>> Fix :
>> gpio/gpio-omap.c:697: ERROR: space required before the open parenthesis '('
>>
>> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
>> ---
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
Minor suggestion.
You might want to use $subject like "coding style fixes".
No strong opinion though.
^ permalink raw reply [flat|nested] 25+ messages in thread* Re: [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error
@ 2013-03-20 12:33 ` Santosh Shilimkar
0 siblings, 0 replies; 25+ messages in thread
From: Santosh Shilimkar @ 2013-03-20 12:33 UTC (permalink / raw)
To: Laurent Navet
Cc: grant.likely, linus.walleij, Kevin Hilman, linux-omap, linux-kernel
On Wednesday 20 March 2013 05:54 PM, Santosh Shilimkar wrote:
> On Wednesday 20 March 2013 05:45 PM, Laurent Navet wrote:
>> Fix :
>> gpio/gpio-omap.c:697: ERROR: space required before the open parenthesis '('
>>
>> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
>> ---
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
Minor suggestion.
You might want to use $subject like "coding style fixes".
No strong opinion though.
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error
2013-03-20 12:15 ` [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error Laurent Navet
2013-03-20 12:24 ` Santosh Shilimkar
@ 2013-03-27 12:41 ` Linus Walleij
1 sibling, 0 replies; 25+ messages in thread
From: Linus Walleij @ 2013-03-27 12:41 UTC (permalink / raw)
To: Laurent Navet
Cc: grant.likely, santosh.shilimkar, khilman, linux-omap, linux-kernel
On Wed, Mar 20, 2013 at 1:15 PM, Laurent Navet <laurent.navet@gmail.com> wrote:
> Fix :
> gpio/gpio-omap.c:697: ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Applied with Santosh's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 04/10] gpio: gpio-pca953x.c: fix checkpatch error
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
` (2 preceding siblings ...)
2013-03-20 12:15 ` [PATCH 03/10] gpio: gpio-omap.c: fix checkpatch error Laurent Navet
@ 2013-03-20 12:15 ` Laurent Navet
2013-03-27 12:42 ` Linus Walleij
2013-03-20 12:15 ` [PATCH 05/10] gpio: gpio-pxa.c: fix checkpatch errors Laurent Navet
` (5 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:15 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-pca953x.c:150: ERROR: else should follow close brace '}'
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-pca953x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 2405946..15dbc36 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -146,8 +146,7 @@ static int pca953x_write_regs(struct pca953x_chip *chip, int reg, u8 *val)
ret = i2c_smbus_write_i2c_block_data(chip->client,
(reg << bank_shift) | REG_ADDR_AI,
NBANK(chip), val);
- }
- else {
+ } else {
switch (chip->chip_type) {
case PCA953X_TYPE:
ret = i2c_smbus_write_word_data(chip->client,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 05/10] gpio: gpio-pxa.c: fix checkpatch errors
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
` (3 preceding siblings ...)
2013-03-20 12:15 ` [PATCH 04/10] gpio: gpio-pca953x.c: " Laurent Navet
@ 2013-03-20 12:15 ` Laurent Navet
2013-03-27 12:43 ` Linus Walleij
2013-03-20 12:16 ` [PATCH 06/10] gpio: gpio-sch.c: fix checkpatch error Laurent Navet
` (4 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:15 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-pxa.c:605: ERROR: space required after that ',' (ctx:VxV)
gpio/gpio-pxa.c:672: ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-pxa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 9cc108d..6d01914 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -602,7 +602,7 @@ static int pxa_gpio_probe(struct platform_device *pdev)
for_each_gpio_chip(gpio, c) {
writel_relaxed(0, c->regbase + GFER_OFFSET);
writel_relaxed(0, c->regbase + GRER_OFFSET);
- writel_relaxed(~0,c->regbase + GEDR_OFFSET);
+ writel_relaxed(~0, c->regbase + GEDR_OFFSET);
/* unmask GPIO edge detect for AP side */
if (gpio_is_mmp_type(gpio_type))
writel_relaxed(~0, c->regbase + ED_MASK_OFFSET);
@@ -669,7 +669,7 @@ static void pxa_gpio_resume(void)
for_each_gpio_chip(gpio, c) {
/* restore level with set/clear */
- writel_relaxed( c->saved_gplr, c->regbase + GPSR_OFFSET);
+ writel_relaxed(c->saved_gplr, c->regbase + GPSR_OFFSET);
writel_relaxed(~c->saved_gplr, c->regbase + GPCR_OFFSET);
writel_relaxed(c->saved_grer, c->regbase + GRER_OFFSET);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 06/10] gpio: gpio-sch.c: fix checkpatch error
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
` (4 preceding siblings ...)
2013-03-20 12:15 ` [PATCH 05/10] gpio: gpio-pxa.c: fix checkpatch errors Laurent Navet
@ 2013-03-20 12:16 ` Laurent Navet
2013-03-27 12:44 ` Linus Walleij
2013-03-20 12:16 ` [PATCH 07/10] gpio: gpio-stp-xway.c: " Laurent Navet
` (3 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:16 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-sch.c:206: ERROR: switch and case should be at the same indent
Also remove blank lines
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-sch.c | 74 ++++++++++++++++++++++-------------------------
1 file changed, 35 insertions(+), 39 deletions(-)
diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
index edae963..cb60081 100644
--- a/drivers/gpio/gpio-sch.c
+++ b/drivers/gpio/gpio-sch.c
@@ -204,45 +204,41 @@ static int sch_gpio_probe(struct platform_device *pdev)
gpio_ba = res->start;
switch (id) {
- case PCI_DEVICE_ID_INTEL_SCH_LPC:
- sch_gpio_core.base = 0;
- sch_gpio_core.ngpio = 10;
-
- sch_gpio_resume.base = 10;
- sch_gpio_resume.ngpio = 4;
-
- /*
- * GPIO[6:0] enabled by default
- * GPIO7 is configured by the CMC as SLPIOVR
- * Enable GPIO[9:8] core powered gpios explicitly
- */
- outb(0x3, gpio_ba + CGEN + 1);
- /*
- * SUS_GPIO[2:0] enabled by default
- * Enable SUS_GPIO3 resume powered gpio explicitly
- */
- outb(0x8, gpio_ba + RGEN);
- break;
-
- case PCI_DEVICE_ID_INTEL_ITC_LPC:
- sch_gpio_core.base = 0;
- sch_gpio_core.ngpio = 5;
-
- sch_gpio_resume.base = 5;
- sch_gpio_resume.ngpio = 9;
- break;
-
- case PCI_DEVICE_ID_INTEL_CENTERTON_ILB:
- sch_gpio_core.base = 0;
- sch_gpio_core.ngpio = 21;
-
- sch_gpio_resume.base = 21;
- sch_gpio_resume.ngpio = 9;
- break;
-
- default:
- err = -ENODEV;
- goto err_sch_gpio_core;
+ case PCI_DEVICE_ID_INTEL_SCH_LPC:
+ sch_gpio_core.base = 0;
+ sch_gpio_core.ngpio = 10;
+ sch_gpio_resume.base = 10;
+ sch_gpio_resume.ngpio = 4;
+ /*
+ * GPIO[6:0] enabled by default
+ * GPIO7 is configured by the CMC as SLPIOVR
+ * Enable GPIO[9:8] core powered gpios explicitly
+ */
+ outb(0x3, gpio_ba + CGEN + 1);
+ /*
+ * SUS_GPIO[2:0] enabled by default
+ * Enable SUS_GPIO3 resume powered gpio explicitly
+ */
+ outb(0x8, gpio_ba + RGEN);
+ break;
+
+ case PCI_DEVICE_ID_INTEL_ITC_LPC:
+ sch_gpio_core.base = 0;
+ sch_gpio_core.ngpio = 5;
+ sch_gpio_resume.base = 5;
+ sch_gpio_resume.ngpio = 9;
+ break;
+
+ case PCI_DEVICE_ID_INTEL_CENTERTON_ILB:
+ sch_gpio_core.base = 0;
+ sch_gpio_core.ngpio = 21;
+ sch_gpio_resume.base = 21;
+ sch_gpio_resume.ngpio = 9;
+ break;
+
+ default:
+ err = -ENODEV;
+ goto err_sch_gpio_core;
}
sch_gpio_core.dev = &pdev->dev;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 07/10] gpio: gpio-stp-xway.c: fix checkpatch error
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
` (5 preceding siblings ...)
2013-03-20 12:16 ` [PATCH 06/10] gpio: gpio-sch.c: fix checkpatch error Laurent Navet
@ 2013-03-20 12:16 ` Laurent Navet
2013-03-27 12:45 ` Linus Walleij
2013-03-20 12:16 ` [PATCH 08/10] gpio: gpio-tc3589x.c: fix checkpatch errors Laurent Navet
` (2 subsequent siblings)
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:16 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-stp-xway.c:220: ERROR: trailing whitespace
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-stp-xway.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-stp-xway.c b/drivers/gpio/gpio-stp-xway.c
index c20e051..04882a9 100644
--- a/drivers/gpio/gpio-stp-xway.c
+++ b/drivers/gpio/gpio-stp-xway.c
@@ -217,7 +217,7 @@ static int xway_stp_probe(struct platform_device *pdev)
chip->virt = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(chip->virt))
return PTR_ERR(chip->virt);
-
+
chip->gc.dev = &pdev->dev;
chip->gc.label = "stp-xway";
chip->gc.direction_output = xway_stp_dir_out;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 08/10] gpio: gpio-tc3589x.c: fix checkpatch errors
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
` (6 preceding siblings ...)
2013-03-20 12:16 ` [PATCH 07/10] gpio: gpio-stp-xway.c: " Laurent Navet
@ 2013-03-20 12:16 ` Laurent Navet
2013-03-27 12:45 ` Linus Walleij
2013-03-20 12:16 ` [PATCH 09/10] gpio: gpio-timberdale.c: fix checkpatch error Laurent Navet
2013-03-20 12:16 ` [PATCH 10/10] gpio: gpio-tps65910.c: " Laurent Navet
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:16 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-tc3589x.c:285: ERROR: code indent should use tabs where possible
gpio/gpio-tc3589x.c:286: ERROR: code indent should use tabs where possible
gpio/gpio-tc3589x.c:287: ERROR: code indent should use tabs where possible
gpio/gpio-tc3589x.c:347: ERROR: code indent should use tabs where possible
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-tc3589x.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index c0595bb..d34d80d 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -282,9 +282,9 @@ static void tc3589x_gpio_irq_unmap(struct irq_domain *d, unsigned int virq)
}
static struct irq_domain_ops tc3589x_irq_ops = {
- .map = tc3589x_gpio_irq_map,
- .unmap = tc3589x_gpio_irq_unmap,
- .xlate = irq_domain_xlate_twocell,
+ .map = tc3589x_gpio_irq_map,
+ .unmap = tc3589x_gpio_irq_unmap,
+ .xlate = irq_domain_xlate_twocell,
};
static int tc3589x_gpio_irq_init(struct tc3589x_gpio *tc3589x_gpio,
@@ -344,7 +344,7 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)
tc3589x_gpio->chip.base = (pdata) ? pdata->gpio_base : -1;
#ifdef CONFIG_OF_GPIO
- tc3589x_gpio->chip.of_node = np;
+ tc3589x_gpio->chip.of_node = np;
#endif
tc3589x_gpio->irq_base = tc3589x->irq_base ?
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* Re: [PATCH 08/10] gpio: gpio-tc3589x.c: fix checkpatch errors
2013-03-20 12:16 ` [PATCH 08/10] gpio: gpio-tc3589x.c: fix checkpatch errors Laurent Navet
@ 2013-03-27 12:45 ` Linus Walleij
0 siblings, 0 replies; 25+ messages in thread
From: Linus Walleij @ 2013-03-27 12:45 UTC (permalink / raw)
To: Laurent Navet
Cc: grant.likely, santosh.shilimkar, khilman, linux-omap, linux-kernel
On Wed, Mar 20, 2013 at 1:16 PM, Laurent Navet <laurent.navet@gmail.com> wrote:
> Fix :
> gpio/gpio-tc3589x.c:285: ERROR: code indent should use tabs where possible
> gpio/gpio-tc3589x.c:286: ERROR: code indent should use tabs where possible
> gpio/gpio-tc3589x.c:287: ERROR: code indent should use tabs where possible
> gpio/gpio-tc3589x.c:347: ERROR: code indent should use tabs where possible
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
Patch applied.
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 25+ messages in thread
* [PATCH 09/10] gpio: gpio-timberdale.c: fix checkpatch error
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
` (7 preceding siblings ...)
2013-03-20 12:16 ` [PATCH 08/10] gpio: gpio-tc3589x.c: fix checkpatch errors Laurent Navet
@ 2013-03-20 12:16 ` Laurent Navet
2013-03-27 12:46 ` Linus Walleij
2013-03-20 12:16 ` [PATCH 10/10] gpio: gpio-tps65910.c: " Laurent Navet
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:16 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-timberdale.c:171: ERROR: else should follow close brace '}'
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-timberdale.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
index 702cca9..4377405 100644
--- a/drivers/gpio/gpio-timberdale.c
+++ b/drivers/gpio/gpio-timberdale.c
@@ -167,8 +167,7 @@ static int timbgpio_irq_type(struct irq_data *d, unsigned trigger)
if (ver < 3) {
ret = -EINVAL;
goto out;
- }
- else {
+ } else {
flr |= 1 << offset;
bflr |= 1 << offset;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread* [PATCH 10/10] gpio: gpio-tps65910.c: fix checkpatch error
2013-03-20 12:15 GPIO - Fix checkpatch errors Laurent Navet
` (8 preceding siblings ...)
2013-03-20 12:16 ` [PATCH 09/10] gpio: gpio-timberdale.c: fix checkpatch error Laurent Navet
@ 2013-03-20 12:16 ` Laurent Navet
2013-03-27 12:47 ` Linus Walleij
9 siblings, 1 reply; 25+ messages in thread
From: Laurent Navet @ 2013-03-20 12:16 UTC (permalink / raw)
To: grant.likely, linus.walleij
Cc: santosh.shilimkar, khilman, linux-omap, linux-kernel, Laurent Navet
Fix :
gpio/gpio-tps65910.c:136: ERROR: space required before the open parenthesis '('
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/gpio/gpio-tps65910.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
index 5083825..0614621 100644
--- a/drivers/gpio/gpio-tps65910.c
+++ b/drivers/gpio/gpio-tps65910.c
@@ -133,7 +133,7 @@ static int tps65910_gpio_probe(struct platform_device *pdev)
tps65910_gpio->gpio_chip.owner = THIS_MODULE;
tps65910_gpio->gpio_chip.label = tps65910->i2c_client->name;
- switch(tps65910_chip_id(tps65910)) {
+ switch (tps65910_chip_id(tps65910)) {
case TPS65910:
tps65910_gpio->gpio_chip.ngpio = TPS65910_NUM_GPIO;
break;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 25+ messages in thread