[PATCH] gpio: mockup: don't depend twice on GPIOLIB

[PATCH] gpio: mockup: don't depend twice on GPIOLIB

[Uwe Kleine-König]

config GPIO_MOCKUP is defined in a big if GPIOLIB ... endif block so it
doesn't need to depend explicitly on GPIOLIB.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
 drivers/gpio/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index bb13c266c329..856fcd260ba2 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1465,7 +1465,6 @@ endmenu
 
 config GPIO_MOCKUP
 	tristate "GPIO Testing Driver"
-	depends on GPIOLIB
 	select IRQ_SIM
 	help
 	  This enables GPIO Testing driver, which provides a way to test GPIO
-- 
2.20.1

Re: [PATCH] gpio: mockup: don't depend twice on GPIOLIB

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 799 bytes --]

On 7/25/19 3:10 PM, Uwe Kleine-König wrote:
> config GPIO_MOCKUP is defined in a big if GPIOLIB ... endif block so it
> doesn't need to depend explicitly on GPIOLIB.
> 
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
>  drivers/gpio/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index bb13c266c329..856fcd260ba2 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1465,7 +1465,6 @@ endmenu
>  
>  config GPIO_MOCKUP
>  	tristate "GPIO Testing Driver"
> -	depends on GPIOLIB
>  	select IRQ_SIM
>  	help
>  	  This enables GPIO Testing driver, which provides a way to test GPIO
> 

I didn't get feedback for this patch. Did it fall through the cracks?

Best regards
Uwe


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] gpio: mockup: don't depend twice on GPIOLIB

[Linus Walleij]

On Wed, Aug 14, 2019 at 10:12 PM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
> On 7/25/19 3:10 PM, Uwe Kleine-König wrote:
> > config GPIO_MOCKUP is defined in a big if GPIOLIB ... endif block so it
> > doesn't need to depend explicitly on GPIOLIB.
> >
> > Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> > ---
> >  drivers/gpio/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index bb13c266c329..856fcd260ba2 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -1465,7 +1465,6 @@ endmenu
> >
> >  config GPIO_MOCKUP
> >       tristate "GPIO Testing Driver"
> > -     depends on GPIOLIB
> >       select IRQ_SIM
> >       help
> >         This enables GPIO Testing driver, which provides a way to test GPIO
> >
>
> I didn't get feedback for this patch. Did it fall through the cracks?

Weird, the patch is not in my inbox :(

I downloaded from lore.kernel.org and applied, thanks!

Yours,
Linus Walleij

Yours,
Linus Walleij

Re: [PATCH] gpio: mockup: don't depend twice on GPIOLIB

[Uwe Kleine-König]

[-- Attachment #1.1: Type: text/plain, Size: 1254 bytes --]

Hello Linus,

On 8/15/19 10:15 AM, Linus Walleij wrote:
> On Wed, Aug 14, 2019 at 10:12 PM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
>> On 7/25/19 3:10 PM, Uwe Kleine-König wrote:
>>> config GPIO_MOCKUP is defined in a big if GPIOLIB ... endif block so it
>>> doesn't need to depend explicitly on GPIOLIB.
>>>
>>> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
>>> ---
>>>  drivers/gpio/Kconfig | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>>> index bb13c266c329..856fcd260ba2 100644
>>> --- a/drivers/gpio/Kconfig
>>> +++ b/drivers/gpio/Kconfig
>>> @@ -1465,7 +1465,6 @@ endmenu
>>>
>>>  config GPIO_MOCKUP
>>>       tristate "GPIO Testing Driver"
>>> -     depends on GPIOLIB
>>>       select IRQ_SIM
>>>       help
>>>         This enables GPIO Testing driver, which provides a way to test GPIO
>>>
>>
>> I didn't get feedback for this patch. Did it fall through the cracks?
> 
> Weird, the patch is not in my inbox :(
> 
> I downloaded from lore.kernel.org and applied, thanks!

Thanks for that. Though I'm not entirely happy with that as this
procedure messed up my name in my S-o-b. Would you mind to fix that?

Best regards
Uwe


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] gpio: mockup: don't depend twice on GPIOLIB

[Linus Walleij]

On Mon, Aug 19, 2019 at 7:49 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote:
> On 8/15/19 10:15 AM, Linus Walleij wrote:

> > I downloaded from lore.kernel.org and applied, thanks!
>
> Thanks for that. Though I'm not entirely happy with that as this
> procedure messed up my name in my S-o-b. Would you mind to fix that?

Grrr lore.kernel.org can't be trusted to handle UTF-8 right...

OK fixed it by hand, thanks for pointing it out.

Yours,
Linus Walleij