From: Linus Walleij <linus.walleij@linaro.org> To: Jonas Jensen <jonas.jensen@gmail.com> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "arm@kernel.org" <arm@kernel.org>, "John Stultz" <john.stultz@linaro.org>, "Thomas Gleixner" <tglx@linutronix.de>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Tomasz Figa" <tomasz.figa@gmail.com>, "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>, "Arnd Bergmann" <arnd@arndb.de>, "Daniel Lezcano" <daniel.lezcano@linaro.org> Subject: Re: [PATCH v9] ARM: clocksource: add support for MOXA ART SoCs Date: Sat, 20 Jul 2013 22:45:29 +0200 [thread overview] Message-ID: <CACRpkdYktthfRsn9=9GjphXUbOEAswdCZCM48KFK2WRgBdj-Qw@mail.gmail.com> (raw) In-Reply-To: <1374048297-4321-1-git-send-email-jonas.jensen@gmail.com> On Wed, Jul 17, 2013 at 10:04 AM, Jonas Jensen <jonas.jensen@gmail.com> wrote: > +#include <linux/clk.h> > +#include <linux/clockchips.h> > +#include <linux/interrupt.h> > +#include <linux/irq.h> > +#include <linux/irqreturn.h> > +#include <linux/of.h> > +#include <linux/of_address.h> > +#include <linux/of_irq.h> > +#include <linux/io.h> > +#include <linux/clocksource.h> #include <linux/bitops.h> > +#define TIMEREG_CR_1_ENABLE BIT(0) Because BIT() comes from there. And we shall not rely on implicit #inclusion. Apart from that: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v9] ARM: clocksource: add support for MOXA ART SoCs Date: Sat, 20 Jul 2013 22:45:29 +0200 [thread overview] Message-ID: <CACRpkdYktthfRsn9=9GjphXUbOEAswdCZCM48KFK2WRgBdj-Qw@mail.gmail.com> (raw) In-Reply-To: <1374048297-4321-1-git-send-email-jonas.jensen@gmail.com> On Wed, Jul 17, 2013 at 10:04 AM, Jonas Jensen <jonas.jensen@gmail.com> wrote: > +#include <linux/clk.h> > +#include <linux/clockchips.h> > +#include <linux/interrupt.h> > +#include <linux/irq.h> > +#include <linux/irqreturn.h> > +#include <linux/of.h> > +#include <linux/of_address.h> > +#include <linux/of_irq.h> > +#include <linux/io.h> > +#include <linux/clocksource.h> #include <linux/bitops.h> > +#define TIMEREG_CR_1_ENABLE BIT(0) Because BIT() comes from there. And we shall not rely on implicit #inclusion. Apart from that: Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
next prev parent reply other threads:[~2013-07-20 20:45 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-18 10:00 [PATCH] ARM: clocksource: add support for MOXA ART SoCs Jonas Jensen 2013-06-18 10:00 ` Jonas Jensen 2013-06-18 15:14 ` Thomas Petazzoni 2013-06-18 15:14 ` Thomas Petazzoni 2013-06-18 15:28 ` Arnd Bergmann 2013-06-18 15:28 ` Arnd Bergmann 2013-06-26 14:53 ` [PATCH v2] " Jonas Jensen 2013-06-26 14:53 ` Jonas Jensen 2013-06-26 14:59 ` Jonas Jensen 2013-06-26 14:59 ` Jonas Jensen 2013-06-26 16:10 ` Uwe Kleine-König 2013-06-26 16:10 ` Uwe Kleine-König 2013-06-26 19:15 ` Linus Walleij 2013-06-26 19:15 ` Linus Walleij 2013-06-27 11:23 ` [PATCH v3] " Jonas Jensen 2013-06-27 11:23 ` Jonas Jensen 2013-06-28 13:34 ` Thomas Gleixner 2013-06-28 13:34 ` Thomas Gleixner 2013-07-01 14:02 ` [PATCH v4] " Jonas Jensen 2013-07-01 14:02 ` Jonas Jensen 2013-07-01 17:55 ` Thomas Gleixner 2013-07-01 17:55 ` Thomas Gleixner 2013-07-02 20:19 ` Linus Walleij 2013-07-02 20:19 ` Linus Walleij 2013-07-04 12:19 ` [PATCH v5] " Jonas Jensen 2013-07-04 12:19 ` Jonas Jensen 2013-07-04 21:42 ` Thomas Gleixner 2013-07-04 21:42 ` Thomas Gleixner 2013-07-05 10:05 ` Jonas Jensen 2013-07-05 10:05 ` Jonas Jensen 2013-07-05 10:21 ` Thomas Gleixner 2013-07-05 10:21 ` Thomas Gleixner 2013-07-05 11:48 ` Jonas Jensen 2013-07-05 11:48 ` Jonas Jensen 2013-07-05 10:04 ` [PATCH v6] " Jonas Jensen 2013-07-05 10:04 ` Jonas Jensen 2013-07-05 11:46 ` [PATCH v7] " Jonas Jensen 2013-07-05 11:46 ` Jonas Jensen 2013-07-16 13:52 ` Daniel Lezcano 2013-07-16 13:52 ` Daniel Lezcano 2013-07-16 14:44 ` [PATCH v8] " Jonas Jensen 2013-07-16 14:44 ` Jonas Jensen 2013-07-16 15:01 ` Daniel Lezcano 2013-07-16 15:01 ` Daniel Lezcano 2013-07-17 8:14 ` Jonas Jensen 2013-07-17 8:14 ` Jonas Jensen 2013-07-17 12:13 ` Daniel Lezcano 2013-07-17 12:13 ` Daniel Lezcano 2013-07-17 8:04 ` [PATCH v9] " Jonas Jensen 2013-07-17 8:04 ` Jonas Jensen 2013-07-19 11:12 ` [PATCH] ARM: clocksource: moxart: documentation: update device tree bindings document Jonas Jensen 2013-07-19 11:12 ` Jonas Jensen 2013-07-19 12:16 ` Daniel Lezcano 2013-07-19 12:16 ` Daniel Lezcano 2013-07-19 12:50 ` Jonas Jensen 2013-07-19 12:50 ` Jonas Jensen 2013-07-20 20:45 ` Linus Walleij [this message] 2013-07-20 20:45 ` [PATCH v9] ARM: clocksource: add support for MOXA ART SoCs Linus Walleij 2013-07-20 21:34 ` Daniel Lezcano 2013-07-20 21:34 ` Daniel Lezcano 2013-07-26 14:03 ` [PATCH] ARM: clocksource: moxart: add bitops.h include Jonas Jensen 2013-07-26 14:03 ` Jonas Jensen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACRpkdYktthfRsn9=9GjphXUbOEAswdCZCM48KFK2WRgBdj-Qw@mail.gmail.com' \ --to=linus.walleij@linaro.org \ --cc=arm@kernel.org \ --cc=arnd@arndb.de \ --cc=daniel.lezcano@linaro.org \ --cc=john.stultz@linaro.org \ --cc=jonas.jensen@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=thomas.petazzoni@free-electrons.com \ --cc=tomasz.figa@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.