* [PATCH -next] soc: integrator: Drop pointless static qualifier in integrator_soc_init()
@ 2020-07-15 2:47 ` YueHaibing
0 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2020-07-15 2:47 UTC (permalink / raw)
To: linus.walleij, gregkh, sudeep.holla
Cc: linux-arm-kernel, linux-kernel, YueHaibing
There is no need to have the 'struct regmap *syscon_regmap' variable
static since new value always be assigned before use it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/soc/versatile/soc-integrator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/versatile/soc-integrator.c b/drivers/soc/versatile/soc-integrator.c
index 7dcf77ccd31e..bab4ad87aa75 100644
--- a/drivers/soc/versatile/soc-integrator.c
+++ b/drivers/soc/versatile/soc-integrator.c
@@ -100,7 +100,7 @@ ATTRIBUTE_GROUPS(integrator);
static int __init integrator_soc_init(void)
{
- static struct regmap *syscon_regmap;
+ struct regmap *syscon_regmap;
struct soc_device *soc_dev;
struct soc_device_attribute *soc_dev_attr;
struct device_node *np;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] soc: integrator: Drop pointless static qualifier in integrator_soc_init()
@ 2020-07-15 2:47 ` YueHaibing
0 siblings, 0 replies; 4+ messages in thread
From: YueHaibing @ 2020-07-15 2:47 UTC (permalink / raw)
To: linus.walleij, gregkh, sudeep.holla
Cc: YueHaibing, linux-kernel, linux-arm-kernel
There is no need to have the 'struct regmap *syscon_regmap' variable
static since new value always be assigned before use it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/soc/versatile/soc-integrator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/versatile/soc-integrator.c b/drivers/soc/versatile/soc-integrator.c
index 7dcf77ccd31e..bab4ad87aa75 100644
--- a/drivers/soc/versatile/soc-integrator.c
+++ b/drivers/soc/versatile/soc-integrator.c
@@ -100,7 +100,7 @@ ATTRIBUTE_GROUPS(integrator);
static int __init integrator_soc_init(void)
{
- static struct regmap *syscon_regmap;
+ struct regmap *syscon_regmap;
struct soc_device *soc_dev;
struct soc_device_attribute *soc_dev_attr;
struct device_node *np;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soc: integrator: Drop pointless static qualifier in integrator_soc_init()
2020-07-15 2:47 ` YueHaibing
@ 2020-07-20 13:37 ` Linus Walleij
-1 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-07-20 13:37 UTC (permalink / raw)
To: YueHaibing; +Cc: Greg KH, Sudeep Holla, Linux ARM, linux-kernel
On Wed, Jul 15, 2020 at 4:47 AM YueHaibing <yuehaibing@huawei.com> wrote:
> There is no need to have the 'struct regmap *syscon_regmap' variable
> static since new value always be assigned before use it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soc: integrator: Drop pointless static qualifier in integrator_soc_init()
@ 2020-07-20 13:37 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-07-20 13:37 UTC (permalink / raw)
To: YueHaibing; +Cc: Greg KH, linux-kernel, Linux ARM, Sudeep Holla
On Wed, Jul 15, 2020 at 4:47 AM YueHaibing <yuehaibing@huawei.com> wrote:
> There is no need to have the 'struct regmap *syscon_regmap' variable
> static since new value always be assigned before use it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-20 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 2:47 [PATCH -next] soc: integrator: Drop pointless static qualifier in integrator_soc_init() YueHaibing
2020-07-15 2:47 ` YueHaibing
2020-07-20 13:37 ` Linus Walleij
2020-07-20 13:37 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.