From: Linus Walleij <linus.walleij@linaro.org> To: Hans Ulli Kroll <ulli.kroll@googlemail.com> Cc: Rob Herring <robh@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Linux USB List <linux-usb@vger.kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mark Rutland <mark.rutland@arm.com> Subject: Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller Date: Sat, 22 Apr 2017 02:22:28 +0200 [thread overview] Message-ID: <CACRpkdYqNTZxXx9JDFt7_2N=NoX3mEm_fTAsbXWkqHxeHWHGwQ@mail.gmail.com> (raw) In-Reply-To: <alpine.LNX.2.00.1703302023250.17971@T420s> On Thu, Mar 30, 2017 at 8:31 PM, Hans Ulli Kroll <ulli.kroll@googlemail.com> wrote: >> On Tue, Feb 21, 2017 at 3:43 PM, Rob Herring <robh@kernel.org> wrote: >> > On Fri, Feb 17, 2017 at 4:07 AM, Hans Ulli Kroll >> > <ulli.kroll@googlemail.com> wrote: >> >> Hi Rob, >> >> >> >> On Wed, 15 Feb 2017, Rob Herring wrote: >> >> >> >>> On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote: >> >>> > This adds DT bindings for the Faraday FOTG2 host controller. >> >>> > >> >>> > Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com> >> >>> > --- >> >>> > Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++++++++++++++ >> >>> > 1 file changed, 15 insertions(+) >> >>> > create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt >> >>> > >> >>> > diff --git a/Documentation/devicetree/bindings/usb/fotg2-host.txt b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> >>> > new file mode 100644 >> >>> > index 000000000000..4c07566a4bf5 >> >>> > --- /dev/null >> >>> > +++ b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> >>> > @@ -0,0 +1,15 @@ >> >>> > +Faraday FOTG Host controller >> >>> > + >> >>> > +Required properties: >> >>> > + >> >>> > +- compatible: should be "faraday,fotg210-hcd" >> >>> >> >>> hcd as in "host controller driver"? Bindings describe h/w not drivers. >> >>> >> >>> It's an OTG controller or host controller? >> >>> >> >> >> >> here only the host controller part used. >> >> >> >> faraday fotg2 is a dual role hcd/otg device and here is only the >> >> host part used. >> > >> > Because you don't care about device mode or restricted by the IP >> > configuration or SoC integration? The former is a user choice and >> > shouldn't be part of DT. The latter should be implied by an SoC >> > specific compatible string. Using only a compatible string for a >> > licensed IP is not specific enough as vendors use differing versions >> > and integrate them in different ways. >> >> Hans can you add: >> >> compatible = "cortina,gemini-fotg", "faraday,fotg210-hcd" or something >> as composite compatible for our controller? I hacked on it a bit and sent out. Hope you don't hate it too much. > I prefer > "faraday,fotg210-usb2" I simply named it after the IP core name, which is just "faraday,fotg210". > I've got rejected by Rob due the fact this is an dual role controller, > which supports both host and device mode. And DT must reflect this desgn > pattern. > > Currently I'm wrappingt my head around the design of the fsl-mph-dr-of.c > driver to use this as a blueprint for the Faraday driver. I don't know how much more of the dual-mode we need to reflect, I guess it comes up in OTG mode since we don't parse the host-only or device-only attributes (yet). Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> To: Hans Ulli Kroll <ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux USB List <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> Subject: Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller Date: Sat, 22 Apr 2017 02:22:28 +0200 [thread overview] Message-ID: <CACRpkdYqNTZxXx9JDFt7_2N=NoX3mEm_fTAsbXWkqHxeHWHGwQ@mail.gmail.com> (raw) In-Reply-To: <alpine.LNX.2.00.1703302023250.17971@T420s> On Thu, Mar 30, 2017 at 8:31 PM, Hans Ulli Kroll <ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote: >> On Tue, Feb 21, 2017 at 3:43 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: >> > On Fri, Feb 17, 2017 at 4:07 AM, Hans Ulli Kroll >> > <ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> wrote: >> >> Hi Rob, >> >> >> >> On Wed, 15 Feb 2017, Rob Herring wrote: >> >> >> >>> On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote: >> >>> > This adds DT bindings for the Faraday FOTG2 host controller. >> >>> > >> >>> > Signed-off-by: Hans Ulli Kroll <ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> >> >>> > --- >> >>> > Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++++++++++++++ >> >>> > 1 file changed, 15 insertions(+) >> >>> > create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt >> >>> > >> >>> > diff --git a/Documentation/devicetree/bindings/usb/fotg2-host.txt b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> >>> > new file mode 100644 >> >>> > index 000000000000..4c07566a4bf5 >> >>> > --- /dev/null >> >>> > +++ b/Documentation/devicetree/bindings/usb/fotg2-host.txt >> >>> > @@ -0,0 +1,15 @@ >> >>> > +Faraday FOTG Host controller >> >>> > + >> >>> > +Required properties: >> >>> > + >> >>> > +- compatible: should be "faraday,fotg210-hcd" >> >>> >> >>> hcd as in "host controller driver"? Bindings describe h/w not drivers. >> >>> >> >>> It's an OTG controller or host controller? >> >>> >> >> >> >> here only the host controller part used. >> >> >> >> faraday fotg2 is a dual role hcd/otg device and here is only the >> >> host part used. >> > >> > Because you don't care about device mode or restricted by the IP >> > configuration or SoC integration? The former is a user choice and >> > shouldn't be part of DT. The latter should be implied by an SoC >> > specific compatible string. Using only a compatible string for a >> > licensed IP is not specific enough as vendors use differing versions >> > and integrate them in different ways. >> >> Hans can you add: >> >> compatible = "cortina,gemini-fotg", "faraday,fotg210-hcd" or something >> as composite compatible for our controller? I hacked on it a bit and sent out. Hope you don't hate it too much. > I prefer > "faraday,fotg210-usb2" I simply named it after the IP core name, which is just "faraday,fotg210". > I've got rejected by Rob due the fact this is an dual role controller, > which supports both host and device mode. And DT must reflect this desgn > pattern. > > Currently I'm wrappingt my head around the design of the fsl-mph-dr-of.c > driver to use this as a blueprint for the Faraday driver. I don't know how much more of the dual-mode we need to reflect, I guess it comes up in OTG mode since we don't parse the host-only or device-only attributes (yet). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-22 0:22 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-08 20:00 [PATCH 0/3] usb: add device tree support for fotg2-hcd driver Hans Ulli Kroll 2017-02-08 20:00 ` Hans Ulli Kroll 2017-02-08 20:00 ` [PATCH 1/3] usb: host: fotg2: add devicetree probing Hans Ulli Kroll 2017-02-08 20:00 ` Hans Ulli Kroll 2017-02-08 23:51 ` kbuild test robot 2017-02-08 23:51 ` kbuild test robot 2017-02-09 4:27 ` kbuild test robot 2017-02-09 4:27 ` kbuild test robot 2017-02-09 14:20 ` [PATCH 1/3 v2] usb: host: fotg2: add device tree probing Hans Ulli Kroll 2017-02-10 13:12 ` Linus Walleij 2017-02-10 20:26 ` Arnd Bergmann 2017-02-17 11:02 ` Hans Ulli Kroll 2017-02-10 13:34 ` Greg Kroah-Hartman 2017-02-17 11:06 ` [PATCH 1/3 v3] " Hans Ulli Kroll 2017-02-08 20:00 ` [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller Hans Ulli Kroll 2017-02-08 20:00 ` Hans Ulli Kroll 2017-02-10 13:14 ` Linus Walleij 2017-02-15 23:00 ` Rob Herring 2017-02-17 10:07 ` Hans Ulli Kroll 2017-02-21 14:43 ` Rob Herring 2017-02-21 14:43 ` Rob Herring 2017-03-29 23:16 ` Linus Walleij 2017-03-30 18:31 ` Hans Ulli Kroll 2017-04-22 0:22 ` Linus Walleij [this message] 2017-04-22 0:22 ` Linus Walleij 2017-02-08 20:00 ` [PATCH 3/3] DT: add Faraday Tec. as vendor Hans Ulli Kroll 2017-02-10 13:16 ` Linus Walleij 2017-02-10 13:16 ` Linus Walleij 2017-02-11 3:04 ` Joel Stanley 2017-02-11 3:04 ` Joel Stanley 2017-02-12 20:37 ` Linus Walleij 2017-02-15 23:02 ` Rob Herring 2017-02-10 13:24 ` [PATCH 0/3] usb: add device tree support for fotg2-hcd driver Linus Walleij 2017-02-10 13:24 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACRpkdYqNTZxXx9JDFt7_2N=NoX3mEm_fTAsbXWkqHxeHWHGwQ@mail.gmail.com' \ --to=linus.walleij@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh@kernel.org \ --cc=ulli.kroll@googlemail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.