All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 1/1] arm: fix -march for ARM11
@ 2019-11-19 22:15 Heinrich Schuchardt
  2019-11-20 13:06 ` Linus Walleij
  2019-11-22  8:02 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2019-11-19 22:15 UTC (permalink / raw)
  To: u-boot

-march v5 is invalid for GCC 9.2.1. ARM11 is an armv6 implementation. So
change the architecture flag for the compiler to armv6.
Cf. https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html

Suggested-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 arch/arm/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 5384981c17..60af7e3199 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -12,8 +12,8 @@ arch-$(CONFIG_CPU_ARM926EJS)	=-march=armv5te
 arch-$(CONFIG_CPU_ARM946ES)	=-march=armv5te
 arch-$(CONFIG_CPU_SA1100)	=-march=armv4
 arch-$(CONFIG_CPU_PXA)		=
-arch-$(CONFIG_CPU_ARM1136)	=-march=armv5
-arch-$(CONFIG_CPU_ARM1176)	=-march=armv5t
+arch-$(CONFIG_CPU_ARM1136)	=-march=armv6
+arch-$(CONFIG_CPU_ARM1176)	=-march=armv6
 arch-$(CONFIG_CPU_V7A)		=$(call cc-option, -march=armv7-a, \
 				 $(call cc-option, -march=armv7))
 arch-$(CONFIG_CPU_V7M)		=-march=armv7-m
--
2.24.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] arm: fix -march for ARM11
  2019-11-19 22:15 [U-Boot] [PATCH 1/1] arm: fix -march for ARM11 Heinrich Schuchardt
@ 2019-11-20 13:06 ` Linus Walleij
  2019-11-22  8:02 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-11-20 13:06 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 19, 2019 at 11:16 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> -march v5 is invalid for GCC 9.2.1. ARM11 is an armv6 implementation. So
> change the architecture flag for the compiler to armv6.
> Cf. https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
>
> Suggested-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH 1/1] arm: fix -march for ARM11
  2019-11-19 22:15 [U-Boot] [PATCH 1/1] arm: fix -march for ARM11 Heinrich Schuchardt
  2019-11-20 13:06 ` Linus Walleij
@ 2019-11-22  8:02 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-11-22  8:02 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 19, 2019 at 11:16 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> -march v5 is invalid for GCC 9.2.1. ARM11 is an armv6 implementation. So
> change the architecture flag for the compiler to armv6.
> Cf. https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
>
> Suggested-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

After I read up on it I would add something to the commit saying
that the first -march=armv5 must have been wrong all the time
since there are no known implementations of
armv5, only armv5t, armv5te and armv5tej. Maybe add a link
to this:
https://gcc.gnu.org/gcc-9/changes.html

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-22  8:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 22:15 [U-Boot] [PATCH 1/1] arm: fix -march for ARM11 Heinrich Schuchardt
2019-11-20 13:06 ` Linus Walleij
2019-11-22  8:02 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.