[PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove

[PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove

[Jagan Teki]

This driver has been changed to use the resource managed
devm_drm_of_get_bridge() to get bridge from ->bind(), it's
unnecessary to call drm_of_panel_bridge_remove() to remove the
bridge from ->unbind() as devm_drm_of_get_bridge()
is automatically remove the bridge when @dev is unbound.

Drop it the drm_bridge_remove().

Cc: Linus Walleij <linus.walleij@linaro.org>
Reported-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/mcde/mcde_dsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 083a4728654d..960b49ea2ee5 100644
--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1122,7 +1122,6 @@ static void mcde_dsi_unbind(struct device *dev, struct device *master,
 {
 	struct mcde_dsi *d = dev_get_drvdata(dev);
 
-	drm_bridge_remove(d->bridge_out);
 	regmap_update_bits(d->prcmu, PRCM_DSI_SW_RESET,
 			   PRCM_DSI_SW_RESET_DSI0_SW_RESETN, 0);
 }
-- 
2.25.1

Re: [PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove

[Linus Walleij]

On Fri, Apr 1, 2022 at 5:05 PM Jagan Teki <jagan@amarulasolutions.com> wrote:

> This driver has been changed to use the resource managed
> devm_drm_of_get_bridge() to get bridge from ->bind(), it's
> unnecessary to call drm_of_panel_bridge_remove() to remove the
> bridge from ->unbind() as devm_drm_of_get_bridge()
> is automatically remove the bridge when @dev is unbound.
>
> Drop it the drm_bridge_remove().
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Reported-by: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH] drm: bridge: mcde_dsi: Drop explicit bridge remove

[Robert Foss]

Applied to drm-misc-next.