* [PATCH] pinctrl: sprd: Fix the incorrect pull-up definition
@ 2020-05-07 3:47 Baolin Wang
2020-05-16 9:19 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Baolin Wang @ 2020-05-07 3:47 UTC (permalink / raw)
To: linus.walleij
Cc: orsonzhai, zhang.lyra, baolin.wang7, linux-gpio, linux-kernel
The bits of pull up resistor selection were defined mistakenly,
thus fix them.
Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
---
drivers/pinctrl/sprd/pinctrl-sprd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
index 48cbf2a..08dc193 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -68,8 +68,8 @@
#define SLEEP_PULL_UP_MASK 0x1
#define SLEEP_PULL_UP_SHIFT 3
-#define PULL_UP_20K (BIT(12) | BIT(7))
-#define PULL_UP_4_7K BIT(12)
+#define PULL_UP_4_7K (BIT(12) | BIT(7))
+#define PULL_UP_20K BIT(7)
#define PULL_UP_MASK 0x21
#define PULL_UP_SHIFT 7
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sprd: Fix the incorrect pull-up definition
2020-05-07 3:47 [PATCH] pinctrl: sprd: Fix the incorrect pull-up definition Baolin Wang
@ 2020-05-16 9:19 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-05-16 9:19 UTC (permalink / raw)
To: Baolin Wang
Cc: Orson Zhai, Lyra Zhang, open list:GPIO SUBSYSTEM, linux-kernel
On Thu, May 7, 2020 at 5:47 AM Baolin Wang <baolin.wang7@gmail.com> wrote:
> The bits of pull up resistor selection were defined mistakenly,
> thus fix them.
>
> Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-16 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 3:47 [PATCH] pinctrl: sprd: Fix the incorrect pull-up definition Baolin Wang
2020-05-16 9:19 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.