* [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
@ 2022-09-26 14:20 ` Yang Yingliang
0 siblings, 0 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-09-26 14:20 UTC (permalink / raw)
To: linux-fbdev, dri-devel; +Cc: lee, daniel.thompson, yangyingliang
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
---
Resend for adding Sob.
---
drivers/video/backlight/ktd253-backlight.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/ktd253-backlight.c b/drivers/video/backlight/ktd253-backlight.c
index 37aa5a669530..d7d43454f64a 100644
--- a/drivers/video/backlight/ktd253-backlight.c
+++ b/drivers/video/backlight/ktd253-backlight.c
@@ -173,12 +173,9 @@ static int ktd253_backlight_probe(struct platform_device *pdev)
}
ktd253->gpiod = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
- if (IS_ERR(ktd253->gpiod)) {
- ret = PTR_ERR(ktd253->gpiod);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "gpio line missing or invalid.\n");
- return ret;
- }
+ if (IS_ERR(ktd253->gpiod))
+ return dev_err_probe(dev, PTR_ERR(ktd253->gpiod),
+ "gpio line missing or invalid.\n");
gpiod_set_consumer_name(ktd253->gpiod, dev_name(dev));
/* Bring backlight to a known off state */
msleep(KTD253_T_OFF_MS);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
@ 2022-09-26 14:20 ` Yang Yingliang
0 siblings, 0 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-09-26 14:20 UTC (permalink / raw)
To: linux-fbdev, dri-devel; +Cc: linus.walleij, lee, daniel.thompson, yangyingliang
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
---
Resend for adding Sob.
---
drivers/video/backlight/ktd253-backlight.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/ktd253-backlight.c b/drivers/video/backlight/ktd253-backlight.c
index 37aa5a669530..d7d43454f64a 100644
--- a/drivers/video/backlight/ktd253-backlight.c
+++ b/drivers/video/backlight/ktd253-backlight.c
@@ -173,12 +173,9 @@ static int ktd253_backlight_probe(struct platform_device *pdev)
}
ktd253->gpiod = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
- if (IS_ERR(ktd253->gpiod)) {
- ret = PTR_ERR(ktd253->gpiod);
- if (ret != -EPROBE_DEFER)
- dev_err(dev, "gpio line missing or invalid.\n");
- return ret;
- }
+ if (IS_ERR(ktd253->gpiod))
+ return dev_err_probe(dev, PTR_ERR(ktd253->gpiod),
+ "gpio line missing or invalid.\n");
gpiod_set_consumer_name(ktd253->gpiod, dev_name(dev));
/* Bring backlight to a known off state */
msleep(KTD253_T_OFF_MS);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
2022-09-26 14:20 ` Yang Yingliang
@ 2022-10-03 13:56 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-10-03 13:56 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-fbdev, dri-devel, lee, daniel.thompson
On Mon, Sep 26, 2022 at 4:14 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
@ 2022-10-03 13:56 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-10-03 13:56 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-fbdev, lee, daniel.thompson, dri-devel
On Mon, Sep 26, 2022 at 4:14 PM Yang Yingliang <yangyingliang@huawei.com> wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
2022-09-26 14:20 ` Yang Yingliang
@ 2022-10-24 12:33 ` Lee Jones
-1 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2022-10-24 12:33 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-fbdev, daniel.thompson, dri-devel
On Mon, 26 Sep 2022, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> Resend for adding Sob.
> ---
> drivers/video/backlight/ktd253-backlight.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper
@ 2022-10-24 12:33 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2022-10-24 12:33 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-fbdev, dri-devel, linus.walleij, daniel.thompson
On Mon, 26 Sep 2022, Yang Yingliang wrote:
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs. It's more simple in error path.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> Resend for adding Sob.
> ---
> drivers/video/backlight/ktd253-backlight.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-24 19:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 14:20 [PATCH -next resend] backlight: ktd253: Switch to use dev_err_probe() helper Yang Yingliang
2022-09-26 14:20 ` Yang Yingliang
2022-10-03 13:56 ` Linus Walleij
2022-10-03 13:56 ` Linus Walleij
2022-10-24 12:33 ` Lee Jones
2022-10-24 12:33 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.