From: Linus Walleij <linus.walleij@linaro.org>
To: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank
Date: Tue, 24 Nov 2020 16:04:34 +0100 [thread overview]
Message-ID: <CACRpkdZ793ARr6egT55RYnefuExhqDEUvFW6RX70YqAatbFm-w@mail.gmail.com> (raw)
In-Reply-To: <20201124090322.cjugamri37yxcqy7@sekiro>
On Tue, Nov 24, 2020 at 10:03 AM Ludovic Desroches
<ludovic.desroches@microchip.com> wrote:
> On Tue, Nov 24, 2020 at 09:31:36AM +0100, Linus Walleij wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On Fri, Nov 13, 2020 at 2:25 PM Eugen Hristev
> > <eugen.hristev@microchip.com> wrote:
> >
> > > Some products, like sama7g5, do not have a full last bank of PIO lines.
> > > In this case for example, sama7g5 only has 8 lines for the PE bank.
> > > PA0-31, PB0-31, PC0-31, PD0-31, PE0-7, in total 136 lines.
> > > To cope with this situation, added a data attribute that is product dependent,
> > > to specify the number of lines of the last bank.
> > > In case this number is different from the macro ATMEL_PIO_NPINS_PER_BANK,
> > > adjust the total number of lines accordingly.
> > > This will avoid advertising 160 lines instead of the actual 136, as this
> > > product supports, and to avoid reading/writing to invalid register addresses.
> > >
> > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> >
> > Nico/Ludovic: can you please look at this patch?
>
> I acked it one week ago but I get some nasty behaviors with my emails. Maybe you
> didn't receive the answer.
> https://lore.kernel.org/linux-gpio/20201116061549.ks6hfonyplwhknmq@sekiro/
No I didn't! Weird. b4 found your ACK anyways, so the patch is applied
now!
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank
Date: Tue, 24 Nov 2020 16:04:34 +0100 [thread overview]
Message-ID: <CACRpkdZ793ARr6egT55RYnefuExhqDEUvFW6RX70YqAatbFm-w@mail.gmail.com> (raw)
In-Reply-To: <20201124090322.cjugamri37yxcqy7@sekiro>
On Tue, Nov 24, 2020 at 10:03 AM Ludovic Desroches
<ludovic.desroches@microchip.com> wrote:
> On Tue, Nov 24, 2020 at 09:31:36AM +0100, Linus Walleij wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On Fri, Nov 13, 2020 at 2:25 PM Eugen Hristev
> > <eugen.hristev@microchip.com> wrote:
> >
> > > Some products, like sama7g5, do not have a full last bank of PIO lines.
> > > In this case for example, sama7g5 only has 8 lines for the PE bank.
> > > PA0-31, PB0-31, PC0-31, PD0-31, PE0-7, in total 136 lines.
> > > To cope with this situation, added a data attribute that is product dependent,
> > > to specify the number of lines of the last bank.
> > > In case this number is different from the macro ATMEL_PIO_NPINS_PER_BANK,
> > > adjust the total number of lines accordingly.
> > > This will avoid advertising 160 lines instead of the actual 136, as this
> > > product supports, and to avoid reading/writing to invalid register addresses.
> > >
> > > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> >
> > Nico/Ludovic: can you please look at this patch?
>
> I acked it one week ago but I get some nasty behaviors with my emails. Maybe you
> didn't receive the answer.
> https://lore.kernel.org/linux-gpio/20201116061549.ks6hfonyplwhknmq@sekiro/
No I didn't! Weird. b4 found your ACK anyways, so the patch is applied
now!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-24 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:24 [PATCH] pinctrl: at91-pio4: add support for fewer lines on last PIO bank Eugen Hristev
2020-11-16 6:15 ` Ludovic Desroches
2020-11-16 6:15 ` Ludovic Desroches
2020-11-24 8:31 ` Linus Walleij
2020-11-24 9:03 ` Ludovic Desroches
2020-11-24 9:03 ` Ludovic Desroches
2020-11-24 15:04 ` Linus Walleij [this message]
2020-11-24 15:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ793ARr6egT55RYnefuExhqDEUvFW6RX70YqAatbFm-w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=eugen.hristev@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.